vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

chore: rework implicit commit checks

Browse source 
Add in some more "reset" queries
- begin
- start

Also check *after* resetting

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang 2023-10-19 18:10:28 +05:30
parent 58b8b26b93
commit f9b9184223
No known key found for this signature in database
GPG key ID: 9DCC61E211BF645F
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
frappe/database/database.py
View file

@ -375,11 +375,12 @@ class Database:
"""Raises exception if more than 200,000 `INSERT`, `UPDATE` queries are
executed in one transaction. This is to ensure that writes are always flushed otherwise this
could cause the system to hang."""
self.check_implicit_commit(query, ignore_implicit_commit)
if query and is_query_type(query, ("commit", "rollback")):
if query and is_query_type(query, ("start", "begin", "commit", "rollback")):
self.transaction_writes = 0
self.check_implicit_commit(query, ignore_implicit_commit)
if query[:6].lower() in ("update", "insert", "delete"):
self.transaction_writes += 1
if self.transaction_writes > self.MAX_WRITES_PER_TRANSACTION: