From 50414c0ffb9a67ff7bcf05cb4ddec019896ece98 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Tue, 26 Jul 2022 01:07:13 +0200 Subject: [PATCH 1/2] fix: pass doc to get_perm --- frappe/public/js/frappe/model/perm.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js index 3ea9c6bc95..00640494ea 100644 --- a/frappe/public/js/frappe/model/perm.js +++ b/frappe/public/js/frappe/model/perm.js @@ -23,7 +23,7 @@ $.extend(frappe.perm, { has_perm: (doctype, permlevel, ptype, doc) => { if (!permlevel) permlevel = 0; if (!frappe.perm.doctype_perm[doctype]) { - frappe.perm.doctype_perm[doctype] = frappe.perm.get_perm(doctype); + frappe.perm.doctype_perm[doctype] = frappe.perm.get_perm(doctype, doc); } let perms = frappe.perm.doctype_perm[doctype]; From a560a7f7aaf2121c305bb8bdca68c8273151e590 Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Fri, 29 Jul 2022 13:03:12 +0200 Subject: [PATCH 2/2] fix: remove redundant lines --- frappe/public/js/frappe/model/perm.js | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/frappe/public/js/frappe/model/perm.js b/frappe/public/js/frappe/model/perm.js index 00640494ea..c6c94ce6c1 100644 --- a/frappe/public/js/frappe/model/perm.js +++ b/frappe/public/js/frappe/model/perm.js @@ -30,15 +30,7 @@ $.extend(frappe.perm, { if (!perms || !perms[permlevel]) return false; - let perm = !!perms[permlevel][ptype]; - - if (permlevel === 0 && perm && doc) { - let docinfo = frappe.model.get_docinfo(doctype, doc.name); - if (docinfo && !docinfo.permissions[ptype]) - perm = false; - } - - return perm; + return !!perms[permlevel][ptype]; }, get_perm: (doctype, doc) => {