From bbdb2532d29e7392e6abb95838b7c794e33f9d7e Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 11 Aug 2020 17:55:19 +0530 Subject: [PATCH 01/15] fix: use shadow-sm for print format container --- frappe/templates/styles/standard.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/templates/styles/standard.css b/frappe/templates/styles/standard.css index 66ae263848..2d06734723 100644 --- a/frappe/templates/styles/standard.css +++ b/frappe/templates/styles/standard.css @@ -5,7 +5,7 @@ } .print-format { background-color: white; - box-shadow: var(--shadow-xs); + box-shadow: var(--shadow-sm); border: 1px solid var(--border-color); max-width: 8.3in; min-height: 11.69in; From b44c69fba692cb3dec4ee1672f65df0ebe188ff3 Mon Sep 17 00:00:00 2001 From: prssanna Date: Thu, 13 Aug 2020 15:36:22 +0530 Subject: [PATCH 02/15] fix: grid edit button style --- frappe/public/js/frappe/form/grid_row.js | 11 +++++++---- frappe/public/scss/grid.scss | 14 +++++++++++++- 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/frappe/public/js/frappe/form/grid_row.js b/frappe/public/js/frappe/form/grid_row.js index d86f46cfca..e66f6a4fe1 100644 --- a/frappe/public/js/frappe/form/grid_row.js +++ b/frappe/public/js/frappe/form/grid_row.js @@ -226,10 +226,13 @@ export default class GridRow { if(this.doc && !this.grid.df.in_place_edit) { // remove row if(!this.open_form_button) { - this.open_form_button = $('\ - ') - .appendTo($('
').appendTo(this.row)) - .on('click', function() { me.toggle_view(); return false; }); + this.open_form_button = $(` +
+ ${frappe.utils.icon('edit', 'xs')} +
Edit
` + ) + .appendTo($('
').appendTo(this.row)) + .on('click', function() { me.toggle_view(); return false; }); if(this.is_too_small()) { // narrow diff --git a/frappe/public/scss/grid.scss b/frappe/public/scss/grid.scss index e0e1b2e0e5..bed967c7ad 100644 --- a/frappe/public/scss/grid.scss +++ b/frappe/public/scss/grid.scss @@ -1,3 +1,9 @@ +.form-grid { + // border: 1px solid var(--border-color); + // border-radius: var(--border-radius); + color: var(--text-color); +} + .form-grid.error { border-color: var(--red-500); } @@ -107,7 +113,13 @@ .grid-body { .btn-open-row { - padding-top: 5px; + display: flex; + padding-top: var(--padding-sm); + justify-content: center; + div { + margin-left: var(--margin-xs); + line-height: 1.7em; + } } .editable-row { From 0b26abe4e2fa140d7c2cb887fef6e9a00bcfefe8 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 13:47:55 +0530 Subject: [PATCH 03/15] fix: input xs for multiselect field --- frappe/public/js/frappe/form/controls/multiselect_list.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/multiselect_list.js b/frappe/public/js/frappe/form/controls/multiselect_list.js index b8c652d841..4e851b384a 100644 --- a/frappe/public/js/frappe/form/controls/multiselect_list.js +++ b/frappe/public/js/frappe/form/controls/multiselect_list.js @@ -2,7 +2,7 @@ frappe.ui.form.ControlMultiSelectList = frappe.ui.form.ControlData.extend({ make_input() { let template = `
-
+
    From a111303ca1a9079af281db81ff6d365087a4adaa Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 13:49:58 +0530 Subject: [PATCH 04/15] fix: secondary btn hover style --- frappe/public/scss/global.scss | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/frappe/public/scss/global.scss b/frappe/public/scss/global.scss index a9a5395a75..78af5904f1 100644 --- a/frappe/public/scss/global.scss +++ b/frappe/public/scss/global.scss @@ -130,16 +130,22 @@ img { } } -.btn-secondary, .btn-default { +.btn-secondary { background-color: var(--control-bg); color: var(--text-color); &:hover, &:active { - background: var(--gray-200); + background: var(--gray-300); + color: var(--text-color); } } .btn-default { background-color: var(--fg-color); + color: var(--text-color); + &:hover, &:active { + background: var(--gray-200); + color: var(--text-color); + } } .btn-primary { From 746b444a0ba5808240f3d0b531a578694e26623f Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 14:10:38 +0530 Subject: [PATCH 05/15] fix: query report style --- .../js/frappe/views/reports/query_report.js | 26 +++++++++---------- frappe/public/scss/report.scss | 8 ++++++ 2 files changed, 21 insertions(+), 13 deletions(-) diff --git a/frappe/public/js/frappe/views/reports/query_report.js b/frappe/public/js/frappe/views/reports/query_report.js index 3db6302188..fafa3ae3ad 100644 --- a/frappe/public/js/frappe/views/reports/query_report.js +++ b/frappe/public/js/frappe/views/reports/query_report.js @@ -152,13 +152,13 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList { this.create_chart_button && this.create_chart_button.remove() this.create_chart_button = this.page.add_button(__("Set Chart"), () => { this.open_create_chart_dialog(); - }); + }, null, 'btn-xs'); if (this.chart_fields || this.chart_options) { this.add_to_dashboard_button && this.add_to_dashboard_button.remove() this.add_to_dashboard_button = this.page.add_button(__("Add Chart to Dashboard"), () => { this.add_chart_to_dashboard(); - }); + }, null, 'btn-xs'); } } else { this.create_chart_button && this.create_chart_button.remove() @@ -1578,26 +1578,26 @@ frappe.views.QueryReport = class QueryReport extends frappe.views.BaseList { } show_footer_message() { - const message = __('For comparison, use >5, <10 or =324. For ranges, use 5:10 (for values between 5 & 10).'); - const execution_time_msg = __('Execution Time: {0} sec', [this.execution_time || 0.1]); - - this.page.footer.removeClass('hide').addClass('text-muted col-md-12').html(` - ${message}${execution_time_msg} - `); - - this.page.wrapper.find('.tree-footer').remove(); + this.$report_footer && this.$report_footer.remove(); + this.$report_footer = $(`
    `).appendTo(this.page.main); if (this.tree_report) { - this.$tree_footer = this.page.footer.clone().addClass('tree-footer'); - this.$tree_footer.html(`
    + this.$tree_footer = $(`
    `); - this.page.footer.before(this.$tree_footer); + $(this.$report_footer).append(this.$tree_footer); this.$tree_footer.find('[data-action=collapse_all_rows]').show(); this.$tree_footer.find('[data-action=expand_all_rows]').hide(); } + + const message = __('For comparison, use >5, <10 or =324. For ranges, use 5:10 (for values between 5 & 10).'); + const execution_time_msg = __('Execution Time: {0} sec', [this.execution_time || 0.1]); + + this.$report_footer.append(`
    + ${message}${execution_time_msg} +
    `); } expand_all_rows() { diff --git a/frappe/public/scss/report.scss b/frappe/public/scss/report.scss index e160dc01e3..c5ae018468 100644 --- a/frappe/public/scss/report.scss +++ b/frappe/public/scss/report.scss @@ -224,6 +224,14 @@ } } +.report-footer { + padding: var(--padding-sm) 0; +} + +.tree-footer { + margin-bottom: var(--margin-sm); +} + // for sm and above @include media-breakpoint-up(xs) { .group-by-box .row > div[class*="col-sm-"] { From 3b66c1c73625a0c80f5c7e3740436df42e08ff79 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 14:11:48 +0530 Subject: [PATCH 06/15] fix: form message style --- frappe/public/scss/form.scss | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/frappe/public/scss/form.scss b/frappe/public/scss/form.scss index b7b4f701c6..b34843ce1c 100644 --- a/frappe/public/scss/form.scss +++ b/frappe/public/scss/form.scss @@ -215,3 +215,7 @@ } } } + +.form-message { + padding: var(--padding-md) var(--padding-xl); +} From ad8c0a5347d737cc07823c6cdd4c8ad0b142ca8b Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 14:27:20 +0530 Subject: [PATCH 07/15] fix: keyboard shortcut style --- frappe/public/js/frappe/ui/page.js | 11 ++++++----- frappe/public/scss/global.scss | 9 +++++++++ frappe/public/scss/page.scss | 12 ------------ 3 files changed, 15 insertions(+), 17 deletions(-) diff --git a/frappe/public/js/frappe/ui/page.js b/frappe/public/js/frappe/ui/page.js index 6682efd6e4..41503f3b01 100644 --- a/frappe/public/js/frappe/ui/page.js +++ b/frappe/public/js/frappe/ui/page.js @@ -332,9 +332,9 @@ frappe.ui.Page = Class.extend({ let shortcut_obj = this.prepare_shortcut_obj(shortcut, click, label); $li = $(`
  • ${label} -
    + ${shortcut_obj.shortcut_label} -
    +
  • `); frappe.ui.keys.add_shortcut(shortcut_obj); } else { @@ -588,9 +588,10 @@ frappe.ui.Page = Class.extend({ // }, - add_button: function(label, click, button_class) { - if (!button_class) button_class = "btn-secondary btn-default"; - let button = $(``); + add_button: function(label, click, button_class, button_size) { + if (!button_class) button_class = "btn-default"; + if (!button_size) button_size = "btn-sm"; + let button = $(``); button.appendTo(this.custom_actions); button.on('click', click); this.custom_actions.removeClass('hide'); diff --git a/frappe/public/scss/global.scss b/frappe/public/scss/global.scss index 78af5904f1..6669535c17 100644 --- a/frappe/public/scss/global.scss +++ b/frappe/public/scss/global.scss @@ -317,4 +317,13 @@ input[type="checkbox"] { font-size: var(--text-lg); font-weight: 500; color: var(--heading-color); +} + +kbd { + background-color: var(--gray-500); + font-family: Inter; + color: var(--fg-color); + line-height: 1.2em; + height: 20px; + padding: 4px 8px; } \ No newline at end of file diff --git a/frappe/public/scss/page.scss b/frappe/public/scss/page.scss index 86b768f4d8..4276925851 100644 --- a/frappe/public/scss/page.scss +++ b/frappe/public/scss/page.scss @@ -57,18 +57,6 @@ } } -.menu-shorcut { - padding: 0 8px; - height: 20px; - background: var(--gray-600); - border-radius: 4px; - - span { - color: $white; - line-height: 20px; - } -} - .page-form { margin: 0; padding: var(--padding-sm); From ad6586432cf1489881d2396588b6bab4ff20fddc Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 15:48:24 +0530 Subject: [PATCH 08/15] fix: update icons --- frappe/public/icons/timeless/symbol-defs.svg | 55 ++++++++++---------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/frappe/public/icons/timeless/symbol-defs.svg b/frappe/public/icons/timeless/symbol-defs.svg index 23de8fff53..2dab2e4ce9 100644 --- a/frappe/public/icons/timeless/symbol-defs.svg +++ b/frappe/public/icons/timeless/symbol-defs.svg @@ -16,11 +16,8 @@ - - - - - + + @@ -217,12 +214,13 @@ - - + + + fill="#ACB5BD" stroke-width="0"> - - + + + + + + @@ -459,6 +461,9 @@ + + + - - - - - - - - - - - - - @@ -534,10 +526,6 @@ stroke="none"> - @@ -580,6 +568,19 @@ + + + + + + + + + + + + + From 33d4cd7901a5c249a0e370a19e7280490ef99bd6 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 15:49:25 +0530 Subject: [PATCH 09/15] fix: update grid and grid form style --- frappe/public/js/frappe/form/grid.js | 10 ++-- frappe/public/js/frappe/form/grid_row_form.js | 31 ++++++------- frappe/public/scss/grid.scss | 46 +++++++++++++++---- 3 files changed, 57 insertions(+), 30 deletions(-) diff --git a/frappe/public/js/frappe/form/grid.js b/frappe/public/js/frappe/form/grid.js index 401dac4a8a..4f42ed844b 100644 --- a/frappe/public/js/frappe/form/grid.js +++ b/frappe/public/js/frappe/form/grid.js @@ -75,22 +75,22 @@ export default class Grid { data-action="delete_all_rows"> ${__("Delete All")} - -
    • - -
    @@ -865,7 +865,7 @@ export default class Grid { // add / unhide a custom button var btn = this.custom_buttons[label]; if (!btn) { - btn = $('') + btn = $('') .css('margin-right', '4px') .prependTo(this.grid_buttons) .on('click', click); diff --git a/frappe/public/js/frappe/form/grid_row_form.js b/frappe/public/js/frappe/form/grid_row_form.js index f93640936f..c798f4e735 100644 --- a/frappe/public/js/frappe/form/grid_row_form.js +++ b/frappe/public/js/frappe/form/grid_row_form.js @@ -42,25 +42,25 @@ export default class GridRowForm {
    ${ __("Editing Row") } # - +
    + ${frappe.utils.icon('down')}
    - - - - -
    @@ -68,11 +68,10 @@ export default class GridRowForm {
    diff --git a/frappe/public/scss/grid.scss b/frappe/public/scss/grid.scss index bed967c7ad..c327c1a593 100644 --- a/frappe/public/scss/grid.scss +++ b/frappe/public/scss/grid.scss @@ -18,10 +18,6 @@ padding: 0px 15px; border-bottom: 1px solid var(--border-color); @include transition(.2s); - - .form-control { - background-color: transparent; - } } .grid-row:last-child { @@ -265,7 +261,36 @@ height: 0; opacity: 0; z-index: 1021; + border-radius: var(--border-radius-md); @include base-grid(); + + .btn { + box-shadow: none; + } + + .form-section { + padding: 15px; + + &:not(:first-child) { + border-top: 1px solid var(--border-color); + } + + .section-head { + padding: 0; + } + + .form-column:first-child { + padding-left: 0; + } + } + + .grid-delete-row { + padding: 4px 6px; + + .icon use { + stroke: var(--fg-color); + } + } } .recorder-form-in-grid { @@ -278,12 +303,13 @@ height: auto; overflow: visible; margin: 0px -15px; + padding: 10px 15px; } .grid-form-heading { padding: 10px 15px; font-size: 120%; - border-bottom: 1px solid var(--border-color); + // border-bottom: 1px solid var(--border-color); } .grid-form-body { @@ -305,8 +331,7 @@ padding: 10px 0px; background-color: #fff; - .btn-default { - background-color: var(--control-bg); + .btn { box-shadow: none; } } @@ -338,8 +363,11 @@ a.next-page { } .grid-footer-toolbar { - padding: 10px 15px; - border-top: 1px solid var(--border-color); + padding: 15px 10px 5px 10px; + // border-top: 1px solid var(--border-color); + span { + margin-right: var(--margin-xs); + } } .grid-overflow-no-ellipsis { From 0f7ab745256492748bb12da44984236bd99c634e Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 15:49:52 +0530 Subject: [PATCH 10/15] fix: btn-danger color --- frappe/public/scss/global.scss | 3 +++ 1 file changed, 3 insertions(+) diff --git a/frappe/public/scss/global.scss b/frappe/public/scss/global.scss index 39da4eafc4..f7dc4dbec9 100644 --- a/frappe/public/scss/global.scss +++ b/frappe/public/scss/global.scss @@ -152,6 +152,9 @@ img { background-color: var(--primary-color); } +.btn-danger { + background-color: var(--red-400); +} h1, h2, h3 { color: $text-color; From efde210dac2efbe08d6962cc594a355885671e39 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 16:30:18 +0530 Subject: [PATCH 11/15] fix: add padding to awesomplete dropdown --- frappe/public/scss/awesomebar.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/frappe/public/scss/awesomebar.scss b/frappe/public/scss/awesomebar.scss index 413c34a9c3..2a50b6ea8d 100644 --- a/frappe/public/scss/awesomebar.scss +++ b/frappe/public/scss/awesomebar.scss @@ -29,7 +29,7 @@ border: 1px solid var(--border-color); left: 0; margin: 0; - padding: 0; + padding: 4px; z-index: 1; top: calc(100% + var(--margin-xs)); @@ -38,6 +38,7 @@ font-size: 12px; padding: var(--padding-sm); color: var(--text-light); + border-radius: var(--border-radius-sm); } &> li .link-option { From b8499eee30c292c605c9630467c821e7091ca530 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 18:33:35 +0530 Subject: [PATCH 12/15] feat: update modal style --- frappe/public/js/frappe/dom.js | 4 +- frappe/public/less/desk.less | 78 +++++++++++++++++----------------- frappe/public/scss/form.scss | 8 ++++ frappe/public/scss/modal.scss | 53 +++++++++++++++++++++-- 4 files changed, 98 insertions(+), 45 deletions(-) diff --git a/frappe/public/js/frappe/dom.js b/frappe/public/js/frappe/dom.js index d5ab13c969..bb4c3e8d16 100644 --- a/frappe/public/js/frappe/dom.js +++ b/frappe/public/js/frappe/dom.js @@ -317,10 +317,10 @@ frappe.get_modal = function(title, content) {
    -

    ${title}

    +

    ${title}

    -
    +
    diff --git a/frappe/public/less/desk.less b/frappe/public/less/desk.less index 346c75eb58..9e5c8967a3 100644 --- a/frappe/public/less/desk.less +++ b/frappe/public/less/desk.less @@ -129,24 +129,24 @@ textarea.form-control { background-color: @light-bg; } -.modal-backdrop { - opacity: 0.5; - position: fixed; -} +// .modal-backdrop { +// opacity: 0.5; +// position: fixed; +// } -.modal-header { - padding: 10px 15px; -} +// .modal-header { +// padding: 10px 15px; +// } -.modal-title { - margin: auto 0px; -} +// .modal-title { +// margin: auto 0px; +// } -.modal-message { - margin: 30px 15px; - color: @text-muted; - text-align: center; -} +// .modal-message { +// margin: 30px 15px; +// color: @text-muted; +// text-align: center; +// } .btn-primary.disabled { background-color: #b1bdca; @@ -697,9 +697,9 @@ li.user-progress { margin-left: -20px; } -.checkbox label { - padding-left: 2px; -} +// .checkbox label { +// padding-left: 2px; +// } .checkbox input[type=checkbox] { margin-right: 5px; @@ -964,7 +964,7 @@ img.img-loading:after { ul { margin: 0px; li { - padding: 10px; + // padding: 10px; cursor: pointer; &:hover { background: @btn-bg; @@ -1000,26 +1000,26 @@ body.no-sidebar { white-space: nowrap; } -.modal-minimize { - position: initial; - .modal-backdrop { - display: none; - } - .modal-dialog { - z-index: 101; - position: fixed; - right: 15px; - bottom: 0; - margin: 0; - max-width: 500px; - .modal-content { - min-height: 0; - } - } - .modal-body { - display: none; - } -} +// .modal-minimize { +// position: initial; +// .modal-backdrop { +// display: none; +// } +// .modal-dialog { +// z-index: 101; +// position: fixed; +// right: 15px; +// bottom: 0; +// margin: 0; +// max-width: 500px; +// .modal-content { +// min-height: 0; +// } +// } +// .modal-body { +// display: none; +// } +// } .app-logo { width: 24px; diff --git a/frappe/public/scss/form.scss b/frappe/public/scss/form.scss index b34843ce1c..e503bfd687 100644 --- a/frappe/public/scss/form.scss +++ b/frappe/public/scss/form.scss @@ -43,6 +43,14 @@ } } +.modal { + .form-section { + .form-column { + padding: 0; + } + } +} + .form-section.card-section { margin: var(--margin-lg) 0px; @extend .frappe-card; diff --git a/frappe/public/scss/modal.scss b/frappe/public/scss/modal.scss index 1b1e404e01..582d291f26 100644 --- a/frappe/public/scss/modal.scss +++ b/frappe/public/scss/modal.scss @@ -1,7 +1,52 @@ -h4.modal-title { - font-size: 1em; -} - h5.modal-title { margin: 0px !important; } + +.modal { + + .modal-header { + padding: var(--padding-md) 25px; + + .modal-title { + font-weight: 500; + line-height: 2em; + font-size: $font-size-lg; + } + } + + .modal-body { + padding: var(--padding-lg) 25px; + } + + .modal-footer { + padding: var(--padding-md); + } + + @include media-breakpoint-up(md) { + .modal-dialog { + width: 575px; + max-width: 575px; + } + } +} + +.modal-minimize { + position: initial; + + .modal-dialog { + z-index: 101; + position: fixed; + right: 15px; + bottom: 0; + margin: 0; + max-width: 575px; + + .modal-content { + min-height: 0; + } + } + + .modal-body { + display: none; + } +} From 25ab0411ff55a3c200d9c0f4d3a99751469146cb Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 18:33:58 +0530 Subject: [PATCH 13/15] fix: quick entry edit button --- frappe/public/js/frappe/form/quick_entry.js | 24 ++++++++++++--------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/frappe/public/js/frappe/form/quick_entry.js b/frappe/public/js/frappe/form/quick_entry.js index 2da7b8f236..02a786fe69 100644 --- a/frappe/public/js/frappe/form/quick_entry.js +++ b/frappe/public/js/frappe/form/quick_entry.js @@ -44,7 +44,7 @@ frappe.ui.form.QuickEntryForm = Class.extend({ }); }, - set_meta_and_mandatory_fields: function(){ + set_meta_and_mandatory_fields: function() { this.meta = frappe.get_meta(this.doctype); let fields = this.meta.fields; @@ -60,7 +60,7 @@ frappe.ui.form.QuickEntryForm = Class.extend({ } }, - is_quick_entry: function(){ + is_quick_entry: function() { if(this.meta.quick_entry != 1) { return false; } @@ -74,7 +74,7 @@ frappe.ui.form.QuickEntryForm = Class.extend({ return true; }, - too_many_mandatory_fields: function(){ + too_many_mandatory_fields: function() { if(this.mandatory.length > 7) { // too many fields, show form return true; @@ -91,14 +91,14 @@ frappe.ui.form.QuickEntryForm = Class.extend({ return false; }, - validate_for_prompt_autoname: function(){ + validate_for_prompt_autoname: function() { if(this.meta.autoname && this.meta.autoname.toLowerCase()==='prompt') { this.mandatory = [{fieldname:'__newname', label:__('{0} Name', [this.meta.name]), reqd: 1, fieldtype:'Data'}].concat(this.mandatory); } }, - render_dialog: function(){ + render_dialog: function() { var me = this; this.dialog = new frappe.ui.Dialog({ title: __("New {0}", [__(this.doctype)]), @@ -131,7 +131,7 @@ frappe.ui.form.QuickEntryForm = Class.extend({ } }, - register_primary_action: function(){ + register_primary_action: function() { var me = this; this.dialog.set_primary_action(__('Save'), function() { if(me.dialog.working) { @@ -259,10 +259,14 @@ frappe.ui.form.QuickEntryForm = Class.extend({ frappe.set_route('Form', this.doctype, this.doc.name); }, - render_edit_in_full_page_link: function(){ + render_edit_in_full_page_link: function() { var me = this; - var $link = $('
    ' + - '
    ').appendTo(this.dialog.body); + var $link = $(`
    + +
    `).appendTo(this.dialog.body); $link.find('.edit-full').on('click', function() { // edit in form @@ -270,7 +274,7 @@ frappe.ui.form.QuickEntryForm = Class.extend({ }); }, - set_defaults: function(){ + set_defaults: function() { var me = this; // set defaults $.each(this.dialog.fields_dict, function(fieldname, field) { From 5ba83e7046fcc28922b34870a30db13942b903c0 Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 18:35:50 +0530 Subject: [PATCH 14/15] fix: toggle modal backdrop while minimizing --- frappe/public/js/frappe/ui/dialog.js | 1 + 1 file changed, 1 insertion(+) diff --git a/frappe/public/js/frappe/ui/dialog.js b/frappe/public/js/frappe/ui/dialog.js index d77481f8b9..a431e51a2f 100644 --- a/frappe/public/js/frappe/ui/dialog.js +++ b/frappe/public/js/frappe/ui/dialog.js @@ -201,6 +201,7 @@ frappe.ui.Dialog = class Dialog extends frappe.ui.FieldGroup { this.get_close_btn().trigger("click"); } toggle_minimize() { + this.$wrapper.prev('.modal-backdrop').toggleClass('show').toggleClass('hide'); let modal = this.$wrapper.closest('.modal').toggleClass('modal-minimize'); modal.attr('tabindex') ? modal.removeAttr('tabindex') : modal.attr('tabindex', -1); this.get_minimize_btn().find('i').toggleClass('octicon-chevron-down').toggleClass('octicon-chevron-up'); From 57f11ae7f06e0e1d43d5e86cf8650d246557f96a Mon Sep 17 00:00:00 2001 From: prssanna Date: Tue, 18 Aug 2020 18:40:10 +0530 Subject: [PATCH 15/15] fix: spacing in modal buttons --- frappe/public/scss/modal.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/frappe/public/scss/modal.scss b/frappe/public/scss/modal.scss index 582d291f26..48acc0eebe 100644 --- a/frappe/public/scss/modal.scss +++ b/frappe/public/scss/modal.scss @@ -14,6 +14,12 @@ h5.modal-title { } } + .buttons { + button:not(:last-child) { + margin-right: 3px; + } + } + .modal-body { padding: var(--padding-lg) 25px; }