From fb438f342d59e40a9cc4b6240df2d4e4d4729210 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Tue, 13 Jun 2023 10:42:57 +0530 Subject: [PATCH] fix: clean `insert_after` setters when resetting layout (#21346) --- .../custom/doctype/customize_form/customize_form.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/frappe/custom/doctype/customize_form/customize_form.py b/frappe/custom/doctype/customize_form/customize_form.py index 8930833760..868a913ce3 100644 --- a/frappe/custom/doctype/customize_form/customize_form.py +++ b/frappe/custom/doctype/customize_form/customize_form.py @@ -573,18 +573,17 @@ class CustomizeForm(Document): if not self.doc_type: return - property_setter = frappe.db.get_value( + property_setters = frappe.get_all( "Property Setter", - filters={ - "doc_type": self.doc_type, - "property": "field_order", - }, + filters={"doc_type": self.doc_type, "property": ("in", ("field_order", "insert_after"))}, + pluck="name", ) - if not property_setter: + if not property_setters: return - frappe.delete_doc("Property Setter", property_setter) + frappe.db.delete("Property Setter", {"name": ("in", property_setters)}) + frappe.clear_cache(doctype=self.doc_type) self.fetch_to_customize() @classmethod