vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

perf: use cached doc for fetching role profiles

Browse source
This commit is contained in:
Ankush Menat 2024-02-09 19:50:24 +05:30
parent ff35e4b854
commit fbb4dd7e96
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
frappe/core/doctype/user/user.py
View file

@ -178,11 +178,11 @@ class User(Document):
self.set_social_login_userid("frappe", frappe.generate_hash(length=39))
def populate_role_profile_roles(self):
roles = []
roles = set()
if self.role_profiles:
for role_profile in self.role_profiles:
role_profile = frappe.get_doc("Role Profile", role_profile.role_profile)
roles.extend([role.role for role in role_profile.roles])
role_profile = frappe.get_cached_doc("Role Profile", role_profile.role_profile)
roles.update(role.role for role in role_profile.roles)
self.set("roles", [])
self.append_roles(*roles)
@ -612,7 +612,7 @@ class User(Document):
def append_roles(self, *roles):
"""Add roles to user"""
current_roles = [d.role for d in self.get("roles")]
current_roles = {d.role for d in self.get("roles")}
for role in roles:
if role in current_roles:
continue