From fbb89bdfe9f91e7628759b048cc159461eb3ae72 Mon Sep 17 00:00:00 2001 From: Ritwik Puri Date: Tue, 12 Jul 2022 18:58:07 +0530 Subject: [PATCH] fix: delete user mention cache when a user is disabled or enabled (#17451) User Mention cache is deleted on 3 occasions: * when a new user is inserted * when allowed_in_mention or user_type value has changed * when a user is deleted But we didn't delete it when a user was enabled or disabled as we maintain the mention cache for enabled users --- frappe/core/doctype/user/user.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/core/doctype/user/user.py b/frappe/core/doctype/user/user.py index bc5c20eb92..d6fe883fae 100644 --- a/frappe/core/doctype/user/user.py +++ b/frappe/core/doctype/user/user.py @@ -134,11 +134,11 @@ class User(Document): if self.time_zone: frappe.defaults.set_default("time_zone", self.time_zone, self.name) - if self.has_value_changed("allow_in_mentions") or self.has_value_changed("user_type"): - frappe.cache().delete_key("users_for_mentions") - if self.has_value_changed("enabled"): + frappe.cache().delete_key("users_for_mentions") frappe.cache().delete_key("enabled_users") + elif self.has_value_changed("allow_in_mentions") or self.has_value_changed("user_type"): + frappe.cache().delete_key("users_for_mentions") def has_website_permission(self, ptype, user, verbose=False): """Returns true if current user is the session user"""