vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: Correctly update form viewers

Browse source 
People who stopped viewing forms weren't removed, even though event was
sent.
This commit is contained in:
Ankush Menat 2023-06-29 13:12:36 +05:30
parent 3511f82dc2
commit fbcc594986
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
frappe/public/js/frappe/form/form_viewers.js
View file

@ -14,8 +14,7 @@ frappe.ui.form.FormViewers = class FormViewers {
this.parent.empty();
return;
}
let currently_viewing = this.active_users.filter((user) => user != frappe.session.user);
let avatar_group = frappe.avatar_group(currently_viewing, 5, {
let avatar_group = frappe.avatar_group(this.active_users, 5, {
align: "left",
overlap: true,
});
@ -31,9 +30,13 @@ frappe.ui.form.FormViewers = class FormViewers {
}
async update_users({ doctype, docname, users = [] }) {
// TODO: Do symmetric differenc here, user can be removed or added
const new_users = users.filter((user) => !this.past_users.includes(user));
if (new_users.length === 0) return;
users = users.filter((u) => u != frappe.session.user);
const added_users = users.filter((user) => !this.past_users.includes(user));
const removed_users = this.past_users.filter((user) => !users.includes(user));
const changed_users = [...added_users, ...removed_users];
if (changed_users.length === 0) return;
await this.fetch_user_info(users);