vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4

fix: prevent awesomebar from opening twice on desktop

Browse source 
When navigating from desktop -> list view -> back to desktop,
the setup_awesomebar() was called again via on_page_show,
creating multiple AwesomeBar instances with their own modals
and event listeners.

Added a guard to ensure setup_awesomebar() only runs once per
DesktopPage instance.

Fixes #34923
This commit is contained in:
Sagar Vora 2025-11-28 00:07:42 +05:30
parent c5aa1d9e01
commit fbf44bc584
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
frappe/desk/page/desktop/desktop.js
View file

@ -158,7 +158,7 @@ class DesktopPage {
this.setup_avatar();
this.setup_navbar();
this.setup_awesomebar();
this.handke_route_change();
this.handle_route_change();
}
setup_avatar() {
$(".desktop-avatar").html(frappe.avatar(frappe.session.user, "avatar-medium"));
@ -197,6 +197,9 @@ class DesktopPage {
}
setup_awesomebar() {
if (this.awesomebar_setup) return;
this.awesomebar_setup = true;
$(".desktop-search-wrapper #navbar-search").attr(
"placeholder",
`Search or type a command (${frappe.utils.is_mac() ? "⌘ + K" : "Ctrl + K"})`
@ -215,7 +218,7 @@ class DesktopPage {
description: __("Open Awesomebar"),
});
}
handke_route_change() {
handle_route_change() {
const me = this;
frappe.router.on("change", function () {
if (frappe.get_route()[0] == "desktop" || frappe.get_route()[0] == "")