From 74b2de7c09488753565a7acb784e33f19280d62b Mon Sep 17 00:00:00 2001 From: "stravo1@mac" Date: Tue, 24 Feb 2026 13:33:16 +0530 Subject: [PATCH 1/3] fix: skip get_number_format for ControlRating --- frappe/public/js/frappe/form/controls/float.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/frappe/public/js/frappe/form/controls/float.js b/frappe/public/js/frappe/form/controls/float.js index cbbd89144d..40483c6643 100644 --- a/frappe/public/js/frappe/form/controls/float.js +++ b/frappe/public/js/frappe/form/controls/float.js @@ -17,7 +17,7 @@ frappe.ui.form.ControlFloat = class ControlFloat extends frappe.ui.form.ControlI } get_number_format() { - if (this.df.fieldtype === "Float" && !this.df.options?.trim()) return; + if (this.df.fieldtype === "Rating" || (this.df.fieldtype === "Float" && !this.df.options?.trim())) return; const currency = frappe.meta.get_field_currency(this.df, this.get_doc()); return get_number_format(currency); From 3dd9f8f8ca0a9891990d538b85de9a978a1c60f1 Mon Sep 17 00:00:00 2001 From: "stravo1@mac" Date: Tue, 24 Feb 2026 13:42:04 +0530 Subject: [PATCH 2/3] fix: formatting for float.js --- frappe/public/js/frappe/form/controls/float.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/frappe/public/js/frappe/form/controls/float.js b/frappe/public/js/frappe/form/controls/float.js index 40483c6643..df9b25d904 100644 --- a/frappe/public/js/frappe/form/controls/float.js +++ b/frappe/public/js/frappe/form/controls/float.js @@ -17,10 +17,14 @@ frappe.ui.form.ControlFloat = class ControlFloat extends frappe.ui.form.ControlI } get_number_format() { - if (this.df.fieldtype === "Rating" || (this.df.fieldtype === "Float" && !this.df.options?.trim())) return; - - const currency = frappe.meta.get_field_currency(this.df, this.get_doc()); - return get_number_format(currency); + if ( + this.df.fieldtype === "Rating" || + (this.df.fieldtype === "Float" && !this.df.options?.trim()) + ) + return; + + const currency = frappe.meta.get_field_currency(this.df, this.get_doc()); + return get_number_format(currency); } get_precision() { From 203da2a839acaf4693e362922948c8ccb4c93954 Mon Sep 17 00:00:00 2001 From: sokumon Date: Tue, 24 Feb 2026 14:00:34 +0530 Subject: [PATCH 3/3] chore: run pre-commit --- frappe/public/js/frappe/form/controls/float.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/frappe/public/js/frappe/form/controls/float.js b/frappe/public/js/frappe/form/controls/float.js index df9b25d904..26f5b64ca2 100644 --- a/frappe/public/js/frappe/form/controls/float.js +++ b/frappe/public/js/frappe/form/controls/float.js @@ -22,9 +22,9 @@ frappe.ui.form.ControlFloat = class ControlFloat extends frappe.ui.form.ControlI (this.df.fieldtype === "Float" && !this.df.options?.trim()) ) return; - - const currency = frappe.meta.get_field_currency(this.df, this.get_doc()); - return get_number_format(currency); + + const currency = frappe.meta.get_field_currency(this.df, this.get_doc()); + return get_number_format(currency); } get_precision() {