From fcae6050f0cb2f91d3e74bfaea36fbc311fe73a6 Mon Sep 17 00:00:00 2001 From: David Arnold Date: Thu, 31 Oct 2024 21:35:28 +0100 Subject: [PATCH] Revert "refactor: place mappers into read-only mode" (#28347) This reverts commit 583e4bf3e7b4a1a9930707515b16dba704309c55. --- frappe/model/mapper.py | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/frappe/model/mapper.py b/frappe/model/mapper.py index 8aca4c4380..ea06f0065b 100644 --- a/frappe/model/mapper.py +++ b/frappe/model/mapper.py @@ -5,7 +5,6 @@ import json import frappe from frappe import _ from frappe.model import child_table_fields, default_fields, table_fields -from frappe.model.document import read_only_document from frappe.utils import cstr @@ -33,8 +32,7 @@ def make_mapped_doc(method, source_name, selected_children=None, args=None): frappe.flags.selected_children = selected_children or None - with read_only_document("doc-mapper"): - return method(source_name) + return method(source_name) @frappe.whitelist() @@ -51,8 +49,7 @@ def map_docs(method, source_names, target_doc, args=None): for src in json.loads(source_names): _args = (src, target_doc, json.loads(args)) if args else (src, target_doc) - with read_only_document("doc-mapper"): - target_doc = method(*_args) + target_doc = method(*_args) return target_doc @@ -103,8 +100,7 @@ def get_mapped_doc( ret_doc.run_method("before_mapping", source_doc, table_maps) - with read_only_document("doc-mapper"): - map_doc(source_doc, target_doc, table_maps[source_doc.doctype]) + map_doc(source_doc, target_doc, table_maps[source_doc.doctype]) row_exists_for_parentfield = {} @@ -163,12 +159,10 @@ def get_mapped_doc( if table_map.get("filter") and table_map.get("filter")(source_d): continue - with read_only_document("doc-mapper"): - map_child_doc(source_d, target_doc, table_map, source_doc) + map_child_doc(source_d, target_doc, table_map, source_doc) if postprocess: - with read_only_document("doc-mapper"): - postprocess(source_doc, target_doc) + postprocess(source_doc, target_doc) ret_doc.run_method("after_mapping", source_doc) ret_doc.set_onload("load_after_mapping", True)