From fe25fe1db12ca27fe1067ba5c76b4621d68b911e Mon Sep 17 00:00:00 2001
From: Suraj Shetty <surajshetty3416@gmail.com>
Date: Fri, 23 Jun 2023 09:45:25 +0530
Subject: [PATCH] feat: A flag (--save-metafiles) to save esbuild metafiles

- Useful for analysing bundle size
---
 esbuild/esbuild.js       | 12 ++++++++++++
 frappe/build.py          |  4 ++++
 frappe/commands/utils.py | 16 +++++++++++++++-
 3 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/esbuild/esbuild.js b/esbuild/esbuild.js
index e1594aa651..1476db3c20 100644
--- a/esbuild/esbuild.js
+++ b/esbuild/esbuild.js
@@ -60,6 +60,11 @@ const argv = yargs
 		type: "boolean",
 		description: "Run build command for apps",
 	})
+	.option("save-metafiles", {
+		type: "boolean",
+		description:
+			"Saves esbuild metafiles for built assets. Useful for analyzing bundle size. More info: https://esbuild.github.io/api/#metafile",
+	})
 	.example("node esbuild --apps frappe,erpnext", "Run build only for frappe and erpnext")
 	.example(
 		"node esbuild --files frappe/website.bundle.js,frappe/desk.bundle.js",
@@ -401,6 +406,13 @@ async function write_assets_json(metafile) {
 
 	await fs.promises.writeFile(assets_json_path, JSON.stringify(new_assets_json, null, 4));
 	await update_assets_json_in_cache();
+	if (argv["save-metafiles"]) {
+		// use current timestamp in readable formate as a suffix for filename
+		let current_timestamp = new Date().getTime();
+		const metafile_name = `meta-${current_timestamp}.json`;
+		await fs.promises.writeFile(`${metafile_name}`, JSON.stringify(metafile));
+		log(`Saved metafile as ${metafile_name}`);
+	}
 	return {
 		new_assets_json,
 		prev_assets_json,
diff --git a/frappe/build.py b/frappe/build.py
index e914d977fc..5a9855ef16 100644
--- a/frappe/build.py
+++ b/frappe/build.py
@@ -229,6 +229,7 @@ def bundle(
 	verbose=False,
 	skip_frappe=False,
 	files=None,
+	save_metafiles=False,
 ):
 	"""concat / minify js files"""
 	setup()
@@ -248,6 +249,9 @@ def bundle(
 
 	command += " --run-build-command"
 
+	if save_metafiles:
+		command += " --save-metafiles"
+
 	check_node_executable()
 	frappe_app_path = frappe.get_app_path("frappe", "..")
 	frappe.commands.popen(command, cwd=frappe_app_path, env=get_node_env(), raise_err=True)
diff --git a/frappe/commands/utils.py b/frappe/commands/utils.py
index 7e4b1e8e46..e77376b693 100644
--- a/frappe/commands/utils.py
+++ b/frappe/commands/utils.py
@@ -31,6 +31,12 @@ EXTRA_ARGS_CTX = {"ignore_unknown_options": True, "allow_extra_args": True}
 @click.option(
 	"--force", is_flag=True, default=False, help="Force build assets instead of downloading available"
 )
+@click.option(
+	"--save-metafiles",
+	is_flag=True,
+	default=False,
+	help="Saves esbuild metafiles for built assets. Useful for analyzing bundle size. More info: https://esbuild.github.io/api/#metafile",
+)
 def build(
 	app=None,
 	apps=None,
@@ -38,6 +44,7 @@ def build(
 	production=False,
 	verbose=False,
 	force=False,
+	save_metafiles=False,
 ):
 	"Compile JS and CSS source files"
 	from frappe.build import bundle, download_frappe_assets
@@ -62,7 +69,14 @@ def build(
 		if production:
 			mode = "production"
 
-		bundle(mode, apps=apps, hard_link=hard_link, verbose=verbose, skip_frappe=skip_frappe)
+		bundle(
+			mode,
+			apps=apps,
+			hard_link=hard_link,
+			verbose=verbose,
+			skip_frappe=skip_frappe,
+			save_metafiles=save_metafiles,
+		)
 
 
 @click.command("watch")