From fe3e5021a49efca8b79e1c5a1544aec07cac25e3 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 25 Feb 2025 12:14:52 +0530 Subject: [PATCH] perf: use client_cache for form meta --- frappe/cache_manager.py | 1 - frappe/desk/form/meta.py | 7 ++++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/frappe/cache_manager.py b/frappe/cache_manager.py index f11b07f600..b602b9e36c 100644 --- a/frappe/cache_manager.py +++ b/frappe/cache_manager.py @@ -66,7 +66,6 @@ user_cache_keys = ( ) doctype_cache_keys = ( - "doctype_form_meta", "last_modified", "linked_doctypes", "workflow", diff --git a/frappe/desk/form/meta.py b/frappe/desk/form/meta.py index 1efa747b92..a394f8fb5f 100644 --- a/frappe/desk/form/meta.py +++ b/frappe/desk/form/meta.py @@ -36,12 +36,13 @@ ASSET_KEYS = ( def get_meta(doctype, cached=True) -> "FormMeta": # don't cache for developer mode as js files, templates may be edited cached = cached and not frappe.conf.developer_mode + key = f"doctype_form_meta::{doctype}" if cached: - meta = frappe.cache.hget("doctype_form_meta", doctype) + meta = frappe.client_cache.get_value(key) if not meta: - # Cache miss - explicitly get meta from DB to avoid + # Cache miss - explicitly get meta from DB to avoid mismatches meta = FormMeta(doctype, cached=False) - frappe.cache.hset("doctype_form_meta", doctype, meta) + frappe.client_cache.set_value(key, meta) else: meta = FormMeta(doctype)