From fe79ab3ee7eab479e00f338ff24c4e46fc992b97 Mon Sep 17 00:00:00 2001
From: sokumon <sohamkulkarns9@gmail.com>
Date: Mon, 17 Nov 2025 12:19:34 +0530
Subject: [PATCH] fix: show icon if it is exists

---
 frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py | 2 +-
 frappe/public/js/frappe/ui/sidebar/sidebar_item.js         | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py b/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py
index a5f40d0f89..b05827f509 100644
--- a/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py
+++ b/frappe/desk/doctype/workspace_sidebar/workspace_sidebar.py
@@ -45,7 +45,7 @@ class WorkspaceSidebar(Document):
 		if not self.user.can_read:
 			self.user.build_permissions()
 
-	def on_update(self):
+	def before_save(self):
 		if frappe.conf.developer_mode:
 			if self.app:
 				self.export_sidebar()
diff --git a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
index a0ac132c9e..50e3010403 100644
--- a/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
+++ b/frappe/public/js/frappe/ui/sidebar/sidebar_item.js
@@ -56,7 +56,7 @@ frappe.ui.sidebar_item.TypeLink = class SidebarItem {
 	prepare() {}
 	make() {
 		this.path = this.get_path();
-		if (!(this.item.child && this.item.parent.indent)) {
+		if (!this.item.icon && !(this.item.child && this.item.parent.indent)) {
 			this.item.icon = "list-alt";
 		}
 		this.wrapper = $(