vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: validate fetch from (#25116)

Browse source
This commit is contained in:
Ankush Menat 2024-02-27 23:38:49 +05:30 • committed by GitHub
parent c60edc9a77
commit fe9fbf82d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 42 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

43
frappe/core/doctype/doctype/doctype.py
View file

@ -355,6 +355,8 @@ class DocType(Document):
for df in new_fields_to_fetch:
if df.fieldname not in old_fields_to_fetch:
link_fieldname, source_fieldname = df.fetch_from.split(".", 1)
if not source_fieldname:
continue # Invalid expression
link_df = new_meta.get_field(link_fieldname)
if frappe.db.db_type == "postgres":
@ -1187,7 +1189,7 @@ def validate_fields_for_doctype(doctype):
# this is separate because it is also called via custom field
def validate_fields(meta):
def validate_fields(meta: Meta):
"""Validate doctype fields. Checks
1. There are no illegal characters in fieldnames
2. If fieldnames are unique.
@ -1594,6 +1596,44 @@ def validate_fields(meta):
if docfield.options and (int(docfield.options) > 10 or int(docfield.options) < 3):
frappe.throw(_("Options for Rating field can range from 3 to 10"))
def check_fetch_from(docfield):
fetch_from = docfield.fetch_from
fieldname = docfield.fieldname
if not fetch_from:
return
if "." not in fetch_from:
frappe.throw(
_("Fetch From syntax for field {0} is invalid. `.` dot missing: {1}").format(
frappe.bold(fieldname), frappe.bold(fetch_from)
)
)
link_fieldname, source_fieldname = docfield.fetch_from.split(".", 1)
if not link_fieldname or not source_fieldname:
frappe.throw(
_(
"Fetch From syntax for field {0} is invalid: {1}. Fetch From should be in form of 'link_fieldname.source_fieldname'"
).format(frappe.bold(fieldname), frappe.bold(fetch_from))
)
link_df = meta.get("fields", {"fieldname": link_fieldname, "fieldtype": "Link"})
if not link_df:
frappe.throw(
_("Fetch From for field {0} is invalid: {1}. Link field {2} not found.").format(
frappe.bold(fieldname), frappe.bold(fetch_from), frappe.bold(link_fieldname)
)
)
doctype = link_df[0].options
fetch_from_doctype = frappe.get_meta(doctype)
if not fetch_from_doctype.get_field(source_fieldname):
frappe.throw(
_("Fetch From for field {0} is invalid: {1} does not have a field {2}").format(
frappe.bold(fieldname), frappe.bold(doctype), frappe.bold(source_fieldname)
)
)
fields = meta.get("fields")
fieldname_list = [d.fieldname for d in fields]
@ -1629,6 +1669,7 @@ def validate_fields(meta):
check_child_table_option(d)
check_max_height(d)
check_no_of_ratings(d)
check_fetch_from(d)
if not frappe.flags.in_migrate:
check_fold(fields)