From ff0c820c9c7c1b9c3173b0c2ce8d1be8fe576b76 Mon Sep 17 00:00:00 2001 From: Sagar Vora Date: Sat, 5 Nov 2022 16:06:07 +0000 Subject: [PATCH] chore(socketio): remove duplicate event handler (#18770) --- socketio.js | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/socketio.js b/socketio.js index 711e0028cc..30e931d6bf 100644 --- a/socketio.js +++ b/socketio.js @@ -31,11 +31,6 @@ io.on("connection", function (socket) { socket.user = cookie.parse(socket.request.headers.cookie).user_id; - socket.on("task_subscribe", function (task_id) { - var room = get_task_room(socket, task_id); - socket.join(room); - }); - let retries = 0; let join_user_room = () => { request @@ -61,13 +56,13 @@ io.on("connection", function (socket) { join_user_room(); - socket.on("task_unsubscribe", function (task_id) { + socket.on("task_subscribe", function (task_id) { var room = get_task_room(socket, task_id); - socket.leave(room); + socket.join(room); }); socket.on("task_unsubscribe", function (task_id) { - var room = "task:" + task_id; + var room = get_task_room(socket, task_id); socket.leave(room); });