From 92a0ffb191355d68681a9794307fb77620ecec3a Mon Sep 17 00:00:00 2001 From: Priyansh Agrawal Date: Sun, 13 Oct 2024 17:46:11 +0000 Subject: [PATCH] refactor: Replace hard-coded pg default port with PostgresDatabase.default_port --- frappe/__init__.py | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/frappe/__init__.py b/frappe/__init__.py index e4f9eecf21..8851072799 100644 --- a/frappe/__init__.py +++ b/frappe/__init__.py @@ -419,12 +419,16 @@ def get_site_config(sites_path: str | None = None, site_path: str | None = None) # Generalized env variable overrides and defaults def db_default_ports(db_type): - from frappe.database.mariadb.database import MariaDBDatabase + if db_type == "mariadb": + from frappe.database.mariadb.database import MariaDBDatabase - return { - "mariadb": MariaDBDatabase.default_port, - "postgres": 5432, - }[db_type] + return MariaDBDatabase.default_port + elif db_type == "postgres": + from frappe.database.postgres.database import PostgresDatabase + + return PostgresDatabase.default_port + + raise ValueError(f"Unsupported db_type={db_type}") config["redis_queue"] = ( os.environ.get("FRAPPE_REDIS_QUEUE") or config.get("redis_queue") or "redis://127.0.0.1:11311"