vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix: allow any sequence container (#25664)

Browse source
This commit is contained in:
Ankush Menat 2024-03-27 12:01:15 +05:30 • committed by GitHub
parent 4ab6a34474
commit ff1f8ddbda
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
frappe/model/db_query.py
View file

@ -7,6 +7,7 @@ import datetime
import json
import re
from collections import Counter
from collections.abc import Sequence
import frappe
import frappe.defaults
@ -133,7 +134,7 @@ class DatabaseQuery:
limit_page_length = page_length
if limit:
limit_page_length = limit
if as_list and not isinstance(self.fields, (list | tuple)) and len(self.fields) > 1:
if as_list and not isinstance(self.fields, (Sequence | str)) and len(self.fields) > 1:
frappe.throw(_("Fields must be a list or tuple when as_list is enabled"))
self.filters = filters or []

5
frappe/tests/test_db_query.py
View file

@ -268,6 +268,11 @@ class TestDBQuery(FrappeTestCase):
result in DatabaseQuery("DocType").execute(filters={"name": ["not in", "DocType,DocField"]})
)
def test_string_as_field(self):
self.assertEqual(
frappe.get_all("DocType", as_list=True), frappe.get_all("DocType", fields="name", as_list=True)
)
def test_none_filter(self):
query = frappe.qb.get_query("DocType", fields="name", filters={"restrict_to_domain": None})
sql = str(query).replace("`", "").replace('"', "")