From ffa785bb479b1f84b8b4d5d4a43c18cbaabdf301 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Fri, 21 Aug 2020 15:14:59 +0530 Subject: [PATCH] fix(client.py): fix get_value for name --- frappe/client.py | 2 ++ frappe/tests/test_api.py | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/frappe/client.py b/frappe/client.py index a813e3ec55..6f19e78183 100644 --- a/frappe/client.py +++ b/frappe/client.py @@ -73,6 +73,8 @@ def get_value(doctype, fieldname, filters=None, as_dict=True, debug=False, paren frappe.throw(_("No permission for {0}").format(doctype), frappe.PermissionError) filters = get_safe_filters(filters) + if isinstance(filters, string_types): + filters = {"name": filters} try: fields = json.loads(fieldname) diff --git a/frappe/tests/test_api.py b/frappe/tests/test_api.py index 3e559ac0f3..3139237cc9 100644 --- a/frappe/tests/test_api.py +++ b/frappe/tests/test_api.py @@ -67,6 +67,10 @@ class TestAPI(unittest.TestCase): {"doctype": "Note", "public": True, "title": "get_value", "content": test_content}, ]) self.assertEqual(server.get_value("Note", "content", {"title": "get_value"}).get('content'), test_content) + name = server.get_value("Note", "name", {"title": "get_value"}).get('name') + + # test by name + self.assertEqual(server.get_value("Note", "content", name).get('content'), test_content) self.assertRaises(FrappeException, server.get_value, "Note", "(select (password) from(__Auth) order by name desc limit 1)", {"title": "get_value"})