From 7f5935d4057e4f3c3c06d3a17efa083639492d2b Mon Sep 17 00:00:00 2001 From: tridotstech Date: Sat, 13 Dec 2025 19:26:16 +0530 Subject: [PATCH 1/3] fix: restore custom_buttons tracking in add_custom_button Fixes #34920 --- frappe/public/js/frappe/form/form.js | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js index 249f957d94..d3f774c503 100644 --- a/frappe/public/js/frappe/form/form.js +++ b/frappe/public/js/frappe/form/form.js @@ -1209,9 +1209,9 @@ frappe.ui.form.Form = class FrappeForm { this.dashboard.clear_headline(); this.dashboard.set_headline_alert( __("This form has been modified after you have loaded it") + - '", + '", "alert-warning" ); } else { @@ -1246,7 +1246,7 @@ frappe.ui.form.Form = class FrappeForm { add_web_link(path, label) { label = __(label) || __("See on Website"); this.web_link = this.sidebar - .add_user_action(__(label), function () {}) + .add_user_action(__(label), function () { }) .attr("href", path || this.doc.route) .attr("target", "_blank"); } @@ -1480,7 +1480,13 @@ frappe.ui.form.Form = class FrappeForm { if (group && group.indexOf("fa fa-") !== -1) group = null; let btn = this.page.add_inner_button(label, fn, group); + if (btn) { + let menu_item_label = group ? `${group} > ${label}` : label; + let menu_item = this.page.add_menu_item(menu_item_label, fn, false); + menu_item.parent().addClass("hidden-xl"); + this.custom_buttons[label] = btn; + } return btn; } @@ -2238,8 +2244,8 @@ frappe.ui.form.Form = class FrappeForm {
${__( + this.doctype + )}&ref_docname=${encodeURIComponent(this.docname)}'>${__( "All Submissions" )} `; From e8ed57df18477857982df790db552e368b5d3d21 Mon Sep 17 00:00:00 2001 From: tridotstech Date: Mon, 15 Dec 2025 11:30:21 +0530 Subject: [PATCH 2/3] style: apply prettier formatting --- frappe/public/js/frappe/form/form.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js index d3f774c503..0c872db145 100644 --- a/frappe/public/js/frappe/form/form.js +++ b/frappe/public/js/frappe/form/form.js @@ -1209,9 +1209,9 @@ frappe.ui.form.Form = class FrappeForm { this.dashboard.clear_headline(); this.dashboard.set_headline_alert( __("This form has been modified after you have loaded it") + - '", + '", "alert-warning" ); } else { @@ -1246,7 +1246,7 @@ frappe.ui.form.Form = class FrappeForm { add_web_link(path, label) { label = __(label) || __("See on Website"); this.web_link = this.sidebar - .add_user_action(__(label), function () { }) + .add_user_action(__(label), function () {}) .attr("href", path || this.doc.route) .attr("target", "_blank"); } @@ -2244,8 +2244,8 @@ frappe.ui.form.Form = class FrappeForm {
${__( + this.doctype + )}&ref_docname=${encodeURIComponent(this.docname)}'>${__( "All Submissions" )} `; From 809e43aefdce9f53b094aec329ed1b60395f5793 Mon Sep 17 00:00:00 2001 From: Ejaaz Khan Date: Thu, 22 Jan 2026 13:08:54 +0530 Subject: [PATCH 3/3] fix: remove unwated code --- frappe/public/js/frappe/form/form.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/frappe/public/js/frappe/form/form.js b/frappe/public/js/frappe/form/form.js index 0c872db145..b11d67f195 100644 --- a/frappe/public/js/frappe/form/form.js +++ b/frappe/public/js/frappe/form/form.js @@ -1481,10 +1481,6 @@ frappe.ui.form.Form = class FrappeForm { let btn = this.page.add_inner_button(label, fn, group); if (btn) { - let menu_item_label = group ? `${group} > ${label}` : label; - let menu_item = this.page.add_menu_item(menu_item_label, fn, false); - menu_item.parent().addClass("hidden-xl"); - this.custom_buttons[label] = btn; } return btn;