Commit graph

80 commits

Author SHA1 Message Date
Ankush Menat
af4ce8156d
fix: remove mutable defaults (#14597)
* fix: mutable defaults

* fix: missing defaults
2021-10-28 09:36:31 +00:00
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
SDLyu
cd4ae61220 Fix bug dict has no attribute of fieldname 2020-06-06 09:42:17 +08:00
prssanna
dae9eb5a2a fix: don't get filters if string type 2020-05-14 19:32:01 +05:30
Suraj Shetty
c3519b5a12
fix: Do not check for module for custom doctypes (#10081) 2020-04-24 10:31:08 +05:30
Suraj Shetty
e3dfbf4562 fix: Get guest's config if session.user is None 2019-12-23 07:49:16 +05:30
Suraj Shetty
6b91ed22e4 fix: Remove unwanted print statement 2019-12-23 07:48:15 +05:30
Suraj Shetty
da09ef5fe5 fix: Return empty dict if session is not created 2019-12-23 07:48:15 +05:30
Rushabh Mehta
0c77540ed4 fix(ux): added dropdown in print layout to avoid linebreak and fix for login 2019-11-07 15:07:56 +05:30
Rushabh Mehta
8d4610504a fix(notifications): login, logout notifications 2019-11-07 12:14:09 +05:30
Aditya Hase
2fd835803a
perf(notifications): Let database do the counting 2019-10-23 23:00:03 +05:30
Faris Ansari
4e8b9d1e21 fix: pass method without calling 2019-10-21 13:25:13 +05:30
Faris Ansari
3ceb0ea4d7 fix: cleanup 2019-10-21 13:15:55 +05:30
prssanna
75b624e7a2 fix: move notifications to desk, refactor notifications.js 2019-10-09 16:23:26 +05:30
prssanna
4833c04609 fix: email notifications sent only if notifications enabled and remove unused imports 2019-10-09 16:22:57 +05:30
prssanna
fc38664fe7 fix: formatting 2019-10-09 16:22:57 +05:30
prssanna
730d9d91cf fix: remove unused imports 2019-10-09 16:22:57 +05:30
prssanna
f44cec60b4 fix: remove unused notifications code from toolbar.js 2019-10-09 16:22:57 +05:30
prssanna
2073fd1f91 fix: remove notifications code 2019-10-09 16:22:57 +05:30
prssanna
bae5049683 feat(Notifications): Add integrated notifications 2019-10-09 16:22:57 +05:30
Himanshu Warekar
a5e327216a fix: could not find row fix 2019-09-07 11:32:00 +05:30
Sagar Vora
17b20b22a3 Merge branch 'master' into develop 2019-02-12 16:31:54 +05:30
Faris Ansari
850e9e6d0b fix: Skip get_open_count during migrate or install 2019-02-11 18:41:11 +05:30
Sagar Vora
ef82f39f99 Merge branch 'staging' into develop 2019-01-29 18:24:11 +05:30
Chinmay Pai
3250553738 fix(notifications): ignore mysql internal error 1684 for concurrent ddl statements (#6826)
apparently this occurs when get_notifcations is called, and at the same time, a table is being modified. to fix this, we just skip the table that is currently being modified.

Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
2019-01-25 11:19:17 +05:30
Saurabh
97152b5a1e fix: return empty dict if setup wizard is not completed (#6830) 2019-01-25 10:22:13 +05:30
Saurabh
14911900c8 fix: return empty dict if site is in installation state or setup wiz not completed 2019-01-24 19:56:03 +05:30
Faris Ansari
75f8847ad4
fix: Skip get_notifications before setup_complete (#6828) 2019-01-24 19:15:49 +05:30
Saurabh
2de5dfdbb3 Merge branch 'staging' into develop 2018-12-18 10:20:24 +05:30
Saurabh
52073a2b59 [minor][fix] get_notifications_for_doctypes (#6634) 2018-12-17 16:06:56 +05:30
Saurabh
b727233948 Merge branch 'staging' into develop 2018-12-13 10:37:25 +05:30
Prateeksha Singh
0ccb159c6f Add make_records() 2018-12-11 16:10:02 +05:30
Himanshu Mishra
e53c72a627 added @read_only to a few calls and converted a few read only calls to GET (#6299) 2018-10-30 11:13:25 +05:30
Zlash65
8d6aef871a minor fix 2018-07-27 13:06:42 +05:30
Zarrar
c0b7712b04 [Enhance] Add items to dashboard through client-side scripting (#5861)
* add items in dashboard as need be
- doctypes can be added throguh js side if needed

* refresh handles open count
2018-07-27 10:47:06 +05:30
Suraj Shetty
c71c132ba2 Workflow actions (#5598)
* Init workflow actions

- WIP code
- Add hooks to create and update
workflow action on document status changes.
- Tweak listview to show host document on list view item click
- Add new doctype "Pending Workflow Action"
- Add allow_self_approval check in Workflow master

* Rename doctypes

- Rename "Workflow Action" to "Workflow Action Master"
- Rename "Pending Workflow Action" to "Workflow Action"
- Remove irrelevant files

* Clear old workflow action on docstatus change

- Add check for user permission before creating a workflow action record
- Make doctype changes to support the Workflow Action  System

* Show host document only if workflow action status is open

* Send workflow action mail notifications

* Add patch to rename `tabWorkflow Action` to `tab Workflow Master`

- Rename table to retain data in `tabWorkflow Action` as it
will be overwritten with new structure on migration

* Enqueue email

* Remove unused files

* Add hook for custom has_permission

* Optimize send_workflow_action_email method

* Add permission_query_condition hook

* Show notification based on status

* Override get_form_link in list view

* Refactor workflow action

- Add action link
- update workflow action hooks

* Avoid repeated creation of Worklow Actions

- Update hooks entry to avoid unwanted method call

* Fix error with frappe.db.count usage

* Fix ui/ux for Workflow Action

- Fix action url and improve response on action button click
- Fix workflow action template style

* Fix Codacy

* Add self approval check

* Fix codacy

* Fix test

* Fix python version confilct and a permission error

* Fix incorrect 'this' reference

* Update with requested changes

* Add next action email template option

* Fix string formatting

* Refactor workflow Action

- Make process_workflow_action smaller

* Fix bugs and errors due to refactor

* Fix workflow field caching

* Add a workflow action test

* Fix bugs with email template
2018-05-30 11:24:49 +05:30
Achilles Rasquinha
0fc518ace4 python 3 fixes 2018-03-31 18:15:43 +05:30
Faris Ansari
6a73d4024e Notifications via socketio (#5295)
- Publish realtime message when notifications are cleared
- Refresh notifications on client on clear_notifications event
- refresh_notfications will be called only once in a 1 second window
- No more 30 sec polling
2018-03-29 10:52:04 +05:30
Achilles Rasquinha
473d3eb6be Fixes for Python 3 (#4940)
* Fixed dict_keys and lists

* [FIX] config.get keys must be list

* [FIX] pickle all objects

* [FIX] get versions in unicode

* [FIX] get log versions

* debugging

* Fixed commit ID reference

* Fixed branch reference

* Fixed doc keys to list

* [LOG] test log

* [LOG] test log

* Convert iterators to list

* removed logs

* [FIX] Trial to load templates

* Fixed codacy
2018-01-31 10:51:13 +05:30
tundebabzy
f5c66a0d38 cover NoneType use case (#4375) 2017-10-25 12:28:03 +05:30
Aditya Hase
b32ce23196 Convert dict.keys() to list explicitly 2017-09-04 16:05:57 +05:30
pratu16x7
81d2edf0df Mark as done and progress updates 2017-08-29 10:03:05 +05:30
pratu16x7
c17bf0a04d [slides] setup wizard refactor 2017-08-29 10:03:04 +05:30
pratu16x7
6527a17251 [user-progress] Slides as container object, dismiss button 2017-08-29 10:03:03 +05:30
pratu16x7
5f988c3d7b [user-progress] first cut 2017-08-29 10:03:03 +05:30
Prateeksha Singh
b602a07c7a Graphs, and target notifications (#3641)
* [sales goal] in company; graph, notifs

* cleanup notifications.js, summary and specific val in graph

* Add line graph, add goal data methods in goal.py

* [tests] targets in notification config

* [minor] type of graph as argument in parent

* Update graph docs

* remove company dependent test for notification

* [fix] test

* look for monthly history in cache

* check for cached graph data in field
2017-07-17 14:51:30 +05:30
tundebabzy
6fbe20caaa Except and raise statement python 3 compatible style (#3216)
* changes exception and raise statements to python 3 style

* changes except statement to python 3 style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* changes except and raise statement to python 3 compatible style

* adds six.reraise to fix python 3 style raise statements with traceback

* fixes indentation
2017-05-11 10:51:59 +05:30
Nabin Hait
d836d1367f Fixed merge conflict 2017-03-15 11:26:55 +05:30
Rushabh Mehta
95e6306cc0 [minor] fix for in_install 2017-03-09 18:18:13 +05:30