Commit graph

19 commits

Author SHA1 Message Date
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
Chinmay D. Pai
c8558e2b98
chore: simplify setting email status as open or closed
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2020-04-19 13:48:07 +05:30
P-Froggy
60a871e5d7 Don't hide meta column of inbox view on small displays 2020-04-07 02:50:22 +02:00
P-Froggy
fe36f44b9f Fix errors found by Codacy 2020-04-02 22:00:47 +02:00
P-Froggy
b151b77fa6 Fix translation, permission & UI bugs
Fix several untranslatable strings
Fix permission issue in communication when changing status
Fix functions in inbox view broken, like Tags View and Likes
Add ability to move emails to another email account
Add status = open in standard filters of communication
Add ability to sort after communication date in communication list
Add indicators for status closed and replied in inbox view
Add new role "Inbox User"
Reorder and regroup some custom buttons in communication form
Show more useful fields in email account list
2020-03-30 12:24:07 +02:00
rohitwaghchaure
0800b521ff fix: moved erpnext related methods from frappe to erpnext (#7332) 2019-04-22 15:56:30 +05:30
Rohit Waghchaure
3c01d85a3f fix: User not able to make lead from the communication 2019-04-18 13:20:12 +05:30
Anurag Mishra
fd260b64c7 fix: generating many opportunity on same lead on the base of communication 2019-04-10 11:49:56 +05:30
Aditya Hase
837bfc0995 fix(unicode): Import unicode_literals in every file (#6805)
* fix(unicode): Import unicode_literals in every file

* fix(unicode): Test if safe_json_loads return unicode instead of bytes
2019-01-25 11:56:27 +05:30
saurabh-bhosale
5307149a48 Part of telephony integration (#5308)
* Allow 'Add contact' button for phone communications

* Added telephony details section for Phone communication details

* Updated make_issue, make_lead methods to send phone numbers into respective doctypes

* Codacy fixes

* Removed redundancy

* Removed Call details section from Communication
2018-04-06 10:31:15 +05:30
Makarand Bauskar
47677c055c [minor] refactor mark as read and mark as unread (#4154)
* [minor] refresh inbox view on mark as read or mark as unread

* [minor] refactor mark as read and mark as unread

* [minor] don't update modified datetime while settings _seen
2017-09-21 12:32:20 +05:30
mbauskar
88f122f253 [minor] only enable_outgoing email account can send the email from communication 2017-03-29 18:40:58 +05:30
mbauskar
9bfc32cb7a [minor] fixes in email read / unread flags 2017-03-15 13:20:29 +05:30
mbauskar
79f37d9803 [enhance] mark email as spam, trash, add to contact 2017-03-14 17:55:07 +05:30
mbauskar
e541249b8a [minor] mark mail as read, unread added actions like reply, reply-all and forword 2017-03-08 14:42:04 +05:30
mbauskar
71393391b1 [minor] mark as read and unread option in communication 2017-03-08 14:41:43 +05:30
mbauskar
eda7b659a3 [WIP] Email Inbox view for Communication 2017-03-08 14:41:43 +05:30