Commit graph

110 commits

Author SHA1 Message Date
Ankush Menat
124407a70a fix: update EPS records when renaming doc 2021-11-30 11:16:46 +05:30
Aradhya-Tripathi
5e818198be refactor: converted queries in rename doc 2021-11-09 10:19:54 +05:30
Devin Slauenwhite
12e4b33a1f
fix: simplify merge condition statement
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-13 11:26:24 -04:00
Devin Slauenwhite
d61d4214cf Merge branch 'develop' into feat-bulk-rename-merge 2021-10-04 14:19:41 -04:00
Devin Slauenwhite
a8347c0b27 feat: allow bulk rename with merge 2021-10-04 14:15:54 -04:00
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
d8a4cf896b
perf: prefer set builder notation over constructor 2021-05-12 20:38:18 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
Suraj Shetty
c63e0b66cf
Merge branch 'develop' into rename-error 2021-01-13 19:26:23 +05:30
Prssanna Desai
51d8046da1
fix: use frappe.throw
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-01-04 15:30:28 +05:30
prssanna
5b8294f92b fix: throw error if name already exists 2020-12-24 15:22:09 +05:30
Gavin D'souza
1a5ed2a6fd Merge branch 'develop' of github.com:frappe/frappe into fix-broken-folders 2020-12-10 14:17:05 +05:30
Gavin D'souza
29941ef46a fix: Use ORM instead of raw SQL
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2020-11-30 12:03:53 +05:30
Gavin D'souza
a0cb593019 style: Sort and remove unused imports 2020-11-27 20:33:10 +05:30
Gavin D'souza
e3b09e2a2a fix: Add rename_doc utils for external API usages
* The previously deleted code was being used in ERPNext's Customer
module.
* This will be moved into frappe.model.utils.rename_doc for the time
and completely removed in time.
2020-11-27 20:19:50 +05:30
Gavin D'souza
861f41684c Merge branch 'develop' of github.com:frappe/frappe into fix-broken-folders 2020-11-27 16:23:59 +05:30
Gavin D'souza
104bc1b167 chore: Remove dead code 2020-11-27 15:09:23 +05:30
Gavin D'souza
58ed57e8f5 fix: Add postgreSQL support for rename_doc queries 2020-11-27 15:01:46 +05:30
marination
841f2f4a36 chore: Rename Doctype Test and more explicit comment
- Better decription of why the fix is done, what case it handles
- Test for Renaming Doctype and Record having same name as DocType
2020-11-03 21:57:26 +05:30
Gavin D'souza
c73e779373 fix: Validate existing doctype names too 2020-10-27 21:26:47 +05:30
marination
59d35cb5ae fix: Conditionally set parent field only on DocType rename 2020-10-20 20:21:07 +05:30
Suraj Shetty
9e43e88755 fix: Remove unnecessary whitelisting of rename_doc method 2020-09-08 10:38:26 +05:30
Suraj Shetty
a7aefdfb88
fix: Syntax error 2020-06-01 21:13:13 +05:30
prssanna
59eff3df40 Merge branch 'rename-doc-todo-fix' of https://github.com/prssanna/frappe into rename-doc-todo-fix 2020-06-01 12:21:09 +05:30
prssanna
f9b8637060 fix: remove unused import 2020-06-01 12:20:34 +05:30
Prssanna Desai
454a574d43
fix: use frappe.as_json
Co-authored-by: gavin <gavin18d@gmail.com>
2020-06-01 12:19:04 +05:30
prssanna
d6206ed411 fix: update assignemnts on merging docs 2020-05-29 16:50:31 +05:30
Suraj Shetty
2233235ec2
fix: duplicate entry error while renaming item (#9651)
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
2020-03-12 18:38:45 +05:30
Gavin D'souza
43ae8adeb4 feat: show_alert flag in rename_doc API 2019-12-30 12:52:35 +05:30
Gavin D'souza
5255513fff fix: merge documents without error 2019-10-27 18:52:37 +05:30
Himanshu Warekar
604b659353 fix: check for old and new names 2019-10-23 22:26:45 +05:30
Himanshu Warekar
31cef1ac5b fix: arguments not passed 2019-10-23 22:26:32 +05:30
Faris Ansari
83225791d8 fix: cleanup 2019-10-21 16:15:39 +05:30
Gavin D'souza
12d1d5a649 fix: shifted tasks to server-side via frappe.call 2019-10-15 00:16:18 +05:30
Gavin D'souza
6c9adf95a3 fix: rename docname and title 2019-10-07 16:01:39 +05:30
Suraj Shetty
1bcdc0b7cb fix(report): Allow report export only if user has export permission on ref doctype (#7458)
* fix: Allow export only if user has export permission on reference doctype

* fix: Show only custom "no permission" error

* fix: while saving employee user getting user permissions error
2019-05-15 11:59:13 +05:30
Faris Ansari
3b86f16b73 New Control: Table MultiSelect (#6675)
* feat(control): Add Table MultiSelect control

* fix: Use btn-group instead of span

* fix: Remove functionality

* fix: Add 'Table MultiSelect' to Field doctypes

* fix: Replace usage of string 'Table' with array `table_fields`

* fix: Use internal array to store values instead of building from HTML elements

* fix(style): Add semicolon

* fix: Read only mode and click to navigate to form

* style: indent

* fix: fallback to empty array

* fix: Add formatters in js and py

* style: missing semicolon

* fix: Add docfield validation
2018-12-28 15:36:59 +05:30
Frappe Bot
0499b4a845 Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
Suraj Shetty
79ddfe6021
Merge branch 'staging-fixes' into staging-fixes 2018-11-26 18:12:34 +05:30
Ameya Shenoy
13524a1ad5
Merge branch 'staging' into develop 2018-11-23 08:14:29 +00:00
Ameya Shenoy
d1d0edc636
Merge branch 'master' into staging-fixes 2018-11-23 08:07:36 +00:00
rohitwaghchaure
df6687f9c0 fix: After rename, user still able to search document using old name (#6515) 2018-11-22 11:33:29 +05:30
Suraj Shetty
5df1a040ff Remove unwanted code 2018-11-01 21:18:14 +05:30
Suraj Shetty
e61c9ac40c Fix quote issues (#6143)
* Fix quotes issues

* Escape docname

* Avoid multiple escapes
2018-09-27 09:15:50 +05:30
Rushabh Mehta
2e6a202652 Postgres support for Frappe (#5919)
* [start] postgres

* [wip] started refactoring db_schema

* Add psycopg2 to requirements.txt

* Add support for Postgres SQL

- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP

* Remove quotes from sql to make it compatible with postgres as well

* Moved some code from db_schema to database.py

* Move code from db_schema to schema.py

Add other required refactoring

* Add schema chages

* Remove redundant code in file

* Add invalid column name exception class to exceptions.py

* Add back tick in query wherever needed and replace ifnull with coalesce

* Update get_column_description code in database.py file

* Remove a print statement

* Add keys to get on_duplicate query

* Add bactick wherever necessary

- Remove db_schema.py file

* Remove DATE_SUB as it is incompatible with postgres

- Fix prepare_filter_condition

* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors

* Add code to create key and unique index
- added mysql and posgres in their respective database.py

* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage

* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int

* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable

* Replace Database instance with get_db method

* Move db_manager to separate file

* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py

* Make fulltext search changes in global_search.py

* Add empty string check

* Add root_password to site config

* Create cli command for postgres console

* Move setup of help database to setup_db.py

* Add get_database_list method

* Fix exception handling
- Replace bad_field handler with missing_column handler

* Fix tests and sql queries

* Fix import error

* Fix typo db -> database

* Fix error with make_table in help.py

* Try test for postgres

* Remove pyhton 2.7 version to try postgres travis test

* Add test fixes

* Add db_type to the config of test_site_postgres

* Enable query debug to check the reason for travis fail

* Add backticks to check if the test passes

* Update travis.yml
- Add postgres addon

* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number

* Try adding db_type for global help to make travis work

* Add print statements to debug travis failure

* Enable transaction and remove debug flag

* Fix help table creation query (postgres)

* Fix import issue

* Add some checks to prevent errors
- Some doctypes used to get called even before they are created

* Try fixes

* Update travis config

* Fix create index for help table

* Remove unused code

* Fix queries and update travis config

* Fix ifnull replace logic (regex)

* Add query fixes and code cleanup

* Fix typo
- get_column_description -> get_table_columns_description

* Fix tests
- Replace double quotes in query with single quote

* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

* Add multisql api

* Add few multisql queries

* Remove print statements

* Remove get_fulltext_search_condition method and replace with multi query

* Remove text slicing in create user

* Set default for 'values' argument in multisql

* Fix incorrect queries and remove few debug flags
- Fix multisql bug

* Force delete user to fix test
- Fix Import error
- Fix incorrect query

* Fix query builder bug

* Fix bad query

* Fix query (minor)

* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query

* Extend database class from an object to support python 2

* Fix query
- Add quotes around value passed to the query for variable comparision

* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database

* Set site hostname to data migration connector (in test file)
- To connect the same site host

* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset

* Replace few sql queries with orm methods

* Fix codacy

* Fix 'Doctype Sessions not found' issue

* Fix bugs induced during codacy fixes

* Fix Notification Test

- Use ORM instead of raw sql

* Set Date fallback value to 0001-01-01

- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both

* Fix date filter method

* Replace double quotes with single quote for literal value

* Remove print statement

* Replace double quotes with single

* Fix tests

- Replace few raw sql with ORM

* Separate query for postgres

- update_fields_to_fetch_query

* Fix tests

- replace locate with strpos for postgres

* Fix tests

- Skip test for datediff
- convert bytes to str in escape method

* Remove TestBot

* Skip fieldname extraction

* Replace docshare raw sql with ORM

* Fix typo

* Fix ancestor query test

* Fix test data migration

* Remove hardcoded hostname

* Add default option and option list for db_type

* Remove frappe.async module

* Remove a debug flag from test

* Fix codacy

* fix import issue

* Convert classmethod to static method

* Convert few instance methods to static methods

* Remove some unused imports

* Fix codacy

- Add exception type
- Replace few instance methods with static methods
- Remove unsued import

* Fix codacy

* Remove unused code

* Remove some unused codes

- Convert some instance methods to static function

* Fix a issue with query modification

* Fix add_index query

* Fix query

* Fix update_auth patch

* Fix a issue with exception handling

* Add try catch to a reload_doc

* Add try-catch to file_manager_hook patch

* import update_gravatar to set_user_gravatar patch

* Undo all the wrong patch fixes

* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)

* Fix typo !

* Fix exception(is_missing_column) handling

* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file

* Fix codacy

* Replace a mariadb specific function in a query used in validate_series

* Remove a debug flag

* Revert changes (rename_parent_and_child)

* Fix validate_one_root method

* Fix date format issue

* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method

* Add bandit.yml

The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.

* Skip start_process_with_partial_path check

* Fix typo

* Add python 2.7 test

* Move python versions in travis.yml

* Add python versions to jobs

* Overwrite python version inheritance for postgres in travis.yml

* Add quotes around python version in .travis.yml

* Add quotes around the name of the job

* Try a travis fix

* Try .travis.yml fix

* Import missing subprocess

* Refactor travis.yml

* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type

* Make install.sh and run-tests.sh executable

* Add sudo required to travis.yml to allow sudo cmmands in shell files

* Load nvm

* Remove verbose flag from scripts

* Remove command-trace-print flag

* Change to build dir in before script

* Add absolute path for scripts

* Fix tests

* Fix typo

* Fix codacy
- fixes - "echo won't expand escape sequences." warning

* Append (_) underscore instead of 'd' for db_name

* Remove printf and use mysql execute flag
2018-09-21 10:20:48 +05:30
Suraj Shetty
6ff6a98f8c Return if no link fields found (#5764) 2018-07-02 21:49:07 +05:30
Suraj Shetty
8ef543fdcc Update doctype names in skip_for_doctype field on doctype rename (#5719) 2018-06-26 10:13:37 +05:30
Nabin Hait
003df19442 update cached link_fields as per new 2018-06-13 17:51:38 +05:30