Commit graph

35823 commits

Author SHA1 Message Date
Aradhya-Tripathi
f5a5f97593 refactor: converted quries in sessions.py 2021-10-14 14:32:55 +05:30
Your Name
2bebf4b2c0 refactor: convert core communication db.sql calls 2021-10-14 13:27:46 +05:30
Suraj Shetty
1eb772f555
Merge pull request #14449 from surajshetty3416/fix-print-format-default 2021-10-14 11:08:37 +05:30
Shariq Ansari
5186347219 revert: Reverting single vertical scrollbar fix 2021-10-14 11:08:21 +05:30
Suraj Shetty
22ffe27217 fix: Permission check for default print format 2021-10-14 11:00:46 +05:30
Suraj Shetty
6565966dde
Merge pull request #14448 from surajshetty3416/fix-reload-issue 2021-10-14 10:02:17 +05:30
Suraj Shetty
08e5aa6afe revert: Override app link click to avoid page reload
This PR reverts unnecessary change  made in https://github.com/frappe/frappe/pull/14394
2021-10-14 09:55:14 +05:30
Aradhya-Tripathi
d75aab4b3e fix: fixed erroneous query conversion 2021-10-14 03:28:53 +05:30
Aradhya-Tripathi
e01d97b8df refactor: replacing queries with frappe ORM 2021-10-14 01:16:46 +05:30
Aradhya-Tripathi
0d21c6e272 Merge branch 'develop' of https://github.com/Aradhya-Tripathi/frappe into query-conversion 2021-10-14 00:19:33 +05:30
Devin Slauenwhite
12e4b33a1f
fix: simplify merge condition statement
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-13 11:26:24 -04:00
codescientist703
68d4b1d23e chore: removed unused chat utils 2021-10-13 19:32:15 +05:30
Manuel
a66e505b46
Merge branch 'frappe:develop' into develop 2021-10-13 15:19:51 +02:00
Manuel
bc6882ea4b
Merge branch 'frappe:develop' into multiple_imap_folder 2021-10-13 15:19:43 +02:00
Hussain Nagaria
cb4b9868d3 chore: Try on FCloud button 2021-10-13 18:41:08 +05:30
Ankush Menat
a6bfbe4f1a
Merge pull request #14427 from ankush/app_uninstall_failure
fix: app uninstallation failure if module def link field isn't called "module"
2021-10-13 16:38:18 +05:30
Aradhya-Tripathi
e0a3e4efe3 refactor: converted queries in share & translate 2021-10-13 15:13:13 +05:30
Aradhya-Tripathi
a621c4178c fix: fixing erroneous query conversions 2021-10-13 14:28:13 +05:30
Aradhya-Tripathi
7315076038 refactor: converted queries 2021-10-13 14:06:34 +05:30
mtraeber
f608fbeddd feat: sync mutliple IMAP folders in Email Account
When working with IMAP accounts, frappe should allow the user
to choose multiple folders to look for new mails. This helps
users to separate their frappe-related email from other
conversations. Use cases range from sieve filters in the
mail server that stuff incoming mail in various mail folders
to people manually sorting their e-mail. In both cases, we
can have different import policies for different folders, and
we can avoid importing unrelated email.

Created a new child table `IMAP Folder` with following fields:
 - Folder Name (user-modifiable)
 - Append To (user-modifiable)
 - UIDVALIDITY (hidden)
 - UIDNEXT (hidden)

Doctype `Email Account` and `receive.py` code adjusted so that
emails with the changes are processed correctly and Frappe
only logs in to the imap server once per sync.

Created a patch that copies the data from the old fields into
the new child table with `INBOX` as default `folder_name`. This
keeps existing setups working without manual changes.

The original fields
 - uidvalidity
 - uidnext
 - append_to
are still available for the pop3 setups. In IMAP, these fields
are hidden user and not used.

Added a test case in `Email Account` that validates data to make
sure a IMAP folder is provided if the use_imap is true.

Also added some code formatting changes in email_account.js to get rid
of sider checks failures that block this change
2021-10-13 10:27:18 +02:00
Deepesh Garg
096700a77a fix: Loading state for query reports 2021-10-12 19:11:25 +05:30
Manuel
201e0e278c
Merge branch 'frappe:develop' into develop 2021-10-12 15:30:01 +02:00
gavin
8e7d83c88d
Merge pull request #14246 from saxenabhishek/aks-fix-migration
feat: Hash based comparison migration
2021-10-12 17:50:49 +05:30
Ankush Menat
35b242fe27
test: remove app unit tests 2021-10-12 17:33:29 +05:30
abhishek
ba78852c73 docs: add docstring for import_file_by_path 2021-10-12 17:15:12 +05:30
Ankush Menat
70fcac8acf
refactor: change _delete_modules for testability 2021-10-12 17:10:14 +05:30
Ankush Menat
aa372b0990
fix: change order of deletion
Previous order was:
1. Delete DocTypes
2. Delete linked records
3. Drop tables

Now if linked records belonged to deleted doctypes it causes
uninstallation failure.

Changed order to:

1. Delete linked records
2. Delete DocTypes
3. Drop tables
2021-10-12 16:52:18 +05:30
Ankush Menat
412aa9f5cc
fix: fieldname for linkfield hardcoded to "module"
Remove_app assumed that all link fileds linking to "Module Def" are
called "module", this causes uninstall failure and leaves bench in
pseudo-irrecoverable state. (requiring some manual cleanup)
2021-10-12 16:52:18 +05:30
Ankush Menat
ae88fca3ef
refactor: split remove_app in smaller functions 2021-10-12 16:52:17 +05:30
Suraj Shetty
05231f97f8
Merge pull request #14424 from frappe/fix-group-by-child-table-field 2021-10-12 14:20:36 +05:30
Suraj Shetty
18df0b0f8c test: Fix test 2021-10-12 13:46:06 +05:30
Suraj Shetty
74ec9657da test: Update aggregation test 2021-10-12 13:36:30 +05:30
Suraj Shetty
828d158e4d
Merge pull request #14380 from pateljannat/discussions-single-topic 2021-10-12 13:35:42 +05:30
codescientist703
d73209f8bf ci: Trigger actions 2021-10-12 13:02:26 +05:30
Mohammad Hasnain Mohsin Rajan
b3465f7972
Merge pull request #14429 from anupamvs/customize-print-format-btn-issue
fix: Customize is not listed in menu item [Print]
2021-10-12 13:01:00 +05:30
Anupam
f6e83dbcaf fix: Customize is not listed in menu item [Print] 2021-10-12 12:35:40 +05:30
Suraj Shetty
ab00980389
refactor: Use f-string
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-12 12:06:08 +05:30
Suraj Shetty
8febefae9c test: Add test case to validate aggregation
- based on child table field
2021-10-12 12:05:05 +05:30
Suraj Shetty
c6538cf318
Merge branch 'develop' into discussions-single-topic 2021-10-12 11:41:04 +05:30
Suraj Shetty
14ae20bdb8 fix: Push aggregate_on_field to field list
- for proper extraction of child table
2021-10-12 09:54:09 +05:30
abhishek
86f29aeaa3 fix: missing logical cases
- handle first time imports
- update hash and timestamps
2021-10-12 03:21:08 +05:30
barredterra
9ac748dc30 feat: allow tuple of doctypes as key 2021-10-11 19:45:06 +02:00
mergify[bot]
d7edd05a5d
Merge pull request #14309 from shariquerik/hide-show-filter
fix: Hide 'Show Saved' filter button if there is no saved filters
2021-10-11 14:30:45 +00:00
Mohammad Hasnain Mohsin Rajan
b7de4b3cae
Merge pull request #14355 from shariquerik/notification_overlap_filter
fix: Filter pop-up overlaps the Notification Window
2021-10-11 19:36:19 +05:30
Shariq Ansari
875f35ec14
fix: Rate limiter on blog feedback (#14322)
* fix: Added rate limiter on blog feedback

* test: Updated test to support rate limiter
2021-10-11 19:35:51 +05:30
mergify[bot]
20c38aa704
Merge pull request #14414 from mituldavid/comment-imgs
fix: Private images in comments are not visible
2021-10-11 13:43:36 +00:00
Gavin D'souza
2622f3398e style: Black-ish queries
* feat(minor): Added DocType to frappe.query_builder namespace
2021-10-11 19:00:52 +05:30
abhishek
f3d810414a refactor: sync_for() - first install module 2021-10-11 18:59:06 +05:30
abhishek
0be59cee80 chore: add missing document_types 2021-10-11 18:59:06 +05:30
abhishek
547111841a refactor: sql in update_modified() to frappe.qb 2021-10-11 18:58:15 +05:30