AarDG10
72ce53bb6a
fix(contact): ensure query is compatible with postgres
2026-01-20 12:06:00 +05:30
Sagar Vora
d4f1b51e98
revert: "fix: ignore unsupported filter when querying dynamic link doctypes"
...
This reverts commit bc590c0844
2026-01-16 21:53:41 +05:30
Sagar Vora
bc590c0844
fix: ignore unsupported filter when querying dynamic link doctypes
2026-01-16 16:33:01 +05:30
Raffael Meyer
0efdebb7d8
fix(Contact): don't go to last doc on validation errors ( #35165 )
2025-12-10 22:13:17 +01:00
Akhil Narang
977aee5ab3
refactor: backticks aren't allowed in order_by or group_by
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
barredterra
2834952fcb
fix: use link title as address title
2025-10-09 20:14:12 +02:00
El-Shafei H.
aaad14b698
fix: missing translation function ( #33938 )
2025-09-08 15:31:07 +05:30
mp-30
365fedc563
fix(address): correct phone validation in address.json for version-15
...
Phone number validation was not working as expected in version-15.
Updated regex pattern to align with the intended format.
Fixes #33520
2025-08-18 08:06:55 +00:00
Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases ( #32867 )
...
Next to zero adoption after introduction, just noise in codebase.
I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.
Dropped using semgrep
2025-06-10 05:28:53 +00:00
rohitwaghchaure
5c6b2b5bec
refactor: track completed app setup wizards and re-run the setup wizard upon new app installation. ( #32640 )
2025-06-03 12:36:22 +05:30
Raffael Meyer
9307ee8886
fix(Contact): export company name and department in vCard ( #29190 )
2025-01-15 14:16:03 +00:00
Sumit Bhanushali
0d278dbadf
fix: update address link title on update of customer
2024-12-30 14:20:48 +05:30
Ankush Menat
60bc472ab6
revert: restore JSON files ( #28717 )
...
* Revert: bring back JSON files
* chore: re-apply changes to new files
* chore: remove old TOML files
* chore: delete empty files
2024-12-09 08:41:56 +00:00
barredterra
daa6c617d4
fix: translatability of boldened text
2024-11-05 12:25:33 +05:30
Raffael Meyer
232f45cfd5
refactor(Contact): make get_contact_name more robust ( #28171 )
2024-10-18 19:08:53 +02:00
David Arnold
443c38daa9
refactor: toml test records for readability ( #28065 )
...
* refactor: toml test records for readability
* fix: maintain backwards compatibility
* refactor: transform in-tree records
* chore: don't use deprecated functions (treewide)
* chore: revert migration of tests which depend on old test records list
* feat: add cls.globalTestRecords on IntegrationTestCase
2024-10-10 13:24:02 +02:00
David Arnold
83bc1f09e9
refactor: clarify test record dep management in test modules ( #28060 )
2024-10-09 13:44:27 +00:00
David Arnold
c114e5fae8
refactor: unit vs integration treewide ( #27992 )
...
* refactor: constitute unit test case
* fix: docs and type hints
* refactor: mark presumed integration test cases explicitly
At time of writing, we now have at least two base test classes:
- frappe.tests.UnitTestCase
- frappe.tests.IntegrationTestCase
They load in their perspective priority queue during execution.
Probably more to come for more efficient queing and scheduling.
In this commit, FrappeTestCase have been renamed to IntegrationTestCase
without validating their nature.
* feat: Move test-related functions from test_runner.py to tests/utils.py
* refactor: add bare UnitTestCase to all doctype tests
This should teach LLMs in their next pass that the distinction matters
and that this is widely used framework practice
2024-10-06 09:43:36 +00:00
barredterra
5280cc58f4
refactor: address query
2024-07-24 10:30:35 +02:00
barredterra
c4e35ba5be
fix(Contact): set address query and buttons from links
2024-07-01 18:10:47 +02:00
gavin
9d73477e60
Merge pull request #26771 from barredterra/contact-vcard
...
feat: download Contact as vCard
2024-06-27 11:03:22 +02:00
barredterra
be29009e4a
refactor: only one access log for bulk contact export
2024-06-26 20:03:25 +02:00
barredterra
e61f1f99d6
fix: check permission and create access log
2024-06-18 12:47:51 +02:00
barredterra
9d19701e56
feat: download contact list as vCards
2024-06-16 18:19:48 +02:00
barredterra
b53203e14c
feat: download Contact as vCard
2024-06-16 17:49:16 +02:00
barredterra
be90d5556e
feat: set the only email address as primary
...
Some features rely on the Contact having the primary email set. If the Contact has only one email address, we can mark it as primary automatically. Only if there are more than one addresses available, the user has to choose which one should be set as primary.
2024-06-13 17:38:09 +02:00
Ankush Menat
b63295d25c
fix: contact link with autoincr ( #26642 )
2024-06-03 04:59:48 +00:00
Akhil Narang
1c6ba0cf82
fix(address_query): show search fields in description if set
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-31 11:36:10 +05:30
Akhil Narang
b0a7d62a9e
fix(address_query): use title field if set
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-27 13:56:12 +05:30
Ankush Menat
1defbf5be8
fix: Apply configured perms on address list ( #26334 )
2024-05-06 12:08:06 +00:00
Nabin Hait
6a6193a26b
fix: Column 'creation' in order clause was ambiguous
2024-04-04 13:02:08 +05:30
Ankush Menat
3896296c6f
fix: update sort order in doctypes
2024-03-27 11:18:28 +05:30
Corentin Flr
5563c925a5
feat(address): Add no_title param to get_condensed_address Jinja filter ( #24949 )
2024-02-23 05:46:14 +00:00
Akhil Narang
3f1e19de85
refactor(treewide): enable RUF rules
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-21 16:20:28 +05:30
barredterra
bbd42839e3
fix: invite contact as user
2024-02-16 20:43:37 +01:00
Akhil Narang
26ae0f3460
fix: ruff fixes
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748
style: re-format with ruff
2024-02-05 18:53:33 +05:30
Ankush Menat
7487df22c9
refactor: use frappe.get_system_settings
...
because it's cached and doesn't hit frappe.db at all.
2024-02-02 18:43:43 +05:30
David Arnold
608f2ed20b
test: make phone number unique bis ( #24367 )
2024-01-16 10:56:47 +05:30
David Arnold
62148f9ecd
test: make phone number unique
2024-01-14 16:51:14 +01:00
Hussain Nagaria
8d2137c265
docs: consistent doc strings
2023-12-18 18:27:39 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified ( #23697 )
...
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
8129fe7268
fix: Avoid duplicate contact names ( #23731 )
2023-12-11 17:15:37 +05:30
Ankush Menat
c6371cbdd0
fix: increase length for address lines
...
140 char default limit is often not enough as demonstrated here https://github.com/frappe/frappe/issues/23259
2023-11-20 17:29:00 +05:30
Sagar Vora
e8cbf61e6a
fix: revert unintentional quick entry default for Address ( #22974 )
2023-10-30 15:23:25 +05:30
Ankush Menat
8df5402b1f
refactor: change kwarg name
...
frappe.call is oversmart about this particular name
2023-10-17 22:06:56 +05:30
Ankush Menat
3e19fb36a7
refactor: Split address render function ( #22784 )
...
This function can be used as utility where permssion checks might not be
required.
2023-10-17 14:07:31 +00:00
Ankush Menat
bac5f76247
fix: Apply address all perm only if owner
2023-10-11 11:48:51 +05:30
rohitwaghchaure
34fe6661c0
fix: e-commerece test cases ( #22663 )
2023-10-09 11:49:41 +05:30
Deepesh Garg
99bec229fb
chore: remove unintentional json updated
2023-10-02 16:51:09 +05:30
