Commit graph

4862 commits

Author SHA1 Message Date
Ankush Menat
bbcc365a24
fix: use monotonic clock for timing code (#19138)
* fix: use monotonic time for timing code

`time.time()` depends on system clock which can drift away and get corrected
over time. If you're unlucky it will get corrected in your timing code
and give absurd results.

* test: dont check for status

can refresh and give wrong output

[skip ci]
2022-12-06 15:42:37 +05:30
Daizy Modi
d76b5fb719 fix: type conversion for read receipt in communication email 2022-12-06 08:25:11 +00:00
Sagar Vora
4ea39d1a68
chore!: drop device support from session (#18729)
* chore!: drop device support from session

* chore: remove `session_expiry_mobile` field

* fix: remove extra `%s`
2022-12-05 16:37:32 +05:30
Sagar Vora
2e2f8e8175
fix: only check for special characters in fieldname (#19061)
* fix: only check for special characters in fieldname

* chore: revert #18965
2022-11-30 16:03:02 +05:30
Nikhil
53957447b3
fix: check for bad zip files during unzipping in file doctype (#19058)
* check for bad zip files
2022-11-30 14:34:09 +05:30
Shariq Ansari
a6d715b943
Merge branch 'develop' into patch-1 2022-11-29 15:12:19 +05:30
phot0n
8c28a233e2 fix: check read permission when downloading prepared report file 2022-11-29 14:43:27 +05:30
phot0n
5444df7036 chore: use default timeout 25 mins for prepared report 2022-11-29 13:46:11 +05:30
phot0n
f88d76f011 chore: convert job_id to link fieldtype in prepared report doctype 2022-11-29 13:46:11 +05:30
phot0n
1a5019432d refactor(minor): disable_prepared_report -> enable_prepared_report
for role permission for page and report
2022-11-29 13:46:11 +05:30
phot0n
c8ea0a72d0 fix: render filters on refresh
onload hook gave inconsistent behaviour
2022-11-29 13:46:11 +05:30
phot0n
246caea70e test: prepared report tests
* fix: update job_id for prepared report
2022-11-29 13:46:11 +05:30
phot0n
0d275b68f2 fix: get_prepared_data - add with_file_name param for returning filename of the attachment 2022-11-29 13:46:11 +05:30
phot0n
eea2fd9782 fix: dont show filters when not present in prepared report 2022-11-29 13:46:11 +05:30
phot0n
917dfdae78 refactor(minor): use virtual docfield for report_start_time - and renamed it to queued_at
* chore: rename Report End Time label to Finished At
2022-11-29 13:46:11 +05:30
phot0n
08bae70908 perf: use modified for fetching old logs for clearing 2022-11-29 13:46:11 +05:30
phot0n
433615beed chore: add queued_by virual docfield in prepared report 2022-11-29 13:46:11 +05:30
phot0n
18d48ddeb8 refactor: cleanup peprared result render and old logs cleanup
* directly fetch columns from result file rather than storing it in db
* remove prepared report settings from system settings
* remove disable_prepared_report from report doctype
2022-11-29 13:46:11 +05:30
phot0n
6218a99301 refactor(minor): dry-er code in generate_report 2022-11-29 13:46:11 +05:30
phot0n
cd468c3229 fix(ux): don't show report_name field on prepared report doc 2022-11-29 13:46:11 +05:30
phot0n
ecbafb5a23 feat(minor): add job_id column to prepared report
* chore: make report_name mandatory
2022-11-29 13:46:11 +05:30
phot0n
4fe8eadf5e refactor: remove unnecessary fields from prepared report
* removed ref_report_doctype
* changed title_field from ref_report_doctype to report_name (both are same)
* changed report_name field to link type
* changed autonaming to hash based
* added status in list view via document states
2022-11-29 13:46:11 +05:30
phot0n
9bfc43c148 fix: use after_insert hook for enqueuing report generation
this removes the need of additionally calling enqueue_report method

* enqueue report in long queue
* reduce the timeout from 100 mins to 30 mins
2022-11-29 13:46:11 +05:30
Ankush Menat
7a3faf23e1
Merge pull request #18664 from barredterra/csv-params
feat: configurable CSV delimiter and quoting
2022-11-29 13:27:24 +05:30
Ankush Menat
c89cdb4f0c test: handle multi-queue consumers 2022-11-29 11:30:12 +05:30
Shariq Ansari
bb9d0e0f61 refactor: refactored file.js 2022-11-28 16:37:26 +05:30
Sabu Siyad
406f894141
feat: default value options: sort (#19019)
[skip ci]

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-11-28 11:09:15 +05:30
Raffael Meyer
83e2f524e2
Merge branch 'develop' into csv-params 2022-11-26 20:10:51 +01:00
barredterra
433b285b92 refactor: use provide_binary_file 2022-11-26 20:08:50 +01:00
Ankush Menat
ed28626021 refactor: simpler deque strat selection
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 12:14:37 +05:30
Ankush Menat
aece93fbc5 feat: burst mode in workers
https://python-rq.org/docs/workers/#burst-mode
2022-11-25 12:14:33 +05:30
Ankush Menat
0ebd3945ff refactor: consider multi-queue consumption 2022-11-25 12:03:34 +05:30
Abdo Hamoud
752fdc9eaf
Merge branch 'develop' into patch-1 2022-11-23 02:25:46 +02:00
Shariq Ansari
64d39ee18a fix: dont show link for fields without label 2022-11-18 15:04:53 +05:30
Shariq Ansari
eb5f50e36a
Merge branch 'develop' into field-help-link 2022-11-17 18:06:01 +05:30
Shariq Ansari
e78c74cbc1 feat: inline doc link for each field 2022-11-17 16:19:35 +05:30
gavin
dbed3e4788
Merge branch 'develop' into socket_io-refactor 2022-11-17 15:21:20 +05:30
Faris Ansari
edf01ee1cd
fix(file): attached_to_name can be an integer (#18909)
* fix(file): attached_to_name can be an integer

incorrect validation introduces via
https://github.com/frappe/frappe/pull/18880

* test(file): set correct fieldname

* fix: check for str, int explicitly
2022-11-17 14:43:03 +05:30
Gavin D'souza
c3c1848b2a fix: Restrict socket data to respective users after commit
Fix conditions to bother only those who asked for the data:
- Clear permissions cache only for updated users' data
- Defer appropriate events until commit to avoid ghost events
- Remove event unused by desk (and other apps)
2022-11-16 23:07:07 +05:30
Abdo Hamoud
e5ad087521
Update File Types Preview
- Update preview types [PDF], [MP4], [Mp3]
2022-11-15 16:59:08 +02:00
gavin
24f4b85031
Merge branch 'develop' into socket_io-refactor 2022-11-15 19:19:29 +05:30
Sagar Vora
425e4bf1b3
fix(File): validate attached_to_* when saving (#18880) 2022-11-15 16:19:02 +05:30
Gavin D'souza
97d2eab3e2 refactor(socketio): docinfo_update
- Rename event from `update_docinfo_for_{}_{}` to docinfo_update
- Separate rooms for separate documents generated on requirement
- Check if user has access to doc before sharing docinfo
2022-11-15 13:15:34 +05:30
Ankush Menat
990a96e48b
feat: show utilization percent on RQ Worker (#18868)
[skip ci]
2022-11-14 15:55:20 +05:30
Ritwik Puri
feb9190cac
fix: check if the doctype exists before adding default logtypes in log settings (#18867) 2022-11-14 15:54:41 +05:30
Ritwik Puri
0cd3d97132
Merge pull request #18856 from resilient-tech/better-templates
chore: fully commented, consistently formatted JS boilerplates
2022-11-12 20:41:23 +05:30
Aradhya
3759e5bbcd refactor: lint
fix: removed time.sleep
2022-11-12 20:06:17 +05:30
Aradhya
7c8af96046 refactor: leaving job status as it is on completion 2022-11-12 20:06:17 +05:30
Aradhya
1145bab9d8 refactor: checking docstatus before asserting failure 2022-11-12 20:06:17 +05:30
phot0n
b09eb2f317 fix: use index for ref_docname in submission queue doctype 2022-11-12 20:06:17 +05:30