Commit graph

2214 commits

Author SHA1 Message Date
Sagar Vora
9a3819e608
fix: disable signups by default (#19114)
* fix: disable signups by default

* fix: set `disable_signup` to `0` for tests
2022-12-05 16:40:51 +05:30
phot0n
d7f4540132 chore: consider docname via data 2022-12-05 12:19:29 +05:30
phot0n
8e0c4ce702 fix: use webform doctype rather than allowing user to pass any doctype 2022-12-05 11:56:12 +05:30
phot0n
856d7a9f65 fix: use permtype from passed arguments in has_web_form_permission when applying document permissions 2022-12-02 20:52:00 +05:30
Shariq Ansari
941949e0a1
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:57 +05:30
mergify[bot]
d1d30e6451
Merge pull request #18877 from marination/get_role_permissions-js-consistency
fix: Correctness in `get_role_permissions` and `has_perm` JS APIs
2022-11-21 12:56:30 +00:00
Shariq Ansari
58a35d12bf
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:11 +05:30
Shariq Ansari
cf4d55855d fix: added phone field in webform 2022-11-21 18:16:44 +05:30
Shariq Ansari
962d96c1a6 fix: only get fields which is not already in webform fields table 2022-11-21 17:33:39 +05:30
marination
0937c962a7 chore: web_form.py format via pre-commit 2022-11-21 16:18:58 +05:30
Shariq Ansari
c56c71b1e0
Merge pull request #18945 from theopen-institute/oi-webform-error 2022-11-21 15:25:58 +05:30
PeterG
4ec7d2dbba
feat(minor): redirect after login from NotPermittedPage (#18946)
* redirect after login from NotPermittedPage
2022-11-21 14:56:18 +05:30
PeterG
cfa9ed4fa0
Update frappe/website/doctype/web_form/web_form.py
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 15:06:17 +05:45
PeterG
264c9dfad0
Update frappe/website/doctype/web_form/web_form.py
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-21 15:06:06 +05:45
PeterG
4ffd454c04
[fix] clearer webform error 2022-11-20 16:07:07 +05:45
PeterG
7bde45ae60 [fix] clearer webform error 2022-11-20 10:13:34 +00:00
Gavin D'souza
40df601a73 fix: Auto-add all users to website room
Keep website room open for all - currently only used for discussions
2022-11-17 17:04:07 +05:30
gavin
dbed3e4788
Merge branch 'develop' into socket_io-refactor 2022-11-17 15:21:20 +05:30
Jannat Patel
6428930857
fix: security issue in discussions component (#18903)
[skip ci]
2022-11-17 11:39:43 +05:30
Gavin D'souza
96fee8c293 feat: {site}:website room open to all users
- Subscribe to room and pass messages without auth
- Pass `room='website'` to publish_realtime to use
- Pass discussions' comms through particular site's website room
2022-11-16 21:53:49 +05:30
Ankush Menat
f34f7030a3 refactor: remove txt param from generate_hash use 2022-11-10 11:56:48 +05:30
Ankush Menat
8cca50bf26
refactor: remove naming case feature (#18672)
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
  naming because `name_case` is selected in some doctypes (but never
  tested)
2022-10-31 11:23:49 +05:30
Faris Ansari
5c2b917f52
refactor(minor): Tab layout in Website Theme form (#18570) 2022-10-26 00:15:47 +05:30
Ankush Menat
3491d0dcb0
refactor: dynamically load web form module (#18486) 2022-10-23 11:20:17 +05:30
Rushabh Mehta
83c310b779
Merge pull request #18452 from rmehta/blog-category-fix
fix(ux): add better home for blog category, cleanup forms
2022-10-18 21:50:22 +05:30
Rushabh Mehta
2a50d6c593 fix(ux): add better home for blog category, cleanup forms 2022-10-18 17:28:47 +05:30
Ankush Menat
c2f43c4b26
fix: validate website settings (#18446) 2022-10-18 12:41:36 +05:30
Ankush Menat
cc72dc47ab
fix: Show error page even when routing fails (#18437) 2022-10-17 19:52:37 +05:30
Rushabh Mehta
ac263d02ae fix(minor): skip broken redirect 2022-10-17 18:54:41 +05:30
Shariq Ansari
0736f8a01b fix: load all boot data on website 2022-10-07 23:28:36 +05:30
Shariq Ansari
799cc62515 fix: get assets_json from boot 2022-10-05 16:34:02 +05:30
Shariq Ansari
2a8b837127 fix: removed unused script 2022-10-04 11:07:55 +05:30
Shariq Ansari
2b549619a8 fix: handle loading of bundle css & js in website 2022-10-03 13:54:48 +05:30
Shariq Ansari
ede9188aa6 fix: removed Vue.prototype implementation 2022-09-29 19:20:32 +05:30
Ankush Menat
3a5a45d8af perf: drop many unused indexes
- reference owner - only used for activity page which is unusable
  *anyway*
- same for timeline and link doctypes

perf: drop unused index from Commment

Can't find a single  query that uses this index

perf: drop pointless "Is home folder" index

just why? It's checkbox index with 1 entry which has unique name already

Most pointless index I've seen no far.

perf: Drop "attached to doctype" separate index

There is already a composite index for this.

perf: drop indexes from web page view log

BOTH are totally unused in any of the queries related to this doctype.

Only "website analytics" report uses this which doesn't even show this
data lmao.

perf: drop unused index from EPS log

We never filter by doctype or type. pointless indexing.

perf: fix up notification log indexes

- drop unused index
- add "for user" index
2022-09-14 14:28:47 +05:30
Ankush Menat
06d888126b fix(UX): show read only mode warning on web pages 2022-09-09 17:34:46 +05:30
Ankush Menat
55617b9e86 fix: defer logging during read only mode
Deferred:
- Error log
- view log
- web page view

Disable:
- "_seen" tracking used on list view to highlight unseen docs.
- "seen" on error log.
- dashboard chart last ts caching
2022-09-09 17:34:46 +05:30
Ankush Menat
e8af6b2c16 feat: make attachments public on doctypes
When this checkbox is checked, while uploading docs using fileuploader
the default visibility will be set to "public".

At present all uploaded attachments are private, however in following
cases it makes sense to set default as public:

1. Blog post
2. Item catalog
3. Website item

Considering this we decided to add this configurtion so developers can
specify sane default while user still has control over it using
"Customize form"

Enabled this for "blog post" doctype

Unrelatd change: consistent "form settings" section on DocType and customize
form
2022-08-26 12:42:26 +05:30
Ankush Menat
7e34da6bec build(deps): bump werkzeug
Werkzeug has faster router now
2022-08-26 10:23:09 +05:30
Ankush Menat
2623b7e63c test: top bar for website 2022-08-24 11:03:53 +05:30
Faris Ansari
9358655ae2
fix: 'TopBarItem' object does not support item assignment #17926
TypeError: 'TopBarItem' object does not support item assignment
2022-08-24 10:39:20 +05:30
Shariq Ansari
d17fd03958 chore: moved include script from html to web_form.bundle.js 2022-08-23 17:00:27 +05:30
Shariq Ansari
78ab3d8429 chore: removed unused code 2022-08-23 16:39:14 +05:30
Shariq Ansari
5ca89e0dad revert: use meta fields in standard webforms 2022-08-23 16:33:14 +05:30
Suraj Shetty
3d84a748b7
Merge pull request #17863 from shariquerik/web-form-misc-fixes 2022-08-23 09:54:23 +05:30
Shariq Ansari
2b57e77f29 feat: added not saved indicator if form is dirty 2022-08-22 19:40:51 +05:30
Shariq Ansari
fb8ba3d881 fix: include Color field in Web Form fieldtypes 2022-08-22 18:21:48 +05:30
Shariq Ansari
4b4d66d2a3 fix: title should never be empty 2022-08-22 16:47:15 +05:30
Shariq Ansari
309b42f1a3 fix: show webform name and webform doc name on header 2022-08-22 15:57:46 +05:30
Shariq Ansari
66389932d1 fix: show introduction in edit mode 2022-08-22 13:19:03 +05:30