Gavin D'souza
6f2125fca6
Merge branch 'develop' of github.com:frappe/frappe into owner-unchange
2022-01-04 15:06:37 +05:30
shadrak gurupnor
6c6ff2c16d
fix: overriding of owner of doc
...
feat: Fixed the dilemma of owner field in ToDo document
2022-01-04 13:39:16 +05:30
Gavin D'souza
322a777b59
fix(ux): Auto Repeat's validation message has grammatical fixes
2022-01-03 19:10:28 +05:30
Gavin D'souza
f7b5982919
test(assign_rule): Setup and teardown for local testing
2022-01-03 19:09:42 +05:30
Gavin D'souza
3a38456583
refactor(minor): Assignment Rule
...
* Simplified and refactored logic
* Added type hints for where it gets really unbearable :')
* Minor perf improvements & better API usages
2022-01-03 19:05:58 +05:30
Gavin D'souza
e3fc400fd4
refactor(minor): Override clear_cache instead of separate hooks
...
Clear cached maps via Document.clear_cache
2022-01-03 19:01:01 +05:30
Shariq Ansari
5d00602f06
fix: Removing unused code for worspace
2021-09-20 21:27:14 +05:30
Gavin D'souza
3446026555
chore: Update header: license.txt => LICENSE
...
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
ebc220db39
refactor(tests): frappe.db.delete > frappe.db.sql
...
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql ;)
This commit focuses on the tests written under the doctype specific
tests
2021-08-19 19:50:48 +05:30
Samuel Danieli
1e38d5a281
fix: broken link
2021-08-16 18:55:09 +02:00
shariquerik
5bed8031a2
fix: removed padding code from wspace json files & patch
2021-08-10 17:52:42 +05:30
Shariq Ansari
1ab70d2145
Merge branch 'frappe:develop' into wiki-based-desk
2021-08-10 12:20:08 +05:30
shariquerik
bf4611e84b
fix: updated wspace json files & minor onboarding fix
2021-08-06 14:07:22 +05:30
Ankush
257723cb0a
feat: PythonExpression and Python option with syntax validation for Code field types ( #13707 )
...
* feat: `PythonExpression` and `Python` options for `Code` fields
* fix: check python expressions in assignment rule
* fix: replace server script syntax validation
* fix: validate condition in workflow transition
Add PythonExpression in Options.
2021-08-06 04:10:09 +00:00
shariquerik
8475c6c426
fix: updated wspace json files
2021-07-08 17:41:22 +05:30
shariquerik
f2a91f5709
fix: updated wspace json files
2021-07-08 15:37:01 +05:30
Gavin D'souza
c489846547
Merge branch 'develop' into unnecessary_comprehensions
2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506
chore: Drop dead and deprecated code
...
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
d8a4cf896b
perf: prefer set builder notation over constructor
2021-05-12 20:38:18 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
...
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
mergify[bot]
1c0233ccd8
Merge pull request #12993 from nextchamp-saqib/auto-repeat-dashboard-fix
...
fix: auto repeat schedule not rendered in the dashboard
2021-05-08 19:19:17 +00:00
Ankush Menat
a077466b1e
chore: replace assertEquals with alias assertEqual
...
`assertEquals` has been deprecated, while not fully removed it will
still keep giving warnings in tests / CI.
ref: https://docs.python.org/3/library/unittest.html#deprecated-aliases
2021-05-06 21:16:22 +05:30
Frappe Bot
d30596b15e
refactor: Delete Qunit test files
...
Since it is no longer used
2021-04-27 21:37:15 +05:30
Saqib Ansari
6cdf514fcb
fix: auto repeat schedule not rendered in the dashboard
2021-04-26 14:30:17 +05:30
Rucha Mahabal
b3066f3702
test: docshare with submit permission
2021-04-04 17:07:52 +05:30
Sagar Vora
497ea861f4
feat: frappe.whitelist for class methods
2021-03-30 13:07:58 +05:30
mergify[bot]
cbbddafc0f
Merge pull request #12268 from hasnain2808/no-assignment-rule-on-todo
...
fix: Do not Allow Assignment Rule on Todo
2021-02-24 11:24:12 +00:00
hasnain2808@gmail.com
fb40a48338
chore: better error message
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-02-24 15:12:26 +05:30
hasnain2808@gmail.com
83a8c8f7b5
chore(Assignment Rule): fix translation
2021-02-04 10:38:01 +05:30
barredterra
3ad56b2d5f
fix: fetch contacts in auto repeat
2021-02-03 15:46:00 +01:00
hasnain2808@gmail.com
0d265bca05
fix: Do not Allow Assignment Rule on Todo
2021-01-27 10:50:49 +05:30
Suraj Shetty
b94d5778a8
Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui
2021-01-19 10:36:50 +05:30
Rucha Mahabal
0964f07ee4
fix: Auto Repeat JSON file not updated
2021-01-12 09:25:52 +05:30
Rushabh Mehta
c93368b242
fix(minor): merge develop
2021-01-08 14:35:55 +05:30
Anupam
282030be5f
fix: auto-repeat issue
2020-12-31 19:43:03 +05:30
Rushabh Mehta
54cee87826
fix(minor): tests + routing
2020-12-24 14:48:40 +05:30
Shivam Mishra
8b77346066
Merge branch 'rebrand-ui' of https://github.com/frappe/frappe into desk-enhancements
2020-12-16 13:18:48 +05:30
Rucha Mahabal
7d70e552aa
chore: added a docstring for the get_next_schedule_date method
2020-12-16 12:09:10 +05:30
Rucha Mahabal
4c1756b3d6
fix: code clean-up and fallbacks for get method
2020-12-16 11:29:05 +05:30
Suraj Shetty
25dc9ee222
Merge branch 'develop' of https://github.com/frappe/frappe into rebrand-ui
2020-12-11 13:02:36 +05:30
Rucha Mahabal
6398ca7db7
refactor: move common functions as methods to the Auto Repeat class
2020-12-11 12:11:07 +05:30
Rucha Mahabal
6350291dc2
Merge branch 'develop' into auto_repeat_weekdays
2020-12-11 11:39:42 +05:30
Rucha Mahabal
ec0d1dd63f
fix: added server side validation for submit on creation
2020-12-10 17:18:13 +05:30
Rucha Mahabal
30fbf37f25
test: submit on creation
2020-12-10 11:48:12 +05:30
Rucha Mahabal
c805851ebe
feat(Auto Repeat): Submit on Creation configuration
2020-12-10 10:52:50 +05:30
Shivam Mishra
bd7690a9fa
feat: rename desk page to workspace
2020-12-04 14:16:26 +05:30
Shivam Mishra
1cb80bbf78
feat: update desk pages json
2020-12-04 14:16:26 +05:30
Shivam Mishra
8c9cb9cccd
chore: add dependencies
2020-12-04 14:16:26 +05:30
Shivam Mishra
303995d0de
refactor: update desk page json
2020-12-04 14:16:26 +05:30
Shivam Mishra
de12cb845a
fix: link type
2020-12-04 14:16:26 +05:30