Commit graph

4158 commits

Author SHA1 Message Date
Gavin D'souza
5de0b5cd35 style: remove commented code, whitespaces test_file, added typing hint 2022-01-10 13:23:49 +05:30
Suraj Shetty
1d11ff0375
Merge branch 'develop' into fix-datetime-filter 2022-01-06 11:06:02 +05:30
mergify[bot]
77fd08985a
Merge pull request #15533 from nextchamp-saqib/fix-frt-test
fix: set `first_response_time` only if communication is sent
2022-01-05 11:11:16 +00:00
Suraj Shetty
5d5ad78789 refactor: Rename week_starts_on to first_day_of_the_week
For consistency
2022-01-05 14:54:46 +05:30
Saqib Ansari
ae5644c3e1 fix: set first_response_time only if communication is sent 2022-01-05 14:23:44 +05:30
Ankush Menat
80d456ef7e fix: avoid cached results for table_exists during install 2022-01-05 11:54:46 +05:30
mergify[bot]
22adb529d9
Merge pull request #15495 from ankush/postgres_rollbacks
fix(postgres)!: transactions implementation for PostgreSQL
2022-01-04 11:56:11 +00:00
Suraj Shetty
65a28002c2
Merge branch 'develop' into fix-datetime-filter 2022-01-04 15:19:56 +05:30
Suraj Shetty
53b2c472a6 fix: Re-setup moment object whenever week_starts_on is changed 2022-01-04 14:14:06 +05:30
Ankush Menat
da9d07474a test: rollback tests that are aborting transactions 2022-01-04 13:59:22 +05:30
Ankush Menat
5ac79925ef fix: postgres install that doesn't abort transactions 2022-01-04 13:59:17 +05:30
shadrak gurupnor
a4aad4dc7a fix: failed test cases & sider issue 2022-01-04 13:39:42 +05:30
shadrak gurupnor
6c6ff2c16d fix: overriding of owner of doc
feat: Fixed the dilemma of owner field in ToDo document
2022-01-04 13:39:16 +05:30
Suraj Shetty
42e1c15c18 feat: Add setting to configure the day on which week starts 2022-01-04 13:00:31 +05:30
Suraj Shetty
c0963b9d27
Merge pull request #15498 from surajshetty3416/fix-user-form-ux 2022-01-03 20:22:47 +05:30
Rushabh Mehta
b1ae0da9df
Merge pull request #15503 from rmehta/tab-show-dashboard
fix(ux): add "Show Dashboard" check for tab breaks
2022-01-03 15:08:31 +05:30
Rushabh Mehta
66a8e125d4 fix(ux): add "Show Dashboard" check for tab breaks 2022-01-03 13:57:36 +05:30
Suraj Shetty
54242a3911
Merge pull request #15497 from surajshetty3416/fix-user-permission-ux 2022-01-03 12:26:19 +05:30
Suraj Shetty
0868ad02f8 refactor: Re-arrange user form
- To fix order of fields in quick entry form
2022-01-03 11:59:11 +05:30
Suraj Shetty
b2d16e7db8 refactor: Re-arraange fields in user permission to avoid confusion 2022-01-03 11:31:06 +05:30
Suraj Shetty
b77d08d26a fix: Check if value for applicable_for exists before setting it null
To avoid "Not Saved" state even after saving the document
2022-01-03 11:30:03 +05:30
Rushabh Mehta
2a8f07d6fb fix(minor): List data types alphabetically in DocType 2022-01-02 18:53:15 +05:30
hrwx
f0a9d50671 fix: unhide context field 2021-12-31 14:51:18 +05:30
mergify[bot]
1b28c3b4ed
Merge pull request #15407 from resilient-tech/server-scripts
feat: `frappe.enqueue` and `frappe.call` for Server Scripts
2021-12-24 14:14:51 +00:00
mergify[bot]
99ab47b949
Merge pull request #15394 from gavindsouza/safe-base64-decode
fix: Safe decode base64 data in case of incorrect padding
2021-12-23 18:07:15 +00:00
mergify[bot]
059e1cc364
fix: Report boilerplate (js, py) year to current year (#15429)
Co-authored-by: mymi14s <mymi14s@hotmail.com>
2021-12-23 21:49:45 +05:30
Sagar Vora
01f4ba2061 feat: frappe.enqueue and frappe.call for server scripts 2021-12-22 13:21:13 +05:30
Gavin D'souza
b56e6fe4db fix: Safe decode base64 data in case of incorrect padding
This could possibly happen in case of corrupted/partial files. But for
the most part, if there's a missing trailing = or three at the end too.

Traceback:
Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 68, in application
    response = frappe.api.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/api.py", line 55, in handle
    return frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 31, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 67, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1208, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/form/save.py", line 21, in savedocs
    doc.save()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 285, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 307, in _save
    self.insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 239, in insert
    self._validate()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 499, in _validate
    self._extract_images_from_text_editor()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/base_document.py", line 983, in _extract_images_from_text_editor
    extract_images_from_doc(self, df.fieldname)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py", line 779, in extract_images_from_doc
    content = extract_images_from_html(doc, content)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py", line 822, in extract_images_from_html
    content = re.sub(r']*src\s*=\s*["\'](?=data:)(.*?)["\']', _save_file, content)
  File "/home/frappe/frappe-bench/env/lib/python3.6/re.py", line 191, in sub
    return _compile(pattern, flags).sub(repl, string, count)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py", line 814, in _save_file
    _file.save(ignore_permissions=True)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 285, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 307, in _save
    self.insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 231, in insert
    self.run_method("before_insert")
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 860, in run_method
    out = Document.hook(fn)(self, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1158, in composer
    return composed(self, method, *args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1141, in runner
    add_to_return_value(self, fn(self, *args, **kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 854, in
    fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py", line 56, in before_insert
    self.save_file(content=self.content, decode=self.decode)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/core/doctype/file/file.py", line 436, in save_file
    self.content = base64.b64decode(self.content)
  File "/home/frappe/frappe-bench/env/lib/python3.6/base64.py", line 87, in b64decode
    return binascii.a2b_base64(s)
binascii.Error: Incorrect padding
2021-12-21 14:57:09 +05:30
Sagar Vora
6dc67835c5 fix: typo in comment
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
2021-12-21 12:05:38 +05:30
Sagar Vora
8b8f03f2d1 fix: remove irrelevant comment 2021-12-21 12:05:38 +05:30
Sagar Vora
e6d550b451 fix: remove unnecessary translation 2021-12-21 12:05:38 +05:30
Sagar Vora
a952c8994d fix: remove unnecessary loop 2021-12-21 12:05:38 +05:30
Sagar Vora
5df970013e feat: translations in Data Import 2021-12-21 12:05:38 +05:30
mergify[bot]
29c0e13fb0
Merge pull request #15377 from phot0n/website-generator-import-path-fix
fix: wrong website generator import tag
2021-12-20 15:54:35 +00:00
phot0n
564f463073 fix: wrong website generator import tag 2021-12-20 20:44:47 +05:30
Suraj Shetty
83be5f934b
Merge branch 'develop' into star-rating-dev 2021-12-17 11:31:11 +05:30
Faris Ansari
133ab39de2
Merge pull request #15334 from netchampfaris/server-script-error-ux
fix: Server Script UX
2021-12-16 20:32:18 +05:30
Suraj Shetty
4d2548cff9
Merge branch 'develop' into star-rating-dev 2021-12-16 19:40:25 +05:30
mergify[bot]
bf56858f09
Merge pull request #13504 from hrwX/multi_timezone_support
feat: Convert datetime field values to system timezone
2021-12-16 14:08:44 +00:00
Faris Ansari
eaec262b25 fix: Throw actual exception instead of ValidationError
- to make tests pass
2021-12-16 13:35:45 +05:30
Faris Ansari
f6c38b6b6e fix(ux): Show better error message when server script fails 2021-12-16 11:56:55 +05:30
Suraj Shetty
39014b09d8
Merge branch 'develop' into star-rating-dev 2021-12-14 18:18:36 +05:30
mergify[bot]
7153c6c0e9
Merge pull request #15237 from netchampfaris/document-states
feat: Document States
2021-12-14 12:29:58 +00:00
Faris Ansari
2635da19f4 fix: Add Document States in customize form 2021-12-14 14:20:46 +05:30
Faris Ansari
99bf94f784 fix: Set standard indicator colors
- Rename lightblue -> light-blue
2021-12-14 13:41:58 +05:30
Akash Chaudhari
fbf926d1f6
fix: Error code for "user not found" (#15223)
* fix: error code for not found

* fix: updating test

* fix: update status code

* fix: update test for status code 400
2021-12-14 05:07:38 +00:00
Diksha Jadhav
c477398a2f feat: make rating field's stars customizable with options field 2021-12-13 16:03:21 +05:30
Faris Ansari
f74b9be2c3
Merge pull request #15253 from netchampfaris/zip-files
feat: Zip files
2021-12-10 17:24:55 +05:30
Faris Ansari
a4b99cd7b4 feat: Zip files 2021-12-10 17:21:19 +05:30
Rohit Waghchaure
7118fb2e81 fix: record name creating based on naming seires and not as per the use set 2021-12-09 19:18:14 +05:30