Gavin D'souza
3446026555
chore: Update header: license.txt => LICENSE
...
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
2ad9d202cb
Merge branch 'develop' of github.com:frappe/frappe into drop-py2-code
2021-06-03 11:21:55 +05:30
leela
384d875b62
refactor: smtp session creation cleanup
2021-05-31 15:42:45 +05:30
Gavin D'souza
e407b78506
chore: Drop dead and deprecated code
...
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
leela
59bfc12da6
refactor: Cleaned Email Queue sendmail functionality
...
* Sending mail works independently
* You can send a mail by calling Queue_doc.send()
* Used context manager to track exceptions while sending mails
2021-05-06 10:08:50 +05:30
leela
a8f74d9471
refactor: Move finding email accounts code to EmailAccount doctype
2021-05-03 06:22:35 +05:30
Shivam Mishra
b3a8ecad63
refactor: don't encode server string
2020-11-25 17:34:44 +05:30
Shivam Mishra
f4c7c7aeed
fix: set self.port instead of self.smtp_port
2020-11-25 15:07:19 +05:30
Suraj Shetty
aef8ecc7ef
fix: Show custom message for invalid login credentials
2020-11-03 12:43:39 +05:30
Suraj Shetty
32b99abaa9
fix: Email error messages
2020-10-22 10:54:53 +05:30
Himanshu Warekar
1b4ecdf792
fix: unreferenced variable
2020-01-04 09:26:23 +05:30
Suraj Shetty
295c5f89f1
Merge branch 'develop' into email_ssl
2019-12-31 20:47:11 +05:30
Suraj Shetty
3c3516a652
fix(email): Do not encode smtp_server value ( #9137 )
...
* fix: Do not encode smtp server
Because it breaks in python 3
* fix: use cstr to change text_type to str
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
2019-12-28 11:21:08 +05:30
Chinmay D. Pai
6357a4a9a5
feat(email): allow ssl for outgoing emails, append to sent folder
...
* dont always use default outgoing account for sending
* allow ssl for outgoing emails
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-18 16:18:44 +05:30
Sagar Vora
cfd7f8bf37
fix: incorrect if condition in smtp module
2019-09-07 12:54:52 +05:30
Zlash65
9d61601829
feat: replace sender name by email account name
2019-02-12 17:37:45 +05:30
Aleksas Pielikis
ecb3d3f56d
feat(email): Allow emails to be sent without SMTP authentication by setting ( #6816 )
...
* Add email_account option to disable SMTP Authentication.
* Partially reverting email_account.py changes. Unnecessary incoming_server logic was added.
* Codacy code style issue fix.
* Suppress 'Password is required or select Awaiting Password' message if only smtp is used an no athentication is required.
* Suppress 'Password is required or select Awaiting Password' message if only smtp is used an no athentication is required.
* Simplified logic.
* Reverted excessive changes.
* fix: remove description and make label clear
2019-01-28 12:22:28 +05:30
Aditya Hase
7a12d3399f
fix(email): Pass args as unicode in Py2 & bytes in Py3 to SMTP.login
2019-01-22 23:06:17 +05:30
IOWEB TECHNOLOGIES
191684f6a5
Add option to convert password to use ASCII instead of Unicode when needed by smtp server config ( #5793 )
2018-07-23 11:08:15 +05:30
Ameya Shenoy
ab7b862a49
safe encode is not required
2018-07-06 18:15:17 +05:30
IOWEB TECHNOLOGIES
44f045ca04
Fix bug with smtplib and crammd5 servers that prevents email sending ( #5687 )
...
* Fix bug with smtplib and crammd5 servers that prevents email sending
* Use frappe.safe_decode instead of str
* Revert "Use frappe.safe_decode instead of str"
This reverts commit 272aa167fd86f90129517666b2cad85363026f87.
* Using frappe_encode to 'ascii' to send the password
* Update smtp.py
* Update smtp.py
2018-07-06 12:06:02 +05:30
Saurabh
edf361b132
resolved merge conflicts
2018-06-05 15:14:42 +05:30
Faris Ansari
ad64ef5c4e
[fix] Incorrect email account as sender ( #5657 )
...
If there are multiple Email Accounts with the same append_to,
then the first one is fetched which is incorrect if there is an
Email Account for the current user.
Now it is first filtered by email_id, if not found falls back to old
behaviour.
2018-06-05 14:44:49 +05:30
Storm
f632ad77d4
smtplib login expects strings for username and password
2018-03-06 09:04:56 -07:00
Makarand Bauskar
780df0be60
[hotfix] pull emails from all incoming email accounts instead of enqueue single email account ( #4199 )
2017-09-28 12:14:00 +05:30
Makarand Bauskar
ad1c04850c
[hotfix] send email from sender's email account if From field is selected on communication view ( #4181 )
...
* [hotfix] send email from sender's email account if From field is selected on communication view
* [fixes] codecy fixes
2017-09-27 12:41:35 +05:30
pratu16x7
276f5b5631
[setup] suppress post-setup messages
2017-09-05 12:15:43 +05:30
tundebabzy
702e52e665
Change raise syntax to python 3 compatible style ( #3497 )
...
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
* python 3 compatible raise statement
2017-06-19 09:07:19 +05:30
tundebabzy
6fbe20caaa
Except and raise statement python 3 compatible style ( #3216 )
...
* changes exception and raise statements to python 3 style
* changes except statement to python 3 style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* changes except and raise statement to python 3 compatible style
* adds six.reraise to fix python 3 style raise statements with traceback
* fixes indentation
2017-05-11 10:51:59 +05:30
slushpuppy
9ed4ce4a36
Fix for localhost SMTP servers without authentication ( #3139 )
...
* Update email_account.py
Fix for passwordless localhost SMTP servers
* Update smtp.py
* Update smtp.py
Updated
* Update smtp.py
Syntax error fix
* Update email_account.py
2017-04-26 14:59:35 +05:30
Viet Pham
138e1a3b93
fix #2116 Ignore no password exception for email account on smtp setup ( #2555 )
2017-01-10 14:39:00 +05:30
Rushabh Mehta
bd0852b965
[fix] email account, add sparkpost, sendgrid as options and refactor property use_tls, fixes frappe/erpnext#7129 ( #2418 )
2016-12-07 11:29:12 +05:30
Rushabh Mehta
4df583b1cf
[fix] email, deprecate frappe.email.sendmail, use frappe.sendmail
2016-11-18 11:32:18 +05:30
Rushabh Mehta
e585e9c38b
[minor]
2016-10-09 15:18:17 +05:30
Nabin Hait
368f47ba70
Test case fixed
2016-09-28 16:55:11 +05:30
Shreyas Patil
4e4f5b2d53
[Fix] Retry on Authentication error by Gmail, if emails are pulled from/pushed to server too frequently ( #2090 )
...
* [Fix] Authentication error is raised by Gmail, if emails are pulled from/pushed to server too frequently
* [Fix] Minor Fix
2016-09-23 17:16:22 +05:30
Nabin Hait
aef76fbb3f
Fixed version conflict
2016-09-23 12:19:29 +05:30
Rushabh Mehta
ed8021c539
[minor] retry if disconnected while sending email
2016-09-22 11:41:50 +05:30
Sujit Maharjan
9dc3bec1a5
Fixed password decryption for outgoing email ( #2067 )
...
Since the password was not decrypted, there was error in outgoing email (not from default).
Added
email_account.password = email_account.get_password()
to decrypt the password.
2016-09-19 14:25:59 +05:30
Rushabh Mehta
2f9c6adb74
[minor] fixes
2016-07-27 12:35:28 +05:30
Anand Doshi
526e9ea2d7
[security] encrypt passwords that need to be retrievable, except User password which should be hashed
2016-06-13 17:18:59 +05:30
Anand Doshi
8f59881e16
[fix] set from email in email body when always_use_account_email_id_as_sender=1
2016-04-15 17:27:54 +05:30
Anand Doshi
1e6b9e25d8
[fix] Attach signature in auto-reply
2016-02-15 17:36:51 +05:30
Anand Doshi
9d9e2992b4
[fix] bulk.py: always_use_account_email_id_as_sender
2016-01-25 13:07:38 +05:30
Rushabh Mehta
0bcd4f7054
[fix] email account name fix
2015-11-21 19:07:43 +05:30
Rushabh Mehta
3a839cb705
[minor] [fix] default sender in email account
2015-11-17 11:43:05 +05:30
Rushabh Mehta
a3c844d19b
[release] added Change Log
2015-10-15 16:30:39 +05:30
Anand Doshi
94de362e3c
[minor] frappe.are_emails_muted
2015-09-09 14:04:41 +05:30
Anand Doshi
a413239d7d
[minor] OutgoingEmailError
2015-07-24 13:38:48 +05:30
Anand Doshi
89aeb2d324
[fix] Email Account - Checkbox: Always use Account's Email ID as Sender
...
If checked, the sender is replaced with the Email ID mentioned in the Email Account. Used when your email provider does not allow you to send emails from different senders.
2015-06-11 00:21:37 -04:00
