Commit graph

115 commits

Author SHA1 Message Date
Gavin D'souza
6f2125fca6 Merge branch 'develop' of github.com:frappe/frappe into owner-unchange 2022-01-04 15:06:37 +05:30
Gavin D'souza
f72c445d41 fix: Clear Document cache on rename, delete 2022-01-03 19:02:41 +05:30
mergify[bot]
a52cd373af
Merge pull request #15508 from nextchamp-saqib/fix-modified-on-rename
fix: renaming a document updates the modified timestamp
2022-01-03 13:11:47 +00:00
Saqib Ansari
b0b19d7a09 fix: renaming a document updates the modified timestamp 2022-01-03 18:25:12 +05:30
barredterra
429d5178e0 feat: option to not rebuild search on rename 2021-12-24 16:14:10 +01:00
Ankush Menat
124407a70a fix: update EPS records when renaming doc 2021-11-30 11:16:46 +05:30
Aradhya-Tripathi
5e818198be refactor: converted queries in rename doc 2021-11-09 10:19:54 +05:30
Devin Slauenwhite
12e4b33a1f
fix: simplify merge condition statement
Co-authored-by: gavin <gavin18d@gmail.com>
2021-10-13 11:26:24 -04:00
Devin Slauenwhite
d61d4214cf Merge branch 'develop' into feat-bulk-rename-merge 2021-10-04 14:19:41 -04:00
Devin Slauenwhite
a8347c0b27 feat: allow bulk rename with merge 2021-10-04 14:15:54 -04:00
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Ankush Menat
d8a4cf896b
perf: prefer set builder notation over constructor 2021-05-12 20:38:18 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
Suraj Shetty
c63e0b66cf
Merge branch 'develop' into rename-error 2021-01-13 19:26:23 +05:30
Prssanna Desai
51d8046da1
fix: use frappe.throw
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-01-04 15:30:28 +05:30
prssanna
5b8294f92b fix: throw error if name already exists 2020-12-24 15:22:09 +05:30
Gavin D'souza
1a5ed2a6fd Merge branch 'develop' of github.com:frappe/frappe into fix-broken-folders 2020-12-10 14:17:05 +05:30
Gavin D'souza
29941ef46a fix: Use ORM instead of raw SQL
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2020-11-30 12:03:53 +05:30
Gavin D'souza
a0cb593019 style: Sort and remove unused imports 2020-11-27 20:33:10 +05:30
Gavin D'souza
e3b09e2a2a fix: Add rename_doc utils for external API usages
* The previously deleted code was being used in ERPNext's Customer
module.
* This will be moved into frappe.model.utils.rename_doc for the time
and completely removed in time.
2020-11-27 20:19:50 +05:30
Gavin D'souza
861f41684c Merge branch 'develop' of github.com:frappe/frappe into fix-broken-folders 2020-11-27 16:23:59 +05:30
Gavin D'souza
104bc1b167 chore: Remove dead code 2020-11-27 15:09:23 +05:30
Gavin D'souza
58ed57e8f5 fix: Add postgreSQL support for rename_doc queries 2020-11-27 15:01:46 +05:30
marination
841f2f4a36 chore: Rename Doctype Test and more explicit comment
- Better decription of why the fix is done, what case it handles
- Test for Renaming Doctype and Record having same name as DocType
2020-11-03 21:57:26 +05:30
Gavin D'souza
c73e779373 fix: Validate existing doctype names too 2020-10-27 21:26:47 +05:30
marination
59d35cb5ae fix: Conditionally set parent field only on DocType rename 2020-10-20 20:21:07 +05:30
Suraj Shetty
9e43e88755 fix: Remove unnecessary whitelisting of rename_doc method 2020-09-08 10:38:26 +05:30
Suraj Shetty
a7aefdfb88
fix: Syntax error 2020-06-01 21:13:13 +05:30
prssanna
59eff3df40 Merge branch 'rename-doc-todo-fix' of https://github.com/prssanna/frappe into rename-doc-todo-fix 2020-06-01 12:21:09 +05:30
prssanna
f9b8637060 fix: remove unused import 2020-06-01 12:20:34 +05:30
Prssanna Desai
454a574d43
fix: use frappe.as_json
Co-authored-by: gavin <gavin18d@gmail.com>
2020-06-01 12:19:04 +05:30
prssanna
d6206ed411 fix: update assignemnts on merging docs 2020-05-29 16:50:31 +05:30
Suraj Shetty
2233235ec2
fix: duplicate entry error while renaming item (#9651)
Co-authored-by: Rohit Waghchaure <rohitw1991@gmail.com>
2020-03-12 18:38:45 +05:30
Gavin D'souza
43ae8adeb4 feat: show_alert flag in rename_doc API 2019-12-30 12:52:35 +05:30
Gavin D'souza
5255513fff fix: merge documents without error 2019-10-27 18:52:37 +05:30
Himanshu Warekar
604b659353 fix: check for old and new names 2019-10-23 22:26:45 +05:30
Himanshu Warekar
31cef1ac5b fix: arguments not passed 2019-10-23 22:26:32 +05:30
Faris Ansari
83225791d8 fix: cleanup 2019-10-21 16:15:39 +05:30
Gavin D'souza
12d1d5a649 fix: shifted tasks to server-side via frappe.call 2019-10-15 00:16:18 +05:30
Gavin D'souza
6c9adf95a3 fix: rename docname and title 2019-10-07 16:01:39 +05:30
Suraj Shetty
1bcdc0b7cb fix(report): Allow report export only if user has export permission on ref doctype (#7458)
* fix: Allow export only if user has export permission on reference doctype

* fix: Show only custom "no permission" error

* fix: while saving employee user getting user permissions error
2019-05-15 11:59:13 +05:30
Faris Ansari
3b86f16b73 New Control: Table MultiSelect (#6675)
* feat(control): Add Table MultiSelect control

* fix: Use btn-group instead of span

* fix: Remove functionality

* fix: Add 'Table MultiSelect' to Field doctypes

* fix: Replace usage of string 'Table' with array `table_fields`

* fix: Use internal array to store values instead of building from HTML elements

* fix(style): Add semicolon

* fix: Read only mode and click to navigate to form

* style: indent

* fix: fallback to empty array

* fix: Add formatters in js and py

* style: missing semicolon

* fix: Add docfield validation
2018-12-28 15:36:59 +05:30
Frappe Bot
0499b4a845 Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
Suraj Shetty
79ddfe6021
Merge branch 'staging-fixes' into staging-fixes 2018-11-26 18:12:34 +05:30
Ameya Shenoy
13524a1ad5
Merge branch 'staging' into develop 2018-11-23 08:14:29 +00:00
Ameya Shenoy
d1d0edc636
Merge branch 'master' into staging-fixes 2018-11-23 08:07:36 +00:00
rohitwaghchaure
df6687f9c0 fix: After rename, user still able to search document using old name (#6515) 2018-11-22 11:33:29 +05:30
Suraj Shetty
5df1a040ff Remove unwanted code 2018-11-01 21:18:14 +05:30