Commit graph

235 commits

Author SHA1 Message Date
Gavin D'souza
6aa9a0bef5 style: Sorted imports & whitespace consistency 2022-01-07 20:44:51 +05:30
Rutwik Hiwalkar
1ec54c87c8
feat: patched frappe email to work with frappecloud mail app (#15248)
* feat: patched EmailQueue.send and frappe.utils.get_formatted_email

* chore: renamed hooks and handled an edge case

* fix: if the get_sender_details hook is defined but it returns invalid input
2021-12-12 21:09:31 +05:30
Ankush Menat
00d38d568c
fix: remove slash prefix 2021-12-12 15:20:50 +05:30
Ankush Menat
38cd12a95b fix: remove bench path from traceback
This is mostly useless for debugging and clutters the error message.
2021-12-12 11:53:13 +05:30
Kevin Backhouse
2f99306d63
Fix ReDoS bug: GHSL-2021-122 (#15201) 2021-12-08 04:57:07 +00:00
codescientist703
ed13182573 chore: Remove Chat Module 2021-11-09 13:44:57 +05:30
Suraj Shetty
31d5d81e31
revert: "chore: Remove chat module" (#14922) 2021-11-09 10:30:00 +05:30
codescientist703
68d4b1d23e chore: removed unused chat utils 2021-10-13 19:32:15 +05:30
codescientist703
d766b8f158 refactor: move chat utils to frappe utils 2021-10-11 15:28:49 +05:30
Gavin D'souza
7c6fad09ee fix: NoneType comparison flake8 E711
ref: https://www.flake8rules.com/rules/E711.html
2021-10-04 11:01:56 +05:30
Gavin D'souza
f37b954fbf fix: get_assets_json w/o Redis too ;) 2021-10-03 12:30:52 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
94701fdb7d feat(utils): frappe.utils.get_table_name
Fetch table name from doctype/__ table name passed
2021-07-30 12:27:22 +05:30
leela
ff973477a3 fix: Use bench path as default bench_id 2021-07-29 20:43:34 +05:30
leela
db09a85183 refactor: Add authentication for Redis Queue 2021-07-26 21:09:34 +05:30
leela
9b437f8c90 feat: Add rq users 2021-07-20 05:45:17 +05:30
Suraj Shetty
7dfced5047 Merge branch 'develop' of https://github.com/frappe/frappe into refactor-website 2021-06-17 09:48:50 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
Suraj Shetty
2d8c6c1710 Merge branch 'develop' of https://github.com/frappe/frappe into refactor-website 2021-06-03 11:43:28 +05:30
Gavin D'souza
4e7526066f Merge branch 'develop' into drop-py2-code 2021-05-28 10:51:39 +05:30
Suraj Shetty
6c05401495 Merge branch 'develop' of https://github.com/frappe/frappe into refactor-website 2021-05-27 14:28:33 +05:30
Faris Ansari
23406d031a fix: Store assets.json directly in assets folder
assets.json stores assets of all apps, so doesn't make sense to put it in frappe folder
2021-05-27 11:50:56 +05:30
Gavin D'souza
f6b215938a fix: Use raw string to avoid invalid sequence errors
Escaped when proven easier
2021-05-26 19:30:08 +05:30
Gavin D'souza
3adb84eb8d chore: Drop watchdog dependency
Watchdog isn't used by Frappe, and there wasn't any mechanism to access
it directly either. By default, bench serve (or start) uses
Werkzeug's watchdogreloader
2021-05-26 17:04:28 +05:30
Gavin D'souza
bd6fcddd04 chore: Drop unreachable code 2021-05-26 16:41:32 +05:30
Gavin D'souza
feea2f3c44 fix: Use raw string to avoid invalid escape sequence errors 2021-05-26 16:32:41 +05:30
Gavin D'souza
1e9b0cf386 fix: Use dict.items instead of six.iteritems 2021-05-26 16:02:27 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Suraj Shetty
51a072bbf8 Merge branch 'develop' of https://github.com/frappe/frappe into refactor-website 2021-05-18 17:02:44 +05:30
Faris Ansari
792dd70730 fix: Handle AttributeError 2021-05-18 14:05:56 +05:30
Faris Ansari
dc04fe9ed6 fix: Handle decode error when getting value from cache 2021-05-18 13:40:47 +05:30
Suraj Shetty
a54411750f
Merge branch 'develop' into esbuild 2021-05-17 22:10:46 +05:30
Suraj Shetty
8c8291ae38
fix: Delete duplicate validate_url method 2021-05-17 22:09:19 +05:30
Nabin Hait
75ea09f9df fix: Resolved conflict issue 2021-05-17 11:35:48 +05:30
Nabin Hait
6d7a852351 Merge branch 'version-13' into develop 2021-05-17 11:21:46 +05:30
Faris Ansari
f8ca990a83 Merge remote-tracking branch 'upstream/develop' into esbuild 2021-05-16 11:26:43 +05:30
Suraj Shetty
20bab0f631 refactor: Move code to appropriate places 2021-05-14 18:58:04 +05:30
Ankush Menat
4754ab71d1
perf(minor): remove unnecessary comprehensions
- remove several unnecessary comprehensions from functions that accept a generator.
- Using `[x for x in iter]` causes a list to be built first then passed to the outer function.
- `any` and `all` can take generator instead. This makes memory usage O(1) and actually makes these functions short-circuiting. E.g. if the first condition fails then `all` will immediately return false instead of evaluating all the entries.
- `sum`, `min`, `max` => memory usage become O(1)
- `list`, `set`, `.join()` => roughly halves memory usage, as list is not required to be built.
- lastly, it's two fewer characters to read/think about.
2021-05-12 20:38:18 +05:30
Gavin D'souza
d43046a4cb fix: any takes an iterable not multi args 2021-05-07 13:24:48 +05:30
Gavin D'souza
855efcfd59 style: Trim whitespace and remove unnecessary parenthesis 2021-05-07 12:15:32 +05:30
Gavin D'souza
1752e5b0e5 feat(cli): Show progress bar for website search index building 2021-05-07 12:14:00 +05:30
Faris Ansari
6347d3e6f1 Merge remote-tracking branch 'upstream/develop' into esbuild 2021-05-04 07:13:30 +05:30
Abhishek Balam
f4e4fc98f9 fix: remove unnecessary schemes and minor changes 2021-05-02 00:32:01 +05:30
Faris Ansari
adc236e35d feat: Notify build events to browser
- Update assets_json directly from node
- Show error overlay or success message
- Open file in editor from error overlay
2021-05-01 16:02:49 +05:30
Hussain Nagaria
024e759a70 refactor: Add optional URL scheme validation 2021-05-01 00:34:19 +05:30
Hussain Nagaria
3e229e931a test: Email and URL validate functions 2021-04-30 15:37:55 +05:30
Hussain Nagaria
b965cebbd4 fix: Sider issues 2021-04-30 14:55:32 +05:30
Hussain Nagaria
9d4ee238d7 fix: Remove duplicate validation function 2021-04-30 14:52:16 +05:30
Revant Nandgaonkar
2b5da6c3c2 fix: remove six imports and use py3 defaults
(cherry picked from commit c4a9238549)
2021-04-29 14:14:30 +00:00
Revant Nandgaonkar
1f2b3e502e fix: sider issues
(cherry picked from commit 1f54b8b973)
2021-04-29 14:14:30 +00:00