Commit graph

36088 commits

Author SHA1 Message Date
Jannat Patel
7585a26d43 fix: translation for sla description 2021-12-08 18:12:09 +05:30
Summayya
0f08c53c7c refactor: breadcrumb style for portal pages 2021-12-08 18:02:03 +05:30
Summayya
d7b2822ce8 refactor: move rnl arrow to common variable file 2021-12-08 18:01:07 +05:30
Kieran
9421736fb9
feat: add number format for BTC 2021-12-08 12:30:02 +00:00
Ankush Menat
81d248bbab chore: raise threshold for patch coverage 2021-12-08 16:25:50 +05:30
saxenabhishek
a71795afec docs: ConstantColumn 2021-12-08 15:46:30 +05:30
saxenabhishek
9a393e5654 fix: postgres compatibility 2021-12-08 15:43:22 +05:30
Kevin Backhouse
2f99306d63
Fix ReDoS bug: GHSL-2021-122 (#15201) 2021-12-08 04:57:07 +00:00
Suraj Shetty
5c34405d8a
Merge branch 'develop' into aks-feat-constCol 2021-12-08 09:33:50 +05:30
saxenabhishek
4f7c8d066a feat: build constant value cols 2021-12-07 20:55:38 +05:30
Faris Ansari
19fb8cd409
Merge pull request #15182 from netchampfaris/cleanup-newsletter
fix: Newsletter Enhancements
2021-12-07 18:38:09 +05:30
Faris Ansari
4bb79161be style: missing semicolon 2021-12-07 17:57:18 +05:30
Faris Ansari
d760e25b63 tests: fix newsletter tests 2021-12-07 17:43:57 +05:30
Faris Ansari
ccc65defb6 fix(newsletter): better open in web link 2021-12-07 17:20:58 +05:30
Faris Ansari
947727ccd7 fix(markdown-editor): preview btn 2021-12-07 17:20:42 +05:30
Suraj Shetty
99defea410
fix: Explicitly ignore semgrep warning 2021-12-07 16:40:45 +05:30
mergify[bot]
c9426024ca
Merge pull request #15198 from Aradhya-Tripathi/at/fixes
fix(qb): Miscellaneous fixes
2021-12-07 10:31:33 +00:00
Faris Ansari
606a0d3809 fix: various fixes
- show published newsletters in list view
- show published newsletter as web page
- show status section after newsletter is sent
- add email_sent_at and total_recipients field
2021-12-07 15:52:25 +05:30
Faris Ansari
de7d0337a6 fix: various newsletter form ux fixes
- Cancel Scheduling button
- Show dashboard message if newsletter is scheduled
2021-12-07 15:48:35 +05:30
Faris Ansari
1bb3c2d3f4 fix: add on_hide event in form
can be used to clearing events, for e.g., clearing setInterval
2021-12-07 15:41:38 +05:30
Faris Ansari
330677bb0a fix: better sending status
- show email sending progress in form dashboard
2021-12-07 15:40:55 +05:30
Jannat Patel
3caa93c2c4 chore: sla tracking 2021-12-07 11:14:11 +05:30
mergify[bot]
44aaeccef0
Merge pull request #15188 from alyf-de/refactor-module-profile
refactor: module profile
2021-12-07 04:12:04 +00:00
barredterra
0e42c55b70 Merge remote-tracking branch 'upstream/develop' into refactor-module-profile 2021-12-06 17:14:50 +01:00
Faris Ansari
9bdb5f2eb2 fix: Explicit attachments table
The newsletter content may contain images that get "attached" to the
newsletter document. If this is the case, you can't selectively include
attachments in the newsletter as it attaches all the attachments.
An explicit attachments table solves this problem.
2021-12-06 17:04:24 +05:30
mergify[bot]
bb1d3efc10
Merge pull request #15199 from ruchamahabal/fix-fetch-from
fix: Allow Fetch From for a different link field of the same DocType
2021-12-06 10:51:00 +00:00
Faris Ansari
0d3bac5528 fix(ux): Show broken links as dashboard message 2021-12-06 15:38:59 +05:30
Faris Ansari
02759631b4 fix: handle falsy return values in document methods
problem: if a whitelisted document method returns a falsy value like
`[]`, `{}`, `0` then response.message is not set and not returned
in the response.

this change checks if the return value is `None` and falsy values
are returned properly in the response
2021-12-06 15:38:59 +05:30
Faris Ansari
742d5e2e06 fix: utility method to create a range of values
mimics python's range function
2021-12-06 15:38:58 +05:30
Faris Ansari
f6379fdf40 fix: allow options in datepicker via df.options
ability to customize datepicker options via df.options
2021-12-06 15:38:58 +05:30
Faris Ansari
da4160e2dd fix: Newsletter enhancements and fixes
- Organize fields into sections
- Buttons for Send now and Scheduled sending
- Buttons to Send test email and to Check broken links
- Remove Test section
2021-12-06 15:38:58 +05:30
Rucha Mahabal
8340639afd fix: Allow Fetch From for a different link field of the same DocType 2021-12-06 14:51:37 +05:30
saxenabhishek
aa855afe08 test: test for patches through walk 2021-12-06 14:32:58 +05:30
saxenabhishek
6120b4b3c1 fix: extend named parameters to frappe.qb.function 2021-12-06 14:32:55 +05:30
saxenabhishek
9fdacedfc8 feat: sanitise frappe.qb 2021-12-06 14:29:57 +05:30
saxenabhishek
a574c1ba88 chore: patching ValueWrapper 2021-12-06 14:27:42 +05:30
Aradhya
3243fb2083 fix: misc fixes 2021-12-06 13:04:27 +05:30
this-gavagai
8ead1d9c48
fix: Clarified docstatus transition exceptions (#15194)
* [fix] Clarified docstatus transition exceptions

Exceptions issued by the document.py `check_docstatus_transition` method are potentially very misleading. In cases where an invalid docstatus is used, users receive an confusing exception stating "Cannot change docstatus from 0 to 2" or "Cannot change docstatus from 1 to 0". 

This PR adds an additional exception message when an invalid docstatus is used.

* fix: Clarified docstatus transition exceptions

Added additional clarifications to exception messages
2021-12-06 07:28:43 +00:00
barredterra
504f8743c9 fix: remove debugger 2021-12-03 17:24:57 +01:00
barredterra
850cd54b89 refactor: module profile 2021-12-03 17:07:16 +01:00
mergify[bot]
fec76ba950
Merge pull request #15174 from ruchamahabal/event-last-update
fix: Delete Event Producer Last Update on trash event of Event Producer
2021-12-03 14:53:51 +00:00
Suraj Shetty
404856bc61
Merge branch 'develop' into event-last-update 2021-12-03 20:09:03 +05:30
mergify[bot]
23e5505923
Merge pull request #15170 from Aradhya-Tripathi/at/fixes
fix: fixed list of Field objects as fields in get_values
2021-12-03 14:36:36 +00:00
Raffael Meyer
c5df17e356
fix: cannot uninstall app with virtual doctype (#15136)
* Update installer.py

* fix: Drop table only if it exists

* revert: "Update installer.py"

This reverts commit 0e8370ede8a9c2b1c0687e5c216ecf67566da0f5.

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2021-12-03 14:34:41 +00:00
mergify[bot]
5172e9e5d2
Merge pull request #15179 from nextchamp-saqib/fix-sql-mask-error
fix: IndexError while handling sql timeout error
2021-12-03 13:27:19 +00:00
Suraj Shetty
522227a740
Merge branch 'develop' into fix-sql-mask-error 2021-12-03 18:08:52 +05:30
Summayya Hashmani
db951d2369
frefactor: padd separate padding (#15178)
Co-authored-by: Summayya <frappe@Summayyas-MacBook-Air.local>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-12-03 11:52:07 +00:00
Saqib Ansari
6f7d030e82 fix: IndexError while handling sql timeout error 2021-12-03 16:06:23 +05:30
Shariq Ansari
7de0c08a9d
Merge branch 'develop' into duplicate-listview-records 2021-12-03 15:19:50 +05:30
Aradhya
e862ae83da fix: fixed list of Field objects as fields in get_values
tests: added test for list of field objects
2021-12-03 14:24:19 +05:30