Commit graph

463 commits

Author SHA1 Message Date
Shariq Ansari
b44235587f
test: fixed failing UI test (#16958) 2022-05-24 13:17:21 +05:30
Ankush Menat
fe8520a2bd
fix: duplicate buttons on desk (#16941) 2022-05-23 12:39:01 +05:30
Shariq Ansari
3a2cd2650e test: fixed failing UI test 2022-05-19 15:00:54 +05:30
Shariq Ansari
176518ed2c
fix: Mandatory field bad UX (#16919)
Mandatory fields are highlighted red on page load. It should only highlight if we save the document.

**Before:** Form

https://user-images.githubusercontent.com/30859809/168791201-049c1de2-b7f5-4dff-bf40-093ff96d4510.mov

**After:** Form

https://user-images.githubusercontent.com/30859809/168791164-45e2289b-2d2c-4ebb-8b4d-cd2932140572.mov

**Before:** Dialog

https://user-images.githubusercontent.com/30859809/168791207-800ba9e5-b4eb-419f-8a99-f94916c21c79.mov

**After:** Dialog

https://user-images.githubusercontent.com/30859809/168791210-f2761d23-3a60-40c2-8aff-2d2cebbd77fa.mov

Resolves https://github.com/frappe/frappe/issues/16866
2022-05-18 09:57:49 +00:00
Komal-Saraf0609
fea45bf341
test: Added test script for control type "Color" (#16619) 2022-05-17 12:40:37 +05:30
Himanshu
70409a3c7b
fix: set translated text to link field (#15451)
- Fixes [Issue/15324](https://github.com/frappe/frappe/issues/15324)
- When selecting a value for Link Field, the English text was set as link field value.
- This PR aims to fix it by setting the translated text as link field value on selection.

Todo:

- [x] Show translated text in the select dropdown
- [x] Set translated value to Link field on select
- [x] Show original value when link field is in focus
- [x] Add option to toggle this behaviour

### Behaviour

- Link field loses focus: show the translated name.
- Link field is focused
    - If old value is present
        - If options **are** one of [Role, DocType]: show the translated name
        - Else: show the name (untranslated) to enable search in untranslated values
    - Else: show what the user typed (untranslated) to enable search in untranslated values
- Value is selected: link field loses focus

## Demo

### Link to UOM in a custom Item DocType

The UOM names are in english, so the search needs to happen in english. When possible, the translation is displayed.

#### Before

https://user-images.githubusercontent.com/14891507/156415248-e5e80d05-53dc-4ca8-89c7-998986ff6e99.mov

#### After

https://user-images.githubusercontent.com/14891507/156410386-a874430c-f340-43ed-9c3a-92e8d4d50fc9.mov

### Link to DocType in Customize Form

The DocType names get translated before being searched. This is a preexisting hack in the framework for DocType and Role. In this case, we can search in the translations.

#### Before

https://user-images.githubusercontent.com/14891507/156414648-8e505f8c-9dee-4358-8182-3b358c28bb62.mov

#### After

https://user-images.githubusercontent.com/14891507/156411881-c4ca22e1-1397-4e13-9768-5e16b72f8d6d.mov

https://docs.erpnext.com/docs/v13/user/manual/en/customize-erpnext/customize-form/edit?wiki_page_patch=fdafee2715
2022-05-16 13:21:42 +00:00
Shariq Ansari
78489cd700
feat: Quick List Block for Workspace (#16887) 2022-05-13 15:34:35 +05:30
Suraj Shetty
4be5ca6481 Merge branch 'develop' of https://github.com/frappe/frappe into fix-ui-flaky-tests 2022-05-05 19:28:00 +05:30
Suraj Shetty
aac9378beb
test: Disable flaky test
Unable to find the cause of the flakiness of the test. Disabling it for now.

Also, the form_tour test is full of `wait` which is bad anyway.
2022-05-05 18:37:08 +05:30
Suraj Shetty
bec77dba0d test: Fix flaky tests
Disable form tour tests
2022-04-28 19:32:43 +05:30
Rushabh Mehta
a59e5d7aac
Merge pull request #16791 from rmehta/fix-control-test
test: Fixes `control_dynamic_link` test
2022-04-28 16:05:05 +05:30
Rushabh Mehta
dfeb16f58d fix(test): control_dynamic_link.js 2022-04-28 15:20:29 +05:30
Rushabh Mehta
c23cc52948 fix(test): control_dynamic_link.js 2022-04-28 15:17:56 +05:30
gavin
f1cceba81b
Merge pull request #16763 from surajshetty3416/fix-autoname-validation
fix: Validate "autoname" for Customize Form
2022-04-28 15:03:39 +05:30
Suraj Shetty
532e5dd0d6
Merge pull request #16620 from Komal-Saraf0609/control-data 2022-04-28 15:02:50 +05:30
Rushabh Mehta
9847019457 fix(test): control_dynamic_link.js 2022-04-28 14:47:07 +05:30
Rushabh Mehta
efd993cdc3 fix(test): control_dynamic_link.js 2022-04-28 14:45:27 +05:30
Rushabh Mehta
ec2c65f0a5 fix(test): control_dynamic_link.js 2022-04-28 14:27:46 +05:30
Komal-Saraf0609
03efa25d03 test: Corrected failed tests 2022-04-28 12:06:45 +05:30
Suraj Shetty
30440026db fix: Do not allow autoname changes to/from autoincrement in customize form 2022-04-28 11:44:33 +05:30
Suraj Shetty
ccc82e2c4c
Merge pull request #15538 from noahjacob/phone_field_control
feat: Phone Control Type
2022-04-28 10:27:52 +05:30
Suraj Shetty
2f2fc0440d test: Init UI test for customize form 2022-04-27 15:56:20 +05:30
Suraj Shetty
bad4c38fd2
Merge branch 'develop' into control-data 2022-04-25 16:18:04 +05:30
Suraj Shetty
eb92acfbf3
Merge pull request #16718 from shariquerik/flaky-ui-test-3 2022-04-25 11:15:29 +05:30
Shariq Ansari
042f98bcc5
fix: Workspace Miscellaneous fixes (#16578) 2022-04-22 18:00:44 +05:30
Shariq Ansari
d558f16e71 test: fixed flaky test for form, timeline_email 2022-04-22 17:43:20 +05:30
Shariq Ansari
09a0077079 style: fixed indentation 2022-04-22 17:13:46 +05:30
Shariq Ansari
8c953b4f74 test: removing drag drop test(flaky) 2022-04-22 16:59:42 +05:30
Shariq Ansari
7f83178556 test: flaky markdown editor fix 2022-04-22 16:59:22 +05:30
Komal-Saraf0609
8592f07363 test: Corrected selector 2022-04-22 15:00:52 +05:30
Komal-Saraf0609
a9de2382a9 test: Fixed sider issues 2022-04-22 14:39:47 +05:30
Komal-Saraf0609
161fa18660 test: Corrected selectors 2022-04-22 14:33:48 +05:30
Faris Ansari
620a944104
Merge pull request #16622 from netchampfaris/less-flaky-date-test
test: less flaky date control test
2022-04-20 14:10:55 +05:30
Faris Ansari
d1978d8e62 fix: check dates in frappe realm
new Date in Cypress context and new Date in frappe context differs sometimes in CI
2022-04-19 16:49:08 +05:30
Suraj Shetty
8f94cb655f
Merge branch 'develop' into phone_field_control 2022-04-19 16:28:18 +05:30
Shariq Ansari
ef6bb79f65
test: Typing on focused input issue (#16669) 2022-04-19 15:51:03 +05:30
Faris Ansari
afebaa0a23 test: less flaky date control test 2022-04-19 00:21:08 +05:30
Himanshu
803f1fb061
feat: add/remove fields from kanban board (#16257)
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-04-18 15:45:19 +05:30
Suraj Shetty
a0e9b61e04 test: Simplify phone control test 2022-04-14 18:14:55 +05:30
Suraj Shetty
a396afc7d4 fix: Validation error 2022-04-14 17:05:07 +05:30
Suraj Shetty
6b7fda495b Merge branch 'develop' of https://github.com/frappe/frappe into phone_field_control 2022-04-14 14:19:35 +05:30
Komal-Saraf0609
dda56b3759 test: Fixed sider issues 2022-04-14 13:27:20 +05:30
Komal-Saraf0609
651aa36cd2 test: Added script for control type "Data" 2022-04-14 13:20:54 +05:30
Faris Ansari
168bf6d3e4 test: ui test for inserting image in markdown 2022-04-14 00:46:32 +05:30
Noah Jacob
36ca84c9ff test: suggested changes 2022-04-12 21:06:19 +05:30
Noah Jacob
c2f2fc10e7 Merge branch develop into phone_field_control 2022-04-12 20:40:29 +05:30
mergify[bot]
31d87176c1
Merge pull request #16570 from resilient-tech/fix-theme-switcher
fix: theme switcher shortcut issue
2022-04-11 11:26:56 +00:00
lapardnemihk1099
5993a8ba57 chore: sider issues fixed 2022-04-11 14:45:13 +05:30
lapardnemihk1099
27d226f295 test: theme switcher dialog shortcut test 2022-04-11 14:32:14 +05:30
Suraj Shetty
908a169626
Merge branch 'develop' into fmatch 2022-04-10 08:24:55 +05:30