Commit graph

125 commits

Author SHA1 Message Date
rohitwaghchaure
796d94cc6d
fix: minor (#9927) 2020-04-13 14:41:11 +00:00
prssanna
6807427383 fix(Report): Remove field from query only if view is Report 2020-02-29 17:31:42 +05:30
Himanshu Warekar
5754ef750b fix: use _user_tags instead of Tag Link 2020-01-05 22:09:20 +05:30
Himanshu
a89c9671ac fix: use distinct for tag filters (#9126) 2019-12-25 07:49:02 +00:00
Himanshu Warekar
698764b89b review changes 2019-12-25 09:57:01 +05:30
Himanshu
6c39d3c3d3
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:48:04 +05:30
Himanshu
ddaae94282
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:47:10 +05:30
Himanshu
90850a5123
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:47:04 +05:30
Himanshu
2392720222
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:46:44 +05:30
Himanshu
638f978f11
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:46:26 +05:30
Himanshu
15e689c369
Update frappe/desk/reportview.py
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-12-25 09:45:29 +05:30
Himanshu Warekar
51afdaf86a fix: ignore distinct for tag link 2019-12-24 19:06:38 +05:30
Himanshu Warekar
f6c94cc613 fix: distinct tag total 2019-12-24 11:25:36 +05:30
Himanshu Warekar
4e79b7994e fix: miscellaneous fixes 2019-12-23 07:37:50 +05:30
Chinmay D. Pai
56b0385841
chore: remove useless encode
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-11-29 16:25:31 +05:30
Chinmay D. Pai
29fcd291b1
fix(reportview): convert to unicode conditionally
fixes TypeError: decoding str is not supported

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 57, in application
    response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 61, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1038, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 511, in wrapper_fn
    retval = fn(*args, **get_newargs(fn, kwargs))
  File "/home/frappe/frappe-bench/apps/frappe/frappe/desk/reportview.py", line 177, in export_query
    frappe.response['result'] = text_type(f.read(), 'utf-8')
TypeError: decoding str is not supported

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-11-29 13:18:48 +05:30
Himanshu Warekar
c3f68142db fix: tags should consider list filters 2019-11-20 16:09:01 +05:30
Himanshu Warekar
02cebdd7d3 fix: use frappe.tags 2019-10-03 16:43:36 +05:30
Himanshu Warekar
a952a5b5c3 feat: unique entry for each tag 2019-09-25 22:15:40 +05:30
Himanshu Warekar
b7196f124c feat: use tag link for global tags 2019-09-24 23:25:04 +05:30
Himanshu Warekar
f6d1ce2194 feat: Global Tags 2019-09-24 01:03:11 +05:30
Rucha Mahabal
c120bd3466
fix: merge key validations 2019-09-19 13:39:56 +05:30
Rucha Mahabal
d4ea2b4c1f
fix: merge key validations
Co-Authored-By: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2019-09-19 13:34:51 +05:30
Rucha Mahabal
03587849b8 fix: export report not working for add group 2019-09-19 13:09:06 +05:30
Prssanna Desai
d42fea0104 feat: Add child table fields to group by in reports (#8390) 2019-09-11 17:11:24 +05:30
Saurabh
dd4761e404
Merge pull request #8380 from nabinhait/bulk-delete-error-handling
fix: Handle error on bulk deletion
2019-09-10 11:26:46 +05:30
Nabin Hait
b86dbf1c82 fix: Handle error on bulk deletion 2019-09-09 16:18:02 +05:30
Suraj Shetty
0b2e236546 fix: Key Error while opening report 2019-09-05 08:44:13 +05:30
Faris Ansari
06349a8116 fix: Show report_name in Print, Excel, CSV 2019-09-02 23:24:51 +05:30
Suraj Shetty
9ae4100836 fix(security): fix(security): Remove 'ignore_permissions' from in form_dict 2019-08-12 21:25:37 +05:30
gavin
b5ab59ad6e feat: Access log (#8014)
* feat: Access log doctype for logging information about private file
downloads, backups downloads, printing and exporting data

* updated: access log

* updated: formattted access_log.js

* access logging: print/pdf/pvt files/export/backup

client side implementation: treeview, query_report
server side implementation on the rest

* fixes: codacy errors

* Update response.py

* Update response.py

* Update response.py

* codacy: please

* travis fixes

* changes:filters=>_filters(lol this works @ times?)

added: tests for access_log, make_access_log formatting, form ui added
buttons

* this hopefully fixes em tests

* changes: fixed indents, session.user, formatting

* fixes: tests, refactor, permissions

emerging from exporter.py => reference doctype in export_data (check
format!)

* fixes: convert dict to json

* changes: added more tests, wrote lesser code?

switched js to display depends on

* fixes: codacy and hopefully travis

* fix: tests? and polishing up

* added column field, removed tracked views

changed access log in exporter.py > export_data
added access log in reportview.py > export_query

* style: Fix indentation

* style: Fix indentation

* fix: Remove problematic string replace

It may replace quotes in the actual filter values which can result in invalid JSON

* fix: Remove filter string conversion

* fix: Error due to quote escapes

TODO: Check for a better way
2019-08-06 10:24:55 +05:30
Aditya Hase
7bcf652a23 fix(search): Reduce restrictions on field contents 2019-07-30 14:27:52 +05:30
Faris Ansari
915e6bc701 fix: Show totals in Auto Email Report if enabled 2019-07-18 16:32:38 +05:30
Rushabh Mehta
87082e2c07 fix(report): charting in reports now supports group by and saved in user settings; 2019-05-07 15:50:18 +05:30
Suraj Shetty
bc05377352
fix(reportview): use .pop instead of del
- use .pop() instead of del to avoid KeyError
2019-02-20 13:10:11 +05:30
Suraj Shetty
0035c90fa5
Merge pull request #6926 from netchampfaris/fix-frappe-call-to-api-method
fix: Make requests with cmd on /api/method/path
2019-02-20 08:58:36 +05:30
Himanshu Warekar
54da12efd0 delete_bulk_fix 2019-02-17 18:23:12 +05:30
Faris Ansari
0dbafb9c6b fix: Make requests with cmd on /api/method/path
- Will help in better debugging and Cypress testing
2019-02-13 16:04:06 +05:30
Rushabh Mehta
41d90fa6d1 BREAKING CHANGE: Comments are now handled separately from Communication and Version 2019-02-07 16:35:50 +05:30
Sagar Vora
89efa968d8 Merge branch 'master' into develop 2019-02-05 18:39:43 +05:30
Chinmay Pai
9373125c0a fix(reportview): cast docname to string (#6876)
* fix(reportview): cast docname to string

explicitly cast docnames to string to fix sorting in reportview.py:217

Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>

* fix: codacy changes

i hate codacy.

* fix(reportview): remove redundant safe_decode call
2019-02-05 10:52:54 +05:30
Sagar Vora
ef82f39f99 Merge branch 'staging' into develop 2019-01-29 18:24:11 +05:30
Zarrar
d8187a3f9d fix: unicode character throws error for python 2 (#6822) 2019-01-25 10:24:40 +05:30
Aditya Hase
6b72faf44f style: Linting fixes (#6809)
* style: Remove unused imports

* style: Remove unused local variables
2019-01-23 16:39:55 +05:30
Saurabh
d1bed88f3f Merge branch 'staging' into develop 2019-01-15 19:14:06 +05:30
Aditya Hase
220ac9a137 fix(list-view): Cast docnames to str before sorting (#6766)
In Python 3 str and non-str comparison is not allowed.

Bulk delete operation fails when selected docnames meet following condition
1. at least on name can be casted to int or other types e.g. "1", "3123423524", "1.0"
2. at least on name that cannot be casted to other types e.g. "A", "56cd83dab1"

The root cause is $.data() which forcefully casts data-name to non string types when possible
2019-01-14 16:44:54 +05:30
Ameya Shenoy
c5d276b813
Merge branch 'staging' into develop 2018-11-28 08:24:00 +00:00
Ameya Shenoy
f513739d1a
Merge branch 'master' into staging-fixes 2018-11-28 07:53:35 +00:00
rohitwaghchaure
7195cfd03c fix: KeyError: '_comment_count'(#6549) 2018-11-28 09:01:18 +05:30
Himanshu Mishra
e53c72a627 added @read_only to a few calls and converted a few read only calls to GET (#6299) 2018-10-30 11:13:25 +05:30