Commit graph

8 commits

Author SHA1 Message Date
Ankush Menat
144880bfb1
ci: make semgrep check diff-aware 2021-07-16 12:00:30 +05:30
Ankush Menat
889e8aacb7
ci(semgrep): false +ve translation on templates
separated JS and python rules for granuarilty.

Ignore matches with microtemplating that have this structure: `{{.*_.*}}` in string.
2021-05-25 12:53:37 +05:30
Ankush Menat
4d7f5a8f8d
ci: fix semgrep false positives (#13161)
* ci: fix false positive rule for split js translate

- limit regex to must match end of line.
- expand previous check to take care of other ways to split multi-line
  calls.

* ci: update tests for rules, ignore rules in sider

* ci: enable semgrep on v13 branches

* ci: fix false positive for python split strings
2021-05-12 20:22:48 +05:30
Leela vadlamudi
3875004d7e
Merge pull request #13057 from leela/email-refactoring
refactor: Email Module - 1
2021-05-05 11:45:04 +05:30
leela
0a1902e650 fix: semgrep's split translation regex 2021-05-03 06:25:57 +05:30
Ankush Menat
5881c5dbec
ci(semgrep): add more rules, r/python.correctness (#12876)
* ci(semgrep): add more rules, r/python.correctness

- Added file for defining rules as per frappe data model:
frappe_correctness.yml
- Add rule for SQLi, with WARNING only for now
- Add rule file for UX
- WARNING | INFO do not fail the build now

* ci(semgrep): on_cancel, on_submit correctness rule

* ci(semgrep): split workflow in steps

* ci(semgrep): catch line breaks in _()

* chore: fix sider issue
2021-04-23 09:04:34 +05:30
Ankush Menat
cee30d2fa7
ci: ignore safe_eval paths 2021-03-23 18:24:01 +05:30
Ankush Menat
d7bc848a52
test(semgrep): python and javascript translation
- Move rules to .github folder to reduce clutter in root folder
- separate out rules
- add tests for rules
- docs for writing more rules
2021-03-13 18:22:48 +05:30