Commit graph

5430 commits

Author SHA1 Message Date
Ankush Menat
cd189b3f7f fix: remove link - modifying while iterating 2023-11-21 12:01:55 +05:30
Ankush Menat
d715b0ad31
Merge pull request #22804 from akhilnarang/non-nullable-fields
feat: allow setting fields as not nullable
2023-11-20 12:46:02 +05:30
Akhil Narang
eb45da3913
feat: Allow usage of print() within safe_exec() (#23084)
* feat(safe_exec): allow usage of `print()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* refactor(system_console): update description to mention `print()` instead of `log()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* feat: unconditionally add debug logs to response if present

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* chore(safe_exec): add in a test for running `print()` within safe_exec

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix(safe_exec): ignore warning

RestrictedPython warns us if we call `print()` don't use their `printed` variable

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* feat: store debug logs from scheduled jobs

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* fix: avoid ignoring warnings, disabled in prod anyway

* chore: remove unnecessary logging

This can be moved to level 2 when required

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-20 12:45:41 +05:30
Akhil Narang
7d3295f09e
fix(doctype): update query was broken
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
5a4053fe2c
chore: make use of non_nullable to avoid ifnull usage
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:57 +05:30
Akhil Narang
0026a6ceac
feat(docfield): add in a nullable checkbox field
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 14:51:55 +05:30
Shariq Ansari
8cbe919696 fix: add submit role to system manager if doctype is submittable 2023-11-16 11:16:53 +05:30
RitvikSardana
0c4245634f
feat: Apply Filters to Link Fields Via Form Builder (#22844)
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-15 11:34:19 +05:30
barredterra
0911299ace test: mark as spam 2023-11-15 01:05:40 +01:00
barredterra
1aea320dfe refactor: mark as spam 2023-11-15 01:05:32 +01:00
barredterra
73a0ed9f15 fix: set status last 2023-11-15 00:44:22 +01:00
barredterra
6e753cf118 refactor: deduplication logic 2023-11-15 00:33:19 +01:00
barredterra
46a34e25e8 test: parse links in email 2023-11-15 00:01:13 +01:00
barredterra
329531bf6e feat: link communication by email 2023-11-14 23:27:27 +01:00
barredterra
2507c6af97 fix: check the correct email account 2023-11-14 23:25:34 +01:00
barredterra
02e3e23b4c refactor: email linking 2023-11-14 23:24:36 +01:00
mergify[bot]
b8d1ede3d7
Merge pull request #23161 from TMF42/fix--incorrect-date-range-when-relinking-documents
fix: incorrect date range when relinking files
2023-11-12 14:28:40 +00:00
Suraj Shetty
8dd73998b1
Merge pull request #23149 from git-avc/fix-docfield-columns-description 2023-11-12 07:54:56 +05:30
Ankush Menat
dd86c48306 fix: Ignore None returned by RQ job
Even though type signature suggests that it always returns job object it
sometimes doesn't if you read the code.
2023-11-09 20:25:03 +05:30
Thomas Fojan
df026366df fix: incorrect date range when relinking files 2023-11-08 21:23:25 +01:00
avazquez@ctgalega.com
9baf5e6de4 fix: typo accuracy 2023-11-08 00:38:16 +01:00
avazquez@ctgalega.com
268c851f85 fix: description for columns property in docfield 2023-11-08 00:29:46 +01:00
Ankush Menat
47c3151662
fix: remove data import legacy leftover fields (#23113)
* fix: clear last message if ignoring DNE

* fix: attempt to delete data import legacy leftover fields
2023-11-06 19:18:39 +05:30
Suraj Shetty
e3d536659e
Merge pull request #22684 from GursheenK/audit-trail-filters 2023-11-06 17:12:45 +05:30
barredterra
dd5bb0ff46 fix: allow page deletion during migrate 2023-11-03 22:03:27 +01:00
Ankush Menat
2ab8c2a053
refactor: misc changes (#23082)
- Fail early for developer mode
- Convert delete content function to method
- do io after db transaction commits
- write a test
2023-11-03 07:27:34 +00:00
Vishnu VS
ae7a893100
feat: granted delete permission and added folder deletion function for pages (#23077)
* fix: grant delete permission to administrator

* feat: added function to delete folder associated with the  page
2023-11-03 12:34:07 +05:30
Raffael Meyer
f0155674a5
refactor!: remove redundant sending of translations (#22962)
* chore!: remove redundant translation

* refactor!: remove "get_translated_dict" hook

Instead, include the results from
`frappe.geo.country_info.get_translated_dict` in `get_all_translations`.

* test: money_in_words uses translated currency

... and now we have translations.

* Revert "test: money_in_words uses translated currency"

This reverts commit e07d594ac1ce4b120c0fceb5d23377cb981fe820.

* refactor!: stop translating timezone and currency

* refactor: rename `get_translated_dict`

... to `get_translated_countries`
2023-11-02 20:04:14 +05:30
Gursheen Anand
0098ec637f fix: change btn label 2023-11-02 15:27:51 +05:30
Gursheen Anand
0126fefdf0 fix: set filters in refresh 2023-11-02 15:26:00 +05:30
Shariq Ansari
45236a98d7
Merge pull request #22968 from shariquerik/form-builder-ui-refactor 2023-11-01 19:14:56 +05:30
Shariq Ansari
0bfe196d0c chore: keep fields table in settings tab at last
if you need to add multiple fields by copy paste from excel
2023-11-01 16:49:08 +05:30
Shariq Ansari
2522d6bfab fix: added is_tree & virtual doctype checkbox in new doctype dialog 2023-11-01 00:33:04 +05:30
Ankush Menat
6062eec0d6 fix(recorder): Always enable sortable 2023-10-31 15:03:11 +05:30
Ankush Menat
55da69ad50 perf: Make amended_from indexed by default
This is checked before every cancellation, so it makes sense to index it.

Not touching any existing records *for now*.
2023-10-31 15:03:11 +05:30
Gursheen Anand
2648535eae feat: set filters when routed from transaction 2023-10-31 13:53:59 +05:30
Gursheen Anand
e624c04125 fix: filter query for non mandatory filters 2023-10-31 13:50:03 +05:30
Gursheen Anand
fe3046a1c5 fix: remove validation for date filters 2023-10-31 13:37:19 +05:30
Gursheen Anand
bc693edc4e fix: make date range filters optional 2023-10-31 13:36:31 +05:30
Shariq Ansari
748ffbe4e4 chore: merge Details & Settings tab into Settings tab 2023-10-31 11:55:03 +05:30
Shariq Ansari
0e397d6f6a fix: minor fixes 2023-10-31 11:50:56 +05:30
Shariq Ansari
787515bf89 chore: add a boilerplate section on creating new doctype 2023-10-31 02:14:54 +05:30
Akhil Narang
6418320d61
fix: directly assign return value (#23007)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-30 21:37:42 +05:30
Kevin Shenk
0c0fbc4248
fix: skip invalid numbers on SMS receiver_list (#22879)
This PR switches the loop in the `validate_receiver_nos` function in the SMS Settings Doctype from `break` to `continue`.

The prior functionality would throw an error if any recipients on the receiver_list were invalid, which created an issue with SMS notifications that send to a user role, since any user without a valid mobile phone number would prevent the notification sending to any users (even those with valid mobile numbers).

By switching the loop from `break` to `continue`, the function still eliminates invalid entries and enforces the existence of at least one valid phone number, but doesn't break sending based on a single absent or invalid recipient entry.

[skip ci]
2023-10-30 18:47:14 +05:30
Akhil Narang
c4544e8989
perf: query fields only once (#22982)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>

[skip ci]
2023-10-30 17:20:32 +05:30
Ankush Menat
5fe80d3f34 chore: bump default session expiry to 7 days 2023-10-30 14:30:15 +05:30
Shariq Ansari
2799700455 fix: open new doctype dailog on /new-doctype-1 2023-10-30 14:09:20 +05:30
Shariq Ansari
8ca4501f7e fix: if Form tab is active hide comments & form message 2023-10-30 13:27:16 +05:30
Shariq Ansari
3407a9963e chore: hide fields table 2023-10-30 12:29:06 +05:30
Shariq Ansari
8b5dffff98 chore: made form tab as a first tab in doctype form 2023-10-30 12:24:08 +05:30