vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
44192 commits 1 branch 0 tags 587 MiB
Commit graph

188 commits

Author SHA1 Message Date
Ankush Menat
d715b0ad31
Merge pull request #22804 from akhilnarang/non-nullable-fields 
feat: allow setting fields as not nullable
 2023-11-20 12:46:02 +05:30
Akhil Narang
ae9ae40bad
Merge pull request #23168 from blaggacao/refactor/centralize-python-shell-interface-for-database-binaries 
refactor: give cli invocations of dbtools a dedicated interface
 2023-11-17 17:02:41 +05:30
Akhil Narang
5598fe241e
fix: use default default if a custom default isn't specified 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
558ac413ce
fix(mariadb/schema): use correct default value 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
8d540963c8
refactor(mariadb/schema): use sql_ddl() method 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
ccc2bdad52
fix: go back to original transaction handling mechanism 
This reverts the following:
07acfeed47 chore: move check_implicit_commit() call back to its original location
fc38a0b503 chore: simplify transaction handling
1e29e81543 chore: rework implicit commit checks
ae0a3fd202 feat: allow ignoring implicit commit warning

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
4855ec76c2
chore: use index to access table column instead of getattr 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
806748b063
chore: simplify transaction handling 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
fe549ecc49
chore: don't check for semgrep here 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
58b8b26b93
chore(mariadb): switch to using query builder for update statement 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
Akhil Narang
e41fa2dfc7
feat: migrate columns to be non-nullable if required 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 14:51:57 +05:30
David Arnold
0dc2a9c2f3
refactor: normalize function signature 2023-11-10 15:12:59 +01:00
David Arnold
b2f9ff09aa
feat(db): boostrap only option if resource management is exogenous 
The database resource management including privileges granting can be
done by external secops. It can be undesirable to grant the grant option
to the framework user.

This commit implements the possibility to remove user resource
management from frappe entirely and only boostrap the database with its
target user.
 2023-11-09 17:11:39 +01:00
David Arnold
40a2daf84c
chore: give cli invocations of dbtools a dedicated interface 2023-11-09 12:14:41 +01:00
Ankush Menat
0d5f28d569 feat: rename custom field 2023-09-25 12:25:28 +05:30
Sagar Vora
7e9b08a040 fix: convert value column to longtext for Singles 2023-09-06 16:23:01 +05:30
Ankush Menat
730e906dfd
refactor!: remove implicit primary key from logs (#22209) 2023-08-26 16:01:47 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend 
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
 2023-08-09 13:25:39 +02:00
David Arnold
a926e64ec9
fix: procure db config from single authority (#21578) 
* fix: procure db config from single authority

ensures that configuration is uniformely procured from local.conf
instead of making use of hard to audit multilevel fallback logic

Implementation Note:
- `get_db(host, port, user, password)` was stripped of any optional
  argument and therefrom all errors where fixed.
- All occurances of `grep 'frappe.db.db_'` where changed to
  `frappe.conf.db_`

* fix: revert unnecessary breaking changes
 2023-07-24 10:48:29 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ankush Menat
4104e7d733
feat: show db table utilization on doctype (#21193) 
* feat: show db table utilization on doctype

* fix: nicer error message with docs
 2023-05-31 16:28:44 +05:30
Ankush Menat
48539dc0a3
feat: log all DDL queries (#21107) 2023-05-31 16:00:59 +05:30
Ritwik Puri
d099c9376b
feat(minor): db.get_column_type for postgres (#21125) 2023-05-26 16:03:28 +05:30
Ankush Menat
024faff025
build: bump pymysql (#20478) 
Actual fix for this bandaid fix: https://github.com/frappe/frappe/pull/20475

Keeping pymysql hard pinned until we have better way to get last full
query.
 2023-03-28 13:04:27 +05:30
Ankush Menat
dad0e5cbba fix: drop table if exists for action and links 
closes https://github.com/frappe/frappe/issues/19712
 2023-02-01 22:37:43 +05:30
Sagar Vora
db9b25ec0e
fix(MariaDBTable): dont attempt to drop index twice (#19783) 2023-01-27 09:27:11 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
894f0affcc
fix(DX): Print alter query if it fails during migration (#19552) 2023-01-10 16:55:29 +05:30
Ankush Menat
95039a1265
fix: db ssl connection (#19308) 
ref: https://pymysql.readthedocs.io/en/latest/modules/connections.html

[skip ci]
 2022-12-19 11:21:15 +05:30
Ankush Menat
8df845ca35 fix: duplicate unique index when column is altered 2022-12-15 13:36:28 +05:30
Sagar Vora
4ea39d1a68
chore!: drop device support from session (#18729) 
* chore!: drop device support from session

* chore: remove `session_expiry_mobile` field

* fix: remove extra `%s`
 2022-12-05 16:37:32 +05:30
Ankush Menat
186b88a8cb
build: Bump minimum required MariaDB version (#19116) 2022-12-05 16:24:35 +05:30
Ankush Menat
9c104a8e5e fix: Warn about incompatible mariadb versions 2022-12-03 12:20:35 +05:30
Ankush Menat
11cdd21b88 fix: drop mariadb 10.2 checks 2022-12-03 12:20:35 +05:30
Ankush Menat
263055e247
fix: site creation using non-root users (#19014) 2022-11-26 12:45:57 +05:30
Ankush Menat
ce360b6fce feat: Set default SQL statement timeouts 2022-11-08 14:51:43 +05:30
Ankush Menat
8cca50bf26
refactor: remove naming case feature (#18672) 
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
  naming because `name_case` is selected in some doctypes (but never
  tested)
 2022-10-31 11:23:49 +05:30
Ritwik Puri
dad080842a
fix: don't print multiple print statements when database settings dont match with expected settings (#18492) 
Also, fetch mariadb variables only once when checking mariadb variables
 2022-10-22 21:55:12 +05:30
Ankush Menat
da561c237d fix: index column should be first 2022-10-06 11:11:03 +05:30
Ankush Menat
cbe4b59100 fix: correct index re-syncing 
The implementation of syncing unique and non-unique index depended on
index names which used to be different before because of that there's
tendency to incorrectly identify index.

This PR adds a separate util for checking if a column has index without
relying on naming convention. It just goes and checks if there's any
index with that column in it, hence far more reliable.
 2022-10-06 11:11:03 +05:30
Ankush Menat
6de41a78e9 refactor: guard clause 2022-10-06 11:11:03 +05:30
Ankush Menat
82cd238f54
perf!: Only add modified index on parent doctypes (#18119) 
When are child tables sorted by timestamp by default?
 2022-09-15 19:16:12 +05:30
Ankush Menat
f96505fae0 feat: wrap read only mode SQL errors 2022-09-09 17:34:44 +05:30
Himanshu
3faaf5f361
Merge branch 'develop' into merge_translated_doctypes 2022-08-12 13:10:49 +01:00
Gavin D'souza
91a47c2602 fix: Deprecate setup help database APIs 
APIs have been unused since ~v4/6? Don't see any need to keep them in.
 2022-08-12 12:52:19 +05:30
Himanshu
e68aac866f
Merge branch 'develop' into merge_translated_doctypes 2022-08-10 18:49:04 +01:00
Gavin D'souza
b13298d69c fix(db): Log mogrified queries 
Prior to this, queries passed to `frappe.db.sql` with values looked like:

"SELECT `defkey`,`defvalue` FROM `tabDefaultValue` WHERE `parent`=%(param1)s ORDER BY `creation`"

Now, they'll look "normal" or built like:

"SELECT `defkey`,`defvalue` FROM `tabDefaultValue` WHERE `parent`='__global' ORDER BY `creation`"
 2022-08-10 18:31:44 +05:30
hrwx
b01929405d refactor: translatable doctypes 2022-08-05 21:38:10 +01:00
Ritwik Puri
cb6438158b
fix: don't use cache for sequence in mariadb (#17640) 
* fix: don't use cache for sequence in mariadb

* chore: update sequence related comments
 2022-07-27 22:46:56 +05:30
Gavin D'souza
2bef29bb46 chore: Deprecate backup script + minor refactors 2022-07-22 13:21:29 +05:30