vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
44192 commits 1 branch 0 tags 587 MiB
Commit graph

1508 commits

Author SHA1 Message Date
Shariq Ansari
a14966c980
Merge pull request #22595 from blaggacao/fix/non-html-notifications-rendered-from-files 2023-11-18 21:06:12 +05:30
David Arnold
90b076a75a
feat(notification): specify message type (html, md, txt) 2023-11-17 15:00:12 +01:00
mergify[bot]
443d508669
Merge pull request #22884 from zeel-codder/fix-email-message-email-group 
fix: use the use_html check in the Email Group
 2023-11-17 06:17:17 +00:00
Akhil Narang
50129d3220
refactor(email_group): simplify logic to figure out which response to use 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-16 18:01:33 +05:30
Maharshi Patel
0b4f06c325
fix: remove quotes from IMAP Folder Name (#23242) 
Quotes were added around folder name as spaces would cause issue with IMAP.

This extra quotes are also passed to query which sets the
uidnext and uidvalidity. where condition is never met

This values are used on subsequent pulls and without this values,
it is considered first pull and all UNSEEN mails are synced.

So even If user selected All in sync option it will always work as UNSEEN
option.

When UNSEEN is used it will mark all emails as seen on IMAP server when pulled.
 2023-11-16 17:36:39 +05:30
David Arnold
77b1d58428
Merge remote-tracking branch 'upstream/develop' into fix/non-html-notifications-rendered-from-files 2023-11-13 10:00:49 +01:00
David Arnold
fe8cc7a5c2
fix: non-html notifications from files 2023-11-09 09:51:39 +01:00
Ankush Menat
e14349d656 fix: newsletter indicator filters 
strings are all truthy.

closes https://github.com/frappe/frappe/issues/23107
 2023-11-07 20:10:48 +05:30
Ankush Menat
3905e8970a test: smtp integration test using smtp4dev 2023-11-04 15:26:40 +05:30
Ankush Menat
3211a77dc8 fix: handle emails sent from console 2023-11-04 14:30:37 +05:30
Ankush Menat
089985e53b feat: frappe.job local for reading job info 2023-11-04 14:06:31 +05:30
Ankush Menat
ecca32853e test: ensure that same smtpserver is being reused 2023-11-04 13:53:08 +05:30
Ankush Menat
0362de82bb fix: Mark fake site config emali account with internal attribute 2023-11-04 13:41:18 +05:30
Ankush Menat
a4382fda5a fix: Automatically close SMTP connections on exit 2023-11-04 11:51:42 +05:30
Ankush Menat
d5d0dfb58b perf: Reuse SMTP connection when flushing email queue 
This depends on https://github.com/frappe/frappe/pull/23070
 2023-11-04 11:32:48 +05:30
Ankush Menat
4e318a0280 fix: Abort flushing email queue if >50% fail. 
When email queue batch failes >33% with >10 count, frappe will now abort
sending emails.

We already notify users via system notification so this
assumes that user will notice it and fix it in sometime.

With previous commits we also prioritize fresh emails over retries.
 2023-11-04 11:25:09 +05:30
Ankush Menat
050c0b26f8 fix: flush emails from single background jobs 2023-11-04 11:23:44 +05:30
Ankush Menat
be2beeed9e
fix: improve email queue reliability (#23070) 
* feat: control email queue batch size with config

* fix: Give emails who failed once less priority while sending
 2023-11-03 15:10:37 +05:30
Ankush Menat
60e6fb005e
fix: Show excat OSError when creating SMTP session (#23067) 2023-11-02 17:23:19 +05:30
Kevin Shenk
ca3ecc2da7
fix: Strip HTML tags from SMS Notifications (#22880) 2023-10-30 18:34:35 +05:30
zeel-codder
79b67a4b83 fix: Update email_message in the send_welcome_email function to use the use_html check for Email Template 2023-10-24 13:51:12 +05:30
Ankush Menat
a930872fd6
fix: pass default SSL context for imap/poplib (#22873) 2023-10-23 16:51:15 +05:30
Ankush Menat
135fb6a486 chore: remove py2 compatibilty code 2023-10-21 13:40:04 +05:30
Ankush Menat
bdc5aba7ad
refactor: Use client.set_value instead of db.set_value (#22814) 2023-10-19 13:07:37 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages 
Also avoid accessing locals where interface is present like for popping last message.
 2023-10-16 18:13:50 +05:30
Sayed Ayman
94263bf4f2
feat (notificaion): email from 'Table Multiselect' field (#22733) 
* feat (notificaion): table multiselect field

* refactor: use model.table_fields instead of duplicating

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-10-16 12:02:19 +05:30
Akhil Narang
41d524c9a0
chore: add in a test for failed email notification 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-13 18:16:32 +05:30
Ankush Menat
e72b03adaf refactor: handle notification failure 2023-10-13 14:59:00 +05:30
Akhil Narang
65d6c20d9e
feat: send out a system notification when email sending + retries fail 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-10-12 13:34:50 +05:30
Saif Ur Rehman
24206de0d0
fix(Email Inline Embed): Unescape embed path (#22291) 2023-10-11 13:47:27 +05:30
Ankush Menat
908ddad962
Merge pull request #22515 from ankush/email_rec 
fix: handle poorly encoded from emails
 2023-09-23 12:13:57 +05:30
Ankush Menat
f974fcabac fix: ignore poorly encoded email parts 2023-09-23 11:53:05 +05:30
Ankush Menat
59d1eefa61 refactor: move unhandled email to log settings 2023-09-23 11:23:53 +05:30
Ankush Menat
aa413e8c9f
fix: link notification messages with communication (#22507) 2023-09-22 17:06:47 +05:30
mergify[bot]
69b0fcf06e
Merge pull request #22316 from cogk/fix-email-subject-decode 
fix: Fix email subject decoding
 2023-09-20 09:41:59 +00:00
Ankush Menat
88896f8f41 fix: keep localhost for smtp checks 2023-09-13 17:06:28 +05:30
0xsaif
aa7ee1c6b9
refactor: force ipv4 localhost (#22394) 
* reafctor: force ipv4 localhost

Replacing "localhost" with "127.0.0.1" in the codebase; sometimes the name localhost force-resolves to ipv6

* revert: leave localhost usage in oauth tests

Change not required.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-09-13 16:23:23 +05:30
David Arnold
734fb891c2
chore: monkey patching {imap,pop}lib is no more necessary since 4 years 
see: 13a7ee8d62
 2023-09-07 01:12:55 +02:00
Corentin Forler
a4a3af5859 refactor(email): Ensure that subject is a string 2023-09-05 14:10:06 +02:00
Corentin Forler
e5dd924cbe fix(email): Add missing byte-decoding in set_subject 2023-09-05 14:10:06 +02:00
Corentin Forler
ec20739fee test(email): Add test for accents in subject header 2023-09-05 14:10:05 +02:00
Ankush Menat
e88cdb6e70
Merge pull request #22224 from ankush/desk_user 
feat: `Desk User` role
 2023-08-29 20:27:21 +05:30
niraj gautam
dff426a267
fix: Do not allow newsletter scheduling with past date (#22204) 
* fix: newsletter scheduling

* fix: Add required prop on schedule dialog

* refactor: Add validation in newsletter.py

* test: fix scheduled newsletter test

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-08-29 06:49:52 +00:00
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Ritwik Puri
32a59e19a6
docs: email architecture (#22189) 
* docs: email architecture

* chore: remove marking emails as read dead code from EmailAccount controller
 2023-08-26 11:22:46 +05:30
Saif Ur Rehman
da75b00c8c
fix(Email Inline Embed): escape regex expression 2023-08-25 11:29:58 +05:00
Raffael Meyer
6ea739e4cf
refactor(File): explicitly import utils (#22143) 2023-08-23 11:08:22 +05:30
Suraj Shetty
15bbe03d43 fix: Support dynamic filter for Reports w/o js config 2023-08-11 12:38:41 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend 
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
 2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable 
Inline a variable to a return in the case when the
variable being declared is immediately returned
 2023-08-08 18:09:49 +02:00