Commit graph

908 commits

Author SHA1 Message Date
Ankush Menat
3e95c00fd0
fix: dont track webhook request log (#20663)
logs dont change

[skip ci]
2023-04-12 11:51:24 +05:30
Mohammad Hussain Nagaria
a48b0f3cf8
fix: minor oauth doctypes enhancements (#20613)
* fix: remove extra`/` from description

* fix(ux): show bearer token status in list view
2023-04-07 14:33:41 +05:30
phot0n
e032a5b69b fix: add back dropbox access token
reason: https://www.dropboxforum.com/t5/Dropbox-API-Support-Feedback/Long-lived-access-token-deprecation/m-p/630471/highlight/true\#M29128
2023-03-20 17:48:21 +05:30
phot0n
7445843bc2 refactor: remove dropbox_access_key and dropbox_access_secret fields
from dropbox settings
2023-03-20 14:17:48 +05:30
phot0n
14105e0816 fix: refresh access token for dropbox
- removed dropbox_access_token field
- added dropbox_refresh_token
- removed oauth2 access token generation from oauth1 logic
- removed code for dropbox_erpnext_broker

Auth logic has been changed a bit to generate access token(s) on the fly when taking backup from refresh token. This is due to the fact that backups are generally taken between long intervals which is generally greater than the access token expiry time.
2023-03-20 14:17:48 +05:30
Ankush Menat
cad9228b6b feat: clear integration log request logs (#20373)
* fix: integration request should be cleared

THese are basically logs of requests and shouldn't stay forever.

* fix(UX): show retention policy message on sidebar

These doctypes were added to log settings later.
2023-03-17 14:38:26 +05:30
Ritwik Puri
41685ff014
fix: dont use get_datetime for enddate when startdate is in future for google calendar event (#20309) 2023-03-13 15:20:57 +05:30
barredterra
b2e36634d6 refactor: rename get_time_zone to get_system_timezone 2023-03-04 19:30:03 +01:00
Ritwik Puri
b17af2c329
fix: token cache expiry calculation (#20228) 2023-03-02 23:23:36 +05:30
Ankush Menat
6022705093
fix: log raw text reponse instead of parsing JSON (#20226)
Not every service responds in JSON, we shouldn't expect a JSON response.

[Skip ci]
2023-03-02 16:59:29 +05:30
Ankush Menat
34beb65009
fix: link webhook logs with webhook document (#20155) 2023-02-24 16:30:29 +05:30
Jannat Patel
19249aec4e
fix: send updates from google calendar events (#20075) 2023-02-23 18:10:08 +05:30
Ankush Menat
22f5a60ebb feat: make webhook requests log clearable 2023-02-23 15:56:13 +05:30
Ankush Menat
1fbd6badd1 fix: log full traceback 2023-02-23 15:56:06 +05:30
Ankush Menat
e6d5f1fe2e revert: engine change 2023-02-23 15:56:06 +05:30
Deepesh Garg
66ef29907f chore: Better webhook loging 2023-02-23 15:56:06 +05:30
RJPvT
8be98718f7
fix: ldap with 2fa (#19753)
Because we pop password 2fa fails when used with ldap

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-01-30 14:44:53 +05:30
Shariq Ansari
b4ff826711 fix: default_user_type should be Website User if not set 2023-01-24 18:30:51 +05:30
Shariq Ansari
0173d2abfb test: fixed failing LDAP test 2023-01-24 17:56:10 +05:30
Shariq Ansari
229ca404ae fix: LDAP - default user role mandatory logic broken 2023-01-24 11:22:05 +05:30
Suraj Shetty
f9496ff7e5
fix: Initialize "r" to avoid UnboundLocalError (#19630)
fixes https://github.com/frappe/frappe/issues/19608
2023-01-17 18:29:07 +05:30
Ritwik Puri
1e6086fd75
fix(minor): only show authorization message if connected app is set (#19605) 2023-01-16 16:22:38 +05:30
Ritwik Puri
50327203ce
Merge pull request #18750 from revant/oauth-email
feat: use Connected App for OAuth based Email Account
2023-01-16 15:24:05 +05:30
phot0n
88d4d5e10d chore: minor cleanup - removed unnecessary branches and comments 2023-01-15 21:02:21 +05:30
phot0n
c2ceceea6e fix: use OAUTHLIB_RELAX_TOKEN_SCOPE for ignoring scope change
without this we get an error regarding the mismatch of scopes from microsoft
2023-01-15 21:02:21 +05:30
Ankush Menat
266b9a05e1
docs: clarify what s3 endpoint does (#19566)
Endpoint is used for calling non-AWS s3 compatible backends. You dont
need to fiddle with this for AWS S3.

[skip ci]
2023-01-11 15:43:24 +05:30
Gughan Ravikumar
4654db6e26
fix: use file name for backups to Google Drive (#19504)
Currently, backups to Google Drive are uploaded with the absolute path as the filenames. This fix changes that.

[skip ci]
2023-01-06 17:06:51 +05:30
phot0n
481d72c0ae fix: only pull from email accoutns which have token
* removed unnecessary after_save client hook from email account
* renamed check_active_token -> has_token (no need to refresh the access token)
* removed oauthentication error from email oauth - now just a simple validation error
2023-01-06 13:07:13 +05:30
Ritwik Puri
b78452dc00
Merge pull request #19472 from ankush/set_value_bad
refactor: deprecate usage of set_value with None as docname
2023-01-04 11:44:57 +05:30
Ankush Menat
e00023deb1 refactor: replace bad usage of db.set_value 2023-01-04 11:13:53 +05:30
phot0n
6bed904bf7 fix: only validate oauth if tokens are set
* also brough back oauth authorization message
2023-01-03 18:05:49 +05:30
phot0n
f50be4bbf5 chore: log any exception while refreshing access token in connected apps 2023-01-01 23:52:33 +05:30
phot0n
52daef0dfd fix: get_expires_in logic for token cache 2023-01-01 22:43:33 +05:30
phot0n
9d6f82725e chore: remove tracking changes for token cache
happens very frequently for email and leads to unnecessary bloat in version doctype
plus token caches are only read and delete only
2023-01-01 21:22:36 +05:30
phot0n
231d90cb40 chore: handle get requests via frappe.whitelist decorator 2022-12-29 18:44:53 +05:30
phot0n
ca8842861a refactor(minor): simplify check_active_token 2022-12-29 17:03:16 +05:30
phot0n
f0a17d7adb fix: make connected app work with email account
* removed (now) unnecessary things from oauth class
* simplified get_active_token in connected_app
* removed gmail banner from email account docs
2022-12-28 14:58:19 +05:30
Revant Nandgaonkar
f79185d79c feat: use Connected App for OAuth based Email Account 2022-12-28 14:51:10 +05:30
Gavin D'souza
d13c377848 refactor: OAuth
* Added typing hints for Oauth APIs and dependant utils
* Simplify oauth core flows
* Remove long commented code
* Use newer, simpler syntax for better readability
2022-12-27 19:25:43 +05:30
Shariq Ansari
86dc33c1f1 fix: LDAP - check each email in list before creating user 2022-12-05 22:14:51 +05:30
barredterra
6e5ab01f21 fix: only System Manager can access Google Drive 2022-12-04 15:57:01 +01:00
PeterG
3676188083
fix: google calendar sync times (system tz) (#18458)
* fix: google calendar sync times (system tz)

* added line breaks to excessively long bit

* (chore) linter appeasement

* chore: linting

[skip ci]
2022-10-19 10:39:43 +05:30
Anoop
c44e278fed
feat: add video conferencing option (Google Meet) to Google Calendar integration (#17851)
* feat: add video conferencing (via google meet) for events syncing with google calendar

* fix: unset add_video_conferencing if sync_with_google_calendar not enabled

* fix: remove conference data if add_video_conferencing disabled during update

* fix: restrict add conferencing if event_category in Event, Meeting and Other

* fix: save meet link while pulling from calendar
updated response API Response comment with conference details
show google calendar section if pulled from google calendar

* feat: show link to join video conference with google meet

* fix(style): linter errors

* fix(style): linter errors

* fix: set conferenceDataVersion 1 only if google meet conferencing enabled
remove google meet link from event needs both conferenceData as null and conferenceDataVersion 1

* Update frappe/desk/doctype/event/event.py

show add_video_conferencing for events of all categories

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* Update frappe/desk/doctype/event/event.json

show add_video_conferencing for events of all categories

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: handle empty ends_on, use starts_on

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: do not update Event modified time on db set meet link

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>

* fix: add email field event participants table
set email from linked contact
google calendar event to use event participant email as attendees

* fix: attendees not cleared from google calendar event

* fix(style): linter suggestions

* fix: make email field non-read only, called set_participants_email from before_save hook

* test: update new no of fields in event doctype in test_fetch_to_customize

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-10-18 19:07:48 +05:30
PeterG
77ae997b14
fix: google calendar sync times (#18384) 2022-10-12 15:23:04 +05:30
Kitti U. @ Ecosoft
a35880a089
docs: misleading docstring #18051
Wrong instruction for Redirect URL
2022-09-07 18:03:19 +05:30
Aradhya Tripathi
caf171b363
Merge branch 'develop' into get-all-mod 2022-08-22 14:53:35 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Aradhya Tripathi
e73ae6f039
Merge branch 'develop' into get-all-mod 2022-08-19 15:42:35 +05:30
Ankush Menat
b2b0b64d8c
refactor: add default to pop
[skip ci]

Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-08-18 18:34:52 +05:30
Ankush Menat
f2b6c937c9 fix: pop pwd from form dict, disable auth loggin
- This prevents accidental logging of this info somewhere down the line.
- Disable exception logging for auth failures
2022-08-18 15:32:42 +05:30