Commit graph

87 commits

Author SHA1 Message Date
Himanshu
0e7123d141 fix(Addresses and Contacts Report): Frappe throw when no record present (#7504) 2019-05-21 14:50:49 +05:30
Shivam Mishra
41fa47af62 style: moved set_link_title to address_and_contact 2019-05-14 16:08:01 +05:30
Shivam Mishra
cf7f86f6cc chore: code improvements 2019-05-07 15:22:12 +05:30
Shivam Mishra
c7a26af7a2 fix: link_title not getting set in address and contact 2019-05-06 15:12:33 +05:30
Nabin Hait
8c91e46563 Fixed merge conflict 2019-04-11 11:56:37 +05:30
Kenneth Sequeira
af46d5c845 add salutation to contact display 😁 2019-04-09 13:28:59 +05:30
Himanshu Warekar
293a924244 fix: make report py2 py3 compatible 2019-04-06 23:35:21 +05:30
Himanshu Warekar
5c3121ab84 fix: making it py2 and py3 compatible 2019-04-06 22:50:05 +05:30
Himanshu Warekar
b3359f5eb2 fix: code refactor 2019-04-06 21:53:09 +05:30
Himanshu Warekar
422a1e151b fix: test cases using assertListEqual 2019-04-05 16:00:16 +05:30
Himanshu Warekar
f06fa603d7 fix: test case 2019-04-05 15:22:55 +05:30
Himanshu Warekar
1b4550c503 fix: test case 2019-04-05 15:05:09 +05:30
Himanshu
c923a55924
fix: test case 2019-04-05 13:30:05 +05:30
Himanshu
14f63830ad
fix: test case 2019-04-05 13:29:07 +05:30
Himanshu Warekar
674bee4cde fix: fetch all contacts and addresses 2019-04-05 11:01:51 +05:30
Himanshu Warekar
1e03e88bb9 fix: test case fixes 2019-04-05 10:58:18 +05:30
Himanshu Warekar
0a2911aa3f fix: display all addresses and contacts 2019-03-29 12:25:16 +05:30
Faris Ansari
19c4f6086e fix: Remove cscript and cur_frm from all client scripts
- DocType
- Report
- Property Setter
- Newsletter
- Currency
- Contact
- Address and Contact
2019-03-20 17:29:43 +05:30
Saurabh
f638a500ae Merge branch 'master' into develop 2019-02-20 18:12:48 +05:30
Suraj Shetty
916612d526 Use get_doctypes_with_read instead of has_permission for multiple perm check 2019-02-18 10:18:55 +05:30
Sagar Vora
ef82f39f99 Merge branch 'staging' into develop 2019-01-29 18:24:11 +05:30
Aditya Hase
837bfc0995 fix(unicode): Import unicode_literals in every file (#6805)
* fix(unicode): Import unicode_literals in every file

* fix(unicode): Test if safe_json_loads return unicode instead of bytes
2019-01-25 11:56:27 +05:30
Rushabh Mehta
b66d233360 merge: staging-fixes for latest test fixes 2019-01-03 15:28:36 +05:30
Shivam Mishra
12798c9ee5 Fixed Addresses and Contacts Report (#6651)
* Fixed Addresses and Contacts Report

* minor change

* [Report Fix] Added test cases for Addresses and Contacts Report

* [Report Fix] Fixed a small typo 'Doctype' - 'DocType'

* [Report Fix] Fixed code formatting

* [Code Formatting] Removed unused variables

* [Code Formatting] Removed unused variable doc
2019-01-02 09:12:07 +05:30
Frappe Bot
8c58fdc71c Merge branch 'staging' into develop 2018-12-21 05:45:41 +00:00
Deepesh Garg
72e1ccc8f9 Changed modified timing to pickup changes (#6649)
* Changed modified timing to pickup changes

* Update address.json
2018-12-21 11:05:20 +05:30
Saurabh
b727233948 Merge branch 'staging' into develop 2018-12-13 10:37:25 +05:30
Prateeksha Singh
76386603a4 [setup] Address template message if setup complete 2018-12-11 16:10:02 +05:30
Frappe Bot
a60cb001f6 Merge branch 'staging' into develop 2018-12-10 13:05:59 +00:00
rohitwaghchaure
8c0fead00e feat: Added disabled field in the address (#6548) 2018-12-10 18:19:09 +05:30
Ameya Shenoy
06d9385829
Merge branch 'staging' into develop 2018-10-19 12:51:40 +00:00
Ameya Shenoy
b42a87746a
Merge branch 'master' into staging-fixes 2018-10-19 12:42:37 +00:00
Rohit Waghchaure
4db18698d5 [Fix] Report Addresses And Contacts not working 2018-10-17 15:46:25 +05:30
Ameya Shenoy
63c5613f92
Merge branch 'staging' into develop 2018-10-11 10:11:26 +00:00
Nabin Hait
56be85c934 User permissions patch fixes for skip-for-doctypes (#6229)
* fix(patch): Fixed skip_for_doctypes in User Permissions

* fix(address): Made address_title non-mandatory, because it is set based on links
2018-10-11 15:29:03 +05:30
Ameya Shenoy
387f556dd5
Merge branch 'staging' into develop 2018-10-04 11:41:29 +00:00
Shreya Shah
2dd66e6986 Fix Routing while adding address (#6171)
* Fix Routing while adding address

* Make similar fixes for Contact

* Commonify function

* Add method to an existing file
2018-10-02 11:11:06 +05:30
Charles-Henri Decultot
98abda32b4 [Enhancement] Event timeline (#6133)
* Events in timeline wip

* Events in timeline

* Permission issue + split buttons between Frappe and ERPNext

* Add string type check

* Codacy corrections

* Permission issue

* Test and feedback corrections

* Codacy corrections

* Tests and codacy corrections

* Codacy correction

* Py3 correction

* Travis correction

* Py3 corrections"

* Travis and codacy corrections

* Removed space

* Add check for the removal of new lines

* Codacy rollup watch missing semicolon
2018-10-02 10:12:55 +05:30
Suraj Shetty
e61c9ac40c Fix quote issues (#6143)
* Fix quotes issues

* Escape docname

* Avoid multiple escapes
2018-09-27 09:15:50 +05:30
Rushabh Mehta
2e6a202652 Postgres support for Frappe (#5919)
* [start] postgres

* [wip] started refactoring db_schema

* Add psycopg2 to requirements.txt

* Add support for Postgres SQL

- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP

* Remove quotes from sql to make it compatible with postgres as well

* Moved some code from db_schema to database.py

* Move code from db_schema to schema.py

Add other required refactoring

* Add schema chages

* Remove redundant code in file

* Add invalid column name exception class to exceptions.py

* Add back tick in query wherever needed and replace ifnull with coalesce

* Update get_column_description code in database.py file

* Remove a print statement

* Add keys to get on_duplicate query

* Add bactick wherever necessary

- Remove db_schema.py file

* Remove DATE_SUB as it is incompatible with postgres

- Fix prepare_filter_condition

* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors

* Add code to create key and unique index
- added mysql and posgres in their respective database.py

* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage

* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int

* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable

* Replace Database instance with get_db method

* Move db_manager to separate file

* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py

* Make fulltext search changes in global_search.py

* Add empty string check

* Add root_password to site config

* Create cli command for postgres console

* Move setup of help database to setup_db.py

* Add get_database_list method

* Fix exception handling
- Replace bad_field handler with missing_column handler

* Fix tests and sql queries

* Fix import error

* Fix typo db -> database

* Fix error with make_table in help.py

* Try test for postgres

* Remove pyhton 2.7 version to try postgres travis test

* Add test fixes

* Add db_type to the config of test_site_postgres

* Enable query debug to check the reason for travis fail

* Add backticks to check if the test passes

* Update travis.yml
- Add postgres addon

* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number

* Try adding db_type for global help to make travis work

* Add print statements to debug travis failure

* Enable transaction and remove debug flag

* Fix help table creation query (postgres)

* Fix import issue

* Add some checks to prevent errors
- Some doctypes used to get called even before they are created

* Try fixes

* Update travis config

* Fix create index for help table

* Remove unused code

* Fix queries and update travis config

* Fix ifnull replace logic (regex)

* Add query fixes and code cleanup

* Fix typo
- get_column_description -> get_table_columns_description

* Fix tests
- Replace double quotes in query with single quote

* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

* Add multisql api

* Add few multisql queries

* Remove print statements

* Remove get_fulltext_search_condition method and replace with multi query

* Remove text slicing in create user

* Set default for 'values' argument in multisql

* Fix incorrect queries and remove few debug flags
- Fix multisql bug

* Force delete user to fix test
- Fix Import error
- Fix incorrect query

* Fix query builder bug

* Fix bad query

* Fix query (minor)

* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query

* Extend database class from an object to support python 2

* Fix query
- Add quotes around value passed to the query for variable comparision

* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database

* Set site hostname to data migration connector (in test file)
- To connect the same site host

* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset

* Replace few sql queries with orm methods

* Fix codacy

* Fix 'Doctype Sessions not found' issue

* Fix bugs induced during codacy fixes

* Fix Notification Test

- Use ORM instead of raw sql

* Set Date fallback value to 0001-01-01

- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both

* Fix date filter method

* Replace double quotes with single quote for literal value

* Remove print statement

* Replace double quotes with single

* Fix tests

- Replace few raw sql with ORM

* Separate query for postgres

- update_fields_to_fetch_query

* Fix tests

- replace locate with strpos for postgres

* Fix tests

- Skip test for datediff
- convert bytes to str in escape method

* Remove TestBot

* Skip fieldname extraction

* Replace docshare raw sql with ORM

* Fix typo

* Fix ancestor query test

* Fix test data migration

* Remove hardcoded hostname

* Add default option and option list for db_type

* Remove frappe.async module

* Remove a debug flag from test

* Fix codacy

* fix import issue

* Convert classmethod to static method

* Convert few instance methods to static methods

* Remove some unused imports

* Fix codacy

- Add exception type
- Replace few instance methods with static methods
- Remove unsued import

* Fix codacy

* Remove unused code

* Remove some unused codes

- Convert some instance methods to static function

* Fix a issue with query modification

* Fix add_index query

* Fix query

* Fix update_auth patch

* Fix a issue with exception handling

* Add try catch to a reload_doc

* Add try-catch to file_manager_hook patch

* import update_gravatar to set_user_gravatar patch

* Undo all the wrong patch fixes

* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)

* Fix typo !

* Fix exception(is_missing_column) handling

* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file

* Fix codacy

* Replace a mariadb specific function in a query used in validate_series

* Remove a debug flag

* Revert changes (rename_parent_and_child)

* Fix validate_one_root method

* Fix date format issue

* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method

* Add bandit.yml

The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.

* Skip start_process_with_partial_path check

* Fix typo

* Add python 2.7 test

* Move python versions in travis.yml

* Add python versions to jobs

* Overwrite python version inheritance for postgres in travis.yml

* Add quotes around python version in .travis.yml

* Add quotes around the name of the job

* Try a travis fix

* Try .travis.yml fix

* Import missing subprocess

* Refactor travis.yml

* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type

* Make install.sh and run-tests.sh executable

* Add sudo required to travis.yml to allow sudo cmmands in shell files

* Load nvm

* Remove verbose flag from scripts

* Remove command-trace-print flag

* Change to build dir in before script

* Add absolute path for scripts

* Fix tests

* Fix typo

* Fix codacy
- fixes - "echo won't expand escape sequences." warning

* Append (_) underscore instead of 'd' for db_name

* Remove printf and use mysql execute flag
2018-09-21 10:20:48 +05:30
abhijitkumbharInd
f9c03a0b54 [Fix][5941][Contact should get back to original page from where initi… (#5942)
* [Fix][5941][Contact should get back to original page from where initiated (like Address)]

* Added last_route.length condition

* [Fix][5941][length check]
2018-09-03 11:04:23 +05:30
Rushabh Mehta
a9f32f292c default(perms): add default import, export perms 2018-08-29 17:09:35 +05:30
Charles-Henri Decultot
dab491e55f Doctype links in foreign language (#5745)
* Doctype search in foreign language

* List comprehension slightly faster

* Remove obsolete comment

* Remove trailing whitespace

* Test case for address and contact query

* Refactor search and add tests

* Travis test debug

* Remove debug print

* Search limit removal for untranslated docs and tests refactor

* Remove old comments

* Test modification for Travis

* remove unused import

* Correct Role doctype
2018-08-24 15:23:20 +05:30
Nabin Hait
39e9e306f2 Cached some queries (#5951) 2018-08-09 11:25:07 +05:30
Faris Ansari
09735e9f3e Query Report: deprecated query_report_filters_by_name (#5834)
* QueryReport

- Remove set_filters_by_name
- Remove save_user_settings
- Only print visible columns

* Query Report

- Deprecate frappe.query_report_filters_by_name
- New API: get_filter_value and set_filter_value
in frappe.query_report object
- Replace instances of old API with new API

* Undo changes in query_report.py
2018-07-18 09:28:36 +05:30
Shridhar Patil
e808da398e removed on_trash method (#5757)
trying to update in doctype issue
fails to update if erpnext is not installed
2018-07-03 10:51:25 +05:30
Shridhar Patil
01914a486f Address title field changed to mandatory (#5759) 2018-07-02 11:30:43 +05:30
Shreya Shah
2c05009df3 Modify Report Addresses and Contacts (#5642)
* Modify Report Addresses and Contacts

Removed party type references and moved that to a new report in ERPNext.

* Change label to Reference Type

* Rename labels
2018-06-01 18:04:59 +05:30
Gaurav Naik
e38104dbeb modified address and contact js (#4862) (#5586)
* modified aaddress and contact js

- temporary fix to handle route_history if docname is naming_series with a '/' in the name- permanant fix would be to modify route options
- PR linked to frappe/erpnext#12215

* considered cases with more '/'s in doc name
2018-05-23 11:17:33 +05:30
Ameya Shenoy
06851e7376
Merge branch 'master' into develop 2018-05-22 08:45:40 +00:00