Commit graph

17 commits

Author SHA1 Message Date
Himanshu
0e7123d141 fix(Addresses and Contacts Report): Frappe throw when no record present (#7504) 2019-05-21 14:50:49 +05:30
Himanshu Warekar
5c3121ab84 fix: making it py2 and py3 compatible 2019-04-06 22:50:05 +05:30
Himanshu Warekar
b3359f5eb2 fix: code refactor 2019-04-06 21:53:09 +05:30
Himanshu Warekar
422a1e151b fix: test cases using assertListEqual 2019-04-05 16:00:16 +05:30
Himanshu Warekar
f06fa603d7 fix: test case 2019-04-05 15:22:55 +05:30
Himanshu Warekar
1b4550c503 fix: test case 2019-04-05 15:05:09 +05:30
Himanshu
14f63830ad
fix: test case 2019-04-05 13:29:07 +05:30
Himanshu Warekar
674bee4cde fix: fetch all contacts and addresses 2019-04-05 11:01:51 +05:30
Aditya Hase
837bfc0995 fix(unicode): Import unicode_literals in every file (#6805)
* fix(unicode): Import unicode_literals in every file

* fix(unicode): Test if safe_json_loads return unicode instead of bytes
2019-01-25 11:56:27 +05:30
Shivam Mishra
12798c9ee5 Fixed Addresses and Contacts Report (#6651)
* Fixed Addresses and Contacts Report

* minor change

* [Report Fix] Added test cases for Addresses and Contacts Report

* [Report Fix] Fixed a small typo 'Doctype' - 'DocType'

* [Report Fix] Fixed code formatting

* [Code Formatting] Removed unused variables

* [Code Formatting] Removed unused variable doc
2019-01-02 09:12:07 +05:30
Ameya Shenoy
b42a87746a
Merge branch 'master' into staging-fixes 2018-10-19 12:42:37 +00:00
Rohit Waghchaure
4db18698d5 [Fix] Report Addresses And Contacts not working 2018-10-17 15:46:25 +05:30
Faris Ansari
09735e9f3e Query Report: deprecated query_report_filters_by_name (#5834)
* QueryReport

- Remove set_filters_by_name
- Remove save_user_settings
- Only print visible columns

* Query Report

- Deprecate frappe.query_report_filters_by_name
- New API: get_filter_value and set_filter_value
in frappe.query_report object
- Replace instances of old API with new API

* Undo changes in query_report.py
2018-07-18 09:28:36 +05:30
Shreya Shah
2c05009df3 Modify Report Addresses and Contacts (#5642)
* Modify Report Addresses and Contacts

Removed party type references and moved that to a new report in ERPNext.

* Change label to Reference Type

* Rename labels
2018-06-01 18:04:59 +05:30
Ameya Shenoy
9c4f47b461 optimized addr_and_contact report by @nabinhait
Old implemetation involved 2 sql queries for every party_type, one for
address and one for contact. This was timing out if the party_type size
was too large. New implementation involves 3 queries only.

Stats:
	no_of_records | party_type | old_time | new_time
	--------------+------------+----------+---------
	27000         | Customer   | 209 secs | 1.5 sec
2018-05-09 17:50:43 +05:30
Makarand Bauskar
6f164ed975 [minor] removed the default for party type field in address and contacts report (#4614) 2017-12-14 14:53:22 +05:30
KanchanChauhan
f52e389d4f Salutation and Gender in Contact (#3079) 2017-06-13 15:25:53 +05:30