Commit graph

137 commits

Author SHA1 Message Date
Mangesh-Khairnar
cc0ea13ec5
fix: has permission decorator 2019-05-23 13:04:59 +05:30
Suraj Shetty
1bcdc0b7cb fix(report): Allow report export only if user has export permission on ref doctype (#7458)
* fix: Allow export only if user has export permission on reference doctype

* fix: Show only custom "no permission" error

* fix: while saving employee user getting user permissions error
2019-05-15 11:59:13 +05:30
Mangesh-Khairnar
c23876198d fix: filter default docs from allowed docs 2019-04-22 13:54:05 +05:30
Mangesh-Khairnar
8d8ef7ad3c fix: return allowed docs along with default doc 2019-04-22 13:53:43 +05:30
Mangesh-Khairnar
fe007f426d fix: default user permission to handle small int values 2019-04-17 19:06:38 +05:30
Mangesh-Khairnar
9079e7965e feat: pass default value to add user permission 2019-04-16 23:37:52 +05:30
Mangesh-Khairnar
b53ff42bcd feat: assign default value to link field based on the user permission 2019-04-16 23:37:52 +05:30
Suraj Shetty
1c8fd3169e fix(permission): use .get to avoid key error (#7187)
Port of https://github.com/frappe/frappe/pull/7184
2019-04-01 18:22:17 +05:30
Suraj Shetty
72d82538a8
fix: typo 2019-03-14 20:34:12 +05:30
Rushabh Mehta
ce76b51ff1
fix(messages): make messages translatable 2019-03-14 10:51:33 +05:30
Faris Ansari
8f86c15d9d fix: More verbose User permission message 2019-03-13 11:22:36 +00:00
Sagar Vora
17b20b22a3 Merge branch 'master' into develop 2019-02-12 16:31:54 +05:30
Suraj Shetty
66179ab862
fix: Use .get() to avoid key error 2019-02-10 12:54:37 +05:30
Suraj Shetty
06892149a9 Show permission failure message based on passed user
- only if user passed is equal to session user or if no user is passed
2019-02-07 17:48:05 +05:30
Frappe Bot
1197271700 Fixed merge conflict 2019-01-05 09:06:05 +00:00
Suraj Shetty
9adbbd44c8 fix(permission): Role permission check with if_owner enabled (#6726)
* Allow user to access list even if there is only a docperm with if owner enabled

* Add test to check if user gets access to the list

- User should be able to access list even if the user has only
 role for which docperm is created with if_owner check

* Remove commented code
2019-01-05 14:31:40 +05:30
Saurabh
3aef483538 Merge branch 'staging' into develop 2018-12-26 21:59:52 +05:30
Suraj Shetty
2a315b154e
fix(permission): KeyError 2018-12-26 21:16:41 +05:30
Frappe Bot
0499b4a845 Merge branch 'staging' into develop 2018-12-26 12:03:03 +00:00
Suraj Shetty
3213393727 Display fieldname on which restriction is applied for clarity 2018-12-25 13:16:54 +05:30
Suraj Shetty
e3b4b91655 Translate log strings 2018-12-10 14:05:59 +05:30
Suraj Shetty
1467fbe4bd Remove an unwanted argument 2018-12-02 12:13:20 +05:30
Suraj Shetty
11ec1e81a8 Add a decorator to print user permission check logs 2018-12-02 12:10:31 +05:30
Suraj Shetty
63df0ea5c7 Fix incorrect doctype check 2018-11-12 18:16:27 +05:30
Suraj Shetty
8f5126d831 Fix AttributeError 2018-11-12 16:47:35 +05:30
Suraj Shetty
5d13a5e902 Fix AttributeError 2018-11-12 16:20:11 +05:30
Suraj Shetty
82267a13e7 Fix AttributeError 2018-11-12 14:10:35 +05:30
Suraj Shetty
efbfc087d2 Fix typo 2018-11-12 13:11:15 +05:30
Suraj Shetty
e2cce998c5 Fix has_user_permission check
- Pass if there are no user_permission
applicable for the doctype of the doc
2018-11-12 12:56:12 +05:30
Suraj Shetty
7989cd054a Fix if_owner permission override 2018-11-05 08:35:01 +05:30
Suraj Shetty
5d75f95ec9 Social fixes (#6375)
* Fix post and post comment permissions

- User should be able to edit only his post/comment
- other post should and comment should be readonly

* Separate scroll to section function

* Add a test fix

* Hide activity on mobile view for now

* fix: Return early if no session user

* chore: Remove empty test files

* Add semicolon

* Return if doc.owner is not present
2018-11-02 14:45:24 +05:30
Suraj Shetty
0ffa645e10 Fixes to support new changes with user permission 2018-11-01 21:18:15 +05:30
Suraj Shetty
09a50942b7 Refactor has_permission 2018-11-01 21:18:14 +05:30
Suraj Shetty
4b3ae8f1ce wip(user_permissions) 2018-11-01 21:17:21 +05:30
Karan Sharma
943b66714d Make user permission check as case-insensitive (#6313) 2018-10-30 11:02:22 +05:30
Ameya Shenoy
aa4ef1b405
Merge branch 'staging' into develop 2018-10-23 08:04:11 +00:00
Rohit Waghchaure
63b2c14ec8 Set verbose to false 2018-10-23 11:59:18 +05:30
Ameya Shenoy
06d9385829
Merge branch 'staging' into develop 2018-10-19 12:51:40 +00:00
Rohit Waghchaure
0ab71884da [Fix] multiple user permissions messages are coming even if permissions are set 2018-10-17 18:48:51 +05:30
Ameya Shenoy
63c5613f92
Merge branch 'staging' into develop 2018-10-11 10:11:26 +00:00
Suraj Shetty
9dea3f1684 Revert permission changes (#6249) 2018-10-11 15:26:47 +05:30
Ameya Shenoy
ec18e90089
Merge branch 'staging' into develop 2018-10-11 06:56:34 +00:00
Ameya Shenoy
d3b83bd8c6
Merge branch 'master' into staging-fixes 2018-10-11 06:51:33 +00:00
rohitwaghchaure
301fcdefdc [Fix] User permissions (#6218)
* [Fix] User permissions

* Update permissions.py
2018-10-08 18:33:41 +05:30
Suraj Shetty
968791195a [Hotfix] [Permission] Fix custom docperm check in get_valid_perm (#6200)
* Fix custom docperm check in get_valid_perm

- Previously to get_valid perm we just used
to check all the custom docperms
available for the user's role and apply
standard perm for any missing doctype
But there might be some doctypes with
custom docperms which might not match
any of user's role.
Such doctype's perms should not be
replaced by standard docperm.
This PR fixes that.

* Avoids admin lock
2018-10-08 17:04:26 +05:30
Ameya Shenoy
63d7d776ca
Merge branch 'staging' into develop 2018-10-08 09:42:29 +00:00
Rohit Waghchaure
57eba77bdd [Fix] User permissions 2018-10-08 13:03:33 +05:30
Ameya Shenoy
e551153ea0
Merge branch 'staging' into develop 2018-09-26 07:21:28 +00:00
Rushabh Mehta
8c302e956d fix(permissions.py) 2018-09-24 09:30:05 +05:30
Rushabh Mehta
2e6a202652 Postgres support for Frappe (#5919)
* [start] postgres

* [wip] started refactoring db_schema

* Add psycopg2 to requirements.txt

* Add support for Postgres SQL

- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP

* Remove quotes from sql to make it compatible with postgres as well

* Moved some code from db_schema to database.py

* Move code from db_schema to schema.py

Add other required refactoring

* Add schema chages

* Remove redundant code in file

* Add invalid column name exception class to exceptions.py

* Add back tick in query wherever needed and replace ifnull with coalesce

* Update get_column_description code in database.py file

* Remove a print statement

* Add keys to get on_duplicate query

* Add bactick wherever necessary

- Remove db_schema.py file

* Remove DATE_SUB as it is incompatible with postgres

- Fix prepare_filter_condition

* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors

* Add code to create key and unique index
- added mysql and posgres in their respective database.py

* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage

* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int

* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable

* Replace Database instance with get_db method

* Move db_manager to separate file

* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py

* Make fulltext search changes in global_search.py

* Add empty string check

* Add root_password to site config

* Create cli command for postgres console

* Move setup of help database to setup_db.py

* Add get_database_list method

* Fix exception handling
- Replace bad_field handler with missing_column handler

* Fix tests and sql queries

* Fix import error

* Fix typo db -> database

* Fix error with make_table in help.py

* Try test for postgres

* Remove pyhton 2.7 version to try postgres travis test

* Add test fixes

* Add db_type to the config of test_site_postgres

* Enable query debug to check the reason for travis fail

* Add backticks to check if the test passes

* Update travis.yml
- Add postgres addon

* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number

* Try adding db_type for global help to make travis work

* Add print statements to debug travis failure

* Enable transaction and remove debug flag

* Fix help table creation query (postgres)

* Fix import issue

* Add some checks to prevent errors
- Some doctypes used to get called even before they are created

* Try fixes

* Update travis config

* Fix create index for help table

* Remove unused code

* Fix queries and update travis config

* Fix ifnull replace logic (regex)

* Add query fixes and code cleanup

* Fix typo
- get_column_description -> get_table_columns_description

* Fix tests
- Replace double quotes in query with single quote

* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi

* Add multisql api

* Add few multisql queries

* Remove print statements

* Remove get_fulltext_search_condition method and replace with multi query

* Remove text slicing in create user

* Set default for 'values' argument in multisql

* Fix incorrect queries and remove few debug flags
- Fix multisql bug

* Force delete user to fix test
- Fix Import error
- Fix incorrect query

* Fix query builder bug

* Fix bad query

* Fix query (minor)

* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query

* Extend database class from an object to support python 2

* Fix query
- Add quotes around value passed to the query for variable comparision

* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database

* Set site hostname to data migration connector (in test file)
- To connect the same site host

* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset

* Replace few sql queries with orm methods

* Fix codacy

* Fix 'Doctype Sessions not found' issue

* Fix bugs induced during codacy fixes

* Fix Notification Test

- Use ORM instead of raw sql

* Set Date fallback value to 0001-01-01

- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both

* Fix date filter method

* Replace double quotes with single quote for literal value

* Remove print statement

* Replace double quotes with single

* Fix tests

- Replace few raw sql with ORM

* Separate query for postgres

- update_fields_to_fetch_query

* Fix tests

- replace locate with strpos for postgres

* Fix tests

- Skip test for datediff
- convert bytes to str in escape method

* Remove TestBot

* Skip fieldname extraction

* Replace docshare raw sql with ORM

* Fix typo

* Fix ancestor query test

* Fix test data migration

* Remove hardcoded hostname

* Add default option and option list for db_type

* Remove frappe.async module

* Remove a debug flag from test

* Fix codacy

* fix import issue

* Convert classmethod to static method

* Convert few instance methods to static methods

* Remove some unused imports

* Fix codacy

- Add exception type
- Replace few instance methods with static methods
- Remove unsued import

* Fix codacy

* Remove unused code

* Remove some unused codes

- Convert some instance methods to static function

* Fix a issue with query modification

* Fix add_index query

* Fix query

* Fix update_auth patch

* Fix a issue with exception handling

* Add try catch to a reload_doc

* Add try-catch to file_manager_hook patch

* import update_gravatar to set_user_gravatar patch

* Undo all the wrong patch fixes

* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)

* Fix typo !

* Fix exception(is_missing_column) handling

* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file

* Fix codacy

* Replace a mariadb specific function in a query used in validate_series

* Remove a debug flag

* Revert changes (rename_parent_and_child)

* Fix validate_one_root method

* Fix date format issue

* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method

* Add bandit.yml

The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.

* Skip start_process_with_partial_path check

* Fix typo

* Add python 2.7 test

* Move python versions in travis.yml

* Add python versions to jobs

* Overwrite python version inheritance for postgres in travis.yml

* Add quotes around python version in .travis.yml

* Add quotes around the name of the job

* Try a travis fix

* Try .travis.yml fix

* Import missing subprocess

* Refactor travis.yml

* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type

* Make install.sh and run-tests.sh executable

* Add sudo required to travis.yml to allow sudo cmmands in shell files

* Load nvm

* Remove verbose flag from scripts

* Remove command-trace-print flag

* Change to build dir in before script

* Add absolute path for scripts

* Fix tests

* Fix typo

* Fix codacy
- fixes - "echo won't expand escape sequences." warning

* Append (_) underscore instead of 'd' for db_name

* Remove printf and use mysql execute flag
2018-09-21 10:20:48 +05:30