Commit graph

21 commits

Author SHA1 Message Date
Ankush Menat
4d7f5a8f8d
ci: fix semgrep false positives (#13161)
* ci: fix false positive rule for split js translate

- limit regex to must match end of line.
- expand previous check to take care of other ways to split multi-line
  calls.

* ci: update tests for rules, ignore rules in sider

* ci: enable semgrep on v13 branches

* ci: fix false positive for python split strings
2021-05-12 20:22:48 +05:30
Leela vadlamudi
3875004d7e
Merge pull request #13057 from leela/email-refactoring
refactor: Email Module - 1
2021-05-05 11:45:04 +05:30
leela
0a1902e650 fix: semgrep's split translation regex 2021-05-03 06:25:57 +05:30
Ankush Menat
5881c5dbec
ci(semgrep): add more rules, r/python.correctness (#12876)
* ci(semgrep): add more rules, r/python.correctness

- Added file for defining rules as per frappe data model:
frappe_correctness.yml
- Add rule for SQLi, with WARNING only for now
- Add rule file for UX
- WARNING | INFO do not fail the build now

* ci(semgrep): on_cancel, on_submit correctness rule

* ci(semgrep): split workflow in steps

* ci(semgrep): catch line breaks in _()

* chore: fix sider issue
2021-04-23 09:04:34 +05:30
Ankush Menat
cee30d2fa7
ci: ignore safe_eval paths 2021-03-23 18:24:01 +05:30
Ankush Menat
d7bc848a52
test(semgrep): python and javascript translation
- Move rules to .github folder to reduce clutter in root folder
- separate out rules
- add tests for rules
- docs for writing more rules
2021-03-13 18:22:48 +05:30
Mohammad Hasnain Mohsin Rajan
7148af3c20
ci: Fix Github Action (#12574) 2021-03-12 22:44:30 +05:30
Mohammad Hasnain Mohsin Rajan
3ee0d76776
ci: Port from TravisCI to Github Actions (#12559) 2021-03-12 13:59:30 +05:30
Suraj Shetty
da166c3db9 chore: Fix translation syntax check 2021-01-30 13:02:52 +05:30
Suraj Shetty
e643ccf002 chore: Show correct line number 2021-01-30 08:29:20 +05:30
Suraj Shetty
cae26da129 chore: Fix translation syntax check 2021-01-30 08:16:59 +05:30
Raffael Meyer
0d6dafa3f5
fix: allow other github links in same PR 2020-11-24 11:36:23 +01:00
Faris Ansari
c7ed6ce977 fix: Remove test strings and early return 2020-10-12 21:12:47 +05:30
Faris Ansari
18bc0d14cf fix: remove hardcoded path 2020-10-12 21:03:22 +05:30
Faris Ansari
8708e56896 fix: Handle f string and fix words check 2020-10-12 21:00:15 +05:30
Faris Ansari
d1b92c66bb fix: eager lookup 2020-10-12 17:36:44 +05:30
Faris Ansari
a113f5c285 fix: add test strings 2020-10-12 17:28:21 +05:30
Faris Ansari
5cf39f746a chore: Check existence of words in translation linter 2020-10-12 17:26:36 +05:30
Suraj Shetty
23bbbb1bbd chore: Consider template string as invalid 2020-10-12 11:34:51 +05:30
Gavin D'souza
076ba11111 fix: Update documentation helper 2020-10-05 14:06:58 +05:30
gavin
012c637c30
chore: Replace existing Docs required check (#11618) 2020-10-02 16:58:45 +05:30