Don't raise exceptions where a simple print() will suffice
Print exception before prompting for rollback
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
FC creates a temporary non-root user to use as the root user here, which doesn't have `SELECT` permissions on `mysql.user`
Try to work around it by relying on `CREATE USER IF NOT EXISTS`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
The database resource management including privileges granting can be
done by external secops. It can be undesirable to grant the grant option
to the framework user.
This commit implements the possibility to remove user resource
management from frappe entirely and only boostrap the database with its
target user.
* fix: procure db config from single authority
ensures that configuration is uniformely procured from local.conf
instead of making use of hard to audit multilevel fallback logic
Implementation Note:
- `get_db(host, port, user, password)` was stripped of any optional
argument and therefrom all errors where fixed.
- All occurances of `grep 'frappe.db.db_'` where changed to
`frappe.conf.db_`
* fix: revert unnecessary breaking changes
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
Previous attempts to run this would lead to stalls...long long stalls.
And nothing blocking the query, it would stay in a "Waiting for table
metadata lock" state.
This takes care of the following scenario.
During restore, before tabDefaultValue is created if a request/command executes frappe.db.get_tables, then the cached value db_tables is populated with partial list of tables.
bootstrap_database then checks if this partial list contains tabDefaultValue (as a sanity test to see if the restore worked). This check fails even though the database is correctly restored.
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
db_host != the hostname part after @, hmm. so instead we'll pass
no-mariadb-socket flag to setup_database where we'll drop and create
users with host set to the TCP/IP socket instead of the UNIX socket.
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
* Fixed setup_db.py to support MariaDB version 10.3. Added function for calculating versions, per MariaDB documentation.
* Major rewrite of setup_db.py. Reduced number of functions. Made fully compatible with MariaDB 10.3+. Removed references to client parameters in my.cnf that cannot be queried. Applied PEP8 rules to python code.
* Adding missing print statement in setup_db.py
* Replaced 4-spaces with tabs, per ERPNext standards.
* Fixed broken test by substituing 'check_database_settings()'
Fixed the test in convert_to_barracuda_and_utf8mb4.py by calling the new function 'check_database_settings()'
* Cleaned up setup.py, to match latest version of Frappe develop
* [start] postgres
* [wip] started refactoring db_schema
* Add psycopg2 to requirements.txt
* Add support for Postgres SQL
- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP
* Remove quotes from sql to make it compatible with postgres as well
* Moved some code from db_schema to database.py
* Move code from db_schema to schema.py
Add other required refactoring
* Add schema chages
* Remove redundant code in file
* Add invalid column name exception class to exceptions.py
* Add back tick in query wherever needed and replace ifnull with coalesce
* Update get_column_description code in database.py file
* Remove a print statement
* Add keys to get on_duplicate query
* Add bactick wherever necessary
- Remove db_schema.py file
* Remove DATE_SUB as it is incompatible with postgres
- Fix prepare_filter_condition
* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors
* Add code to create key and unique index
- added mysql and posgres in their respective database.py
* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage
* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int
* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable
* Replace Database instance with get_db method
* Move db_manager to separate file
* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py
* Make fulltext search changes in global_search.py
* Add empty string check
* Add root_password to site config
* Create cli command for postgres console
* Move setup of help database to setup_db.py
* Add get_database_list method
* Fix exception handling
- Replace bad_field handler with missing_column handler
* Fix tests and sql queries
* Fix import error
* Fix typo db -> database
* Fix error with make_table in help.py
* Try test for postgres
* Remove pyhton 2.7 version to try postgres travis test
* Add test fixes
* Add db_type to the config of test_site_postgres
* Enable query debug to check the reason for travis fail
* Add backticks to check if the test passes
* Update travis.yml
- Add postgres addon
* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number
* Try adding db_type for global help to make travis work
* Add print statements to debug travis failure
* Enable transaction and remove debug flag
* Fix help table creation query (postgres)
* Fix import issue
* Add some checks to prevent errors
- Some doctypes used to get called even before they are created
* Try fixes
* Update travis config
* Fix create index for help table
* Remove unused code
* Fix queries and update travis config
* Fix ifnull replace logic (regex)
* Add query fixes and code cleanup
* Fix typo
- get_column_description -> get_table_columns_description
* Fix tests
- Replace double quotes in query with single quote
* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi
* Add multisql api
* Add few multisql queries
* Remove print statements
* Remove get_fulltext_search_condition method and replace with multi query
* Remove text slicing in create user
* Set default for 'values' argument in multisql
* Fix incorrect queries and remove few debug flags
- Fix multisql bug
* Force delete user to fix test
- Fix Import error
- Fix incorrect query
* Fix query builder bug
* Fix bad query
* Fix query (minor)
* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query
* Extend database class from an object to support python 2
* Fix query
- Add quotes around value passed to the query for variable comparision
* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database
* Set site hostname to data migration connector (in test file)
- To connect the same site host
* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset
* Replace few sql queries with orm methods
* Fix codacy
* Fix 'Doctype Sessions not found' issue
* Fix bugs induced during codacy fixes
* Fix Notification Test
- Use ORM instead of raw sql
* Set Date fallback value to 0001-01-01
- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both
* Fix date filter method
* Replace double quotes with single quote for literal value
* Remove print statement
* Replace double quotes with single
* Fix tests
- Replace few raw sql with ORM
* Separate query for postgres
- update_fields_to_fetch_query
* Fix tests
- replace locate with strpos for postgres
* Fix tests
- Skip test for datediff
- convert bytes to str in escape method
* Remove TestBot
* Skip fieldname extraction
* Replace docshare raw sql with ORM
* Fix typo
* Fix ancestor query test
* Fix test data migration
* Remove hardcoded hostname
* Add default option and option list for db_type
* Remove frappe.async module
* Remove a debug flag from test
* Fix codacy
* fix import issue
* Convert classmethod to static method
* Convert few instance methods to static methods
* Remove some unused imports
* Fix codacy
- Add exception type
- Replace few instance methods with static methods
- Remove unsued import
* Fix codacy
* Remove unused code
* Remove some unused codes
- Convert some instance methods to static function
* Fix a issue with query modification
* Fix add_index query
* Fix query
* Fix update_auth patch
* Fix a issue with exception handling
* Add try catch to a reload_doc
* Add try-catch to file_manager_hook patch
* import update_gravatar to set_user_gravatar patch
* Undo all the wrong patch fixes
* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)
* Fix typo !
* Fix exception(is_missing_column) handling
* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file
* Fix codacy
* Replace a mariadb specific function in a query used in validate_series
* Remove a debug flag
* Revert changes (rename_parent_and_child)
* Fix validate_one_root method
* Fix date format issue
* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method
* Add bandit.yml
The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.
* Skip start_process_with_partial_path check
* Fix typo
* Add python 2.7 test
* Move python versions in travis.yml
* Add python versions to jobs
* Overwrite python version inheritance for postgres in travis.yml
* Add quotes around python version in .travis.yml
* Add quotes around the name of the job
* Try a travis fix
* Try .travis.yml fix
* Import missing subprocess
* Refactor travis.yml
* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type
* Make install.sh and run-tests.sh executable
* Add sudo required to travis.yml to allow sudo cmmands in shell files
* Load nvm
* Remove verbose flag from scripts
* Remove command-trace-print flag
* Change to build dir in before script
* Add absolute path for scripts
* Fix tests
* Fix typo
* Fix codacy
- fixes - "echo won't expand escape sequences." warning
* Append (_) underscore instead of 'd' for db_name
* Remove printf and use mysql execute flag
