Some doctypes like `Payment Entry`, `Bank Account`, `Pricing Rule` were present in 2 dashboards (customer and supplier dashboard), both of which were included in ERPNext communucation_doctype hooks
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore: Drop unused imports
* refactor: split translation utils from init.py
* refactor: move sendmail from init.py
* refactor: move prints to attach_print
* chore: enhance UX of New Email dialog
* do not show contacts without an email
* use name as value, y? if several contacts use the same email address, the entry will be displayed several times, but always with the same description, which leads to confusion - using name as value makes the entries distinguishable
* chore: ignore semgrep
Rewriting the query is not in the scope of this PR.
* chore: keep semgrep failing on raw query
[skip ci]
* fix: use email_id as value
* Revert "fix: use email_id as value"
This reverts commit e4c44e2094ddb9b525bc34d400642dcee5656096.
* chore: comment confusing code
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
* Conditions passed are not valid prepared statement values. They
can be passed as string substitution since they're generated by DBQuery.
* Added typing hints & other improvements
* Removed seemingly pointless try-except block
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
* Remove six for PY2 compatability since our dependencies are not, PY2
is legacy.
* Removed usages of utils from future/past libraries since they are
deprecated. This includes 'from __future__ ...' and 'from past...'
statements.
* Removed compatibility imports for PY2, switched from six imports to
standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
* [start] postgres
* [wip] started refactoring db_schema
* Add psycopg2 to requirements.txt
* Add support for Postgres SQL
- Separate frameworkSQL, database, schema, setup_db file for
mariaDB and postgres
- WIP
* Remove quotes from sql to make it compatible with postgres as well
* Moved some code from db_schema to database.py
* Move code from db_schema to schema.py
Add other required refactoring
* Add schema chages
* Remove redundant code in file
* Add invalid column name exception class to exceptions.py
* Add back tick in query wherever needed and replace ifnull with coalesce
* Update get_column_description code in database.py file
* Remove a print statement
* Add keys to get on_duplicate query
* Add bactick wherever necessary
- Remove db_schema.py file
* Remove DATE_SUB as it is incompatible with postgres
- Fix prepare_filter_condition
* Add backtick and quotes wherever necessary
- Move get_database_size to frappe.db namespace
- fix some left out bugs and errors
* Add code to create key and unique index
- added mysql and posgres in their respective database.py
* Add more bacticks in queries and fix some errors
- Pass keys to on_duplicate_update method
- Replace MONTH with EXTRACT function
- Remove DATEDIFF and CURDATE usage
* Cast state value to int in toggle_two_factor_auth
- since two_factor_auth has the datatype of Int
* Refactor
- Replace Timediff with normal arithmetic operator
- Add MAX_COLUMN_LENGTH
- Remove Redundant code
- Add regexp character constant
- Move create_help_table to database.py
- Add get_full_text_search_condition method
- Inherit MariaDBTable from DBTable
* Replace Database instance with get_db method
* Move db_manager to separate file
* Refactor
- Remove some unwanted code
- Separate alter table code for postgres and mysql
- Replace data_type with column_type in database.py
* Make fulltext search changes in global_search.py
* Add empty string check
* Add root_password to site config
* Create cli command for postgres console
* Move setup of help database to setup_db.py
* Add get_database_list method
* Fix exception handling
- Replace bad_field handler with missing_column handler
* Fix tests and sql queries
* Fix import error
* Fix typo db -> database
* Fix error with make_table in help.py
* Try test for postgres
* Remove pyhton 2.7 version to try postgres travis test
* Add test fixes
* Add db_type to the config of test_site_postgres
* Enable query debug to check the reason for travis fail
* Add backticks to check if the test passes
* Update travis.yml
- Add postgres addon
* Try appending 'd_' to hash for db_name
- since postgres does not support dbname starting with a number
* Try adding db_type for global help to make travis work
* Add print statements to debug travis failure
* Enable transaction and remove debug flag
* Fix help table creation query (postgres)
* Fix import issue
* Add some checks to prevent errors
- Some doctypes used to get called even before they are created
* Try fixes
* Update travis config
* Fix create index for help table
* Remove unused code
* Fix queries and update travis config
* Fix ifnull replace logic (regex)
* Add query fixes and code cleanup
* Fix typo
- get_column_description -> get_table_columns_description
* Fix tests
- Replace double quotes in query with single quote
* Replace psycopg2 with psycopg2-binary to avoid warnings
- http://initd.org/psycopg/docs/install.html#binary-install-from-pypi
* Add multisql api
* Add few multisql queries
* Remove print statements
* Remove get_fulltext_search_condition method and replace with multi query
* Remove text slicing in create user
* Set default for 'values' argument in multisql
* Fix incorrect queries and remove few debug flags
- Fix multisql bug
* Force delete user to fix test
- Fix Import error
- Fix incorrect query
* Fix query builder bug
* Fix bad query
* Fix query (minor)
* Convert boolean text to int since is_private has datatype of int
- Some query changes like removed double quotes
and replace with interpolated string to pass multiple
value pass in one of the query
* Extend database class from an object to support python 2
* Fix query
- Add quotes around value passed to the query for variable comparision
* Try setting host_name for each test site
- To avoid "RemoteDisconnected" error while testing data migration test
- Update travis.yml to add hosts
- Remove unwanted commit in setup_help_database
* Set site hostname to data migration connector (in test file)
- To connect the same site host
* Fix duplicate entry issue
- the problem is in naming series file.
In previous commits I unknowingly changed a part of a series query
due to which series were not getting reset
* Replace few sql queries with orm methods
* Fix codacy
* Fix 'Doctype Sessions not found' issue
* Fix bugs induced during codacy fixes
* Fix Notification Test
- Use ORM instead of raw sql
* Set Date fallback value to 0001-01-01
- 0000-00-00 is invalid date in Postgres
- 0001-01-01 works in both
* Fix date filter method
* Replace double quotes with single quote for literal value
* Remove print statement
* Replace double quotes with single
* Fix tests
- Replace few raw sql with ORM
* Separate query for postgres
- update_fields_to_fetch_query
* Fix tests
- replace locate with strpos for postgres
* Fix tests
- Skip test for datediff
- convert bytes to str in escape method
* Remove TestBot
* Skip fieldname extraction
* Replace docshare raw sql with ORM
* Fix typo
* Fix ancestor query test
* Fix test data migration
* Remove hardcoded hostname
* Add default option and option list for db_type
* Remove frappe.async module
* Remove a debug flag from test
* Fix codacy
* fix import issue
* Convert classmethod to static method
* Convert few instance methods to static methods
* Remove some unused imports
* Fix codacy
- Add exception type
- Replace few instance methods with static methods
- Remove unsued import
* Fix codacy
* Remove unused code
* Remove some unused codes
- Convert some instance methods to static function
* Fix a issue with query modification
* Fix add_index query
* Fix query
* Fix update_auth patch
* Fix a issue with exception handling
* Add try catch to a reload_doc
* Add try-catch to file_manager_hook patch
* import update_gravatar to set_user_gravatar patch
* Undo all the wrong patch fixes
* Fix db_setup code 😪
- previously it was not restoring db from source SQL
which is why few old patched were breaking
(because they were getting different schema structure)
* Fix typo !
* Fix exception(is_missing_column) handling
* Add deleted code
- This code is only used in a erpnext patch.
Can be moved to that patch file
* Fix codacy
* Replace a mariadb specific function in a query used in validate_series
* Remove a debug flag
* Revert changes (rename_parent_and_child)
* Fix validate_one_root method
* Fix date format issue
* Fix codacy
- Disable a pylint for variable argument warning
- Convert an instance method to static method
* Add bandit.yml
The Codacy seems to use Bandit which generates
warning for every subprocess import and its usage during pytest
Since we have carefully used subprocess (avoided user input),
warnings needs to be avoided.
This can be removed if we have any alternative for subprocess usage.
* Skip start_process_with_partial_path check
* Fix typo
* Add python 2.7 test
* Move python versions in travis.yml
* Add python versions to jobs
* Overwrite python version inheritance for postgres in travis.yml
* Add quotes around python version in .travis.yml
* Add quotes around the name of the job
* Try a travis fix
* Try .travis.yml fix
* Import missing subprocess
* Refactor travis.yml
* Refactor travis.yml
- move install and tests commands to separate files
- Use matrix to build combination of python version and db type
* Make install.sh and run-tests.sh executable
* Add sudo required to travis.yml to allow sudo cmmands in shell files
* Load nvm
* Remove verbose flag from scripts
* Remove command-trace-print flag
* Change to build dir in before script
* Add absolute path for scripts
* Fix tests
* Fix typo
* Fix codacy
- fixes - "echo won't expand escape sequences." warning
* Append (_) underscore instead of 'd' for db_name
* Remove printf and use mysql execute flag
* Init workflow actions
- WIP code
- Add hooks to create and update
workflow action on document status changes.
- Tweak listview to show host document on list view item click
- Add new doctype "Pending Workflow Action"
- Add allow_self_approval check in Workflow master
* Rename doctypes
- Rename "Workflow Action" to "Workflow Action Master"
- Rename "Pending Workflow Action" to "Workflow Action"
- Remove irrelevant files
* Clear old workflow action on docstatus change
- Add check for user permission before creating a workflow action record
- Make doctype changes to support the Workflow Action System
* Show host document only if workflow action status is open
* Send workflow action mail notifications
* Add patch to rename `tabWorkflow Action` to `tab Workflow Master`
- Rename table to retain data in `tabWorkflow Action` as it
will be overwritten with new structure on migration
* Enqueue email
* Remove unused files
* Add hook for custom has_permission
* Optimize send_workflow_action_email method
* Add permission_query_condition hook
* Show notification based on status
* Override get_form_link in list view
* Refactor workflow action
- Add action link
- update workflow action hooks
* Avoid repeated creation of Worklow Actions
- Update hooks entry to avoid unwanted method call
* Fix error with frappe.db.count usage
* Fix ui/ux for Workflow Action
- Fix action url and improve response on action button click
- Fix workflow action template style
* Fix Codacy
* Add self approval check
* Fix codacy
* Fix test
* Fix python version confilct and a permission error
* Fix incorrect 'this' reference
* Update with requested changes
* Add next action email template option
* Fix string formatting
* Refactor workflow Action
- Make process_workflow_action smaller
* Fix bugs and errors due to refactor
* Fix workflow field caching
* Add a workflow action test
* Fix bugs with email template
* use multiselect for email dialog, improv email fetch query
* patch to create contact for all user
* append number if same name found for company
* update tests
* Communication_reconciliation
* Email inbox
* added collapsed timeline for communication
* new email prefill from when only one address
* timeline duplication and notifcation and stability fixs
* add subject to timeline
* email system v7 fixes
* added password required validation
* use proper email datetime
* email inbox v7.1 fixes
* email inbox communication_date used instead of created
* email inbox communication data cleanup
* remove old patch
* email inbox permit unlinking
* [fix] duplication queue and rename domain to email domain
* fix rename domain
* email inbox index optimisation
* email inbox relink doctype query usability fix
* email_inbox Set attachment variable for forwards and replies based on whether it exists or not
* uidnext fixes and cleanup
* email inbox fix tests
* fix rebase timeline issue
* email inbox threading and cleanup
* email inbox cleanup
* bring inbox into frappe and cleanup
* fix missed path
* inbox cleanup
* email-inbox move service back to account
* separate to erpnext contact match
* email inbox cleanup and move relink and timeline fix
* relink optimisation
* inbox fix footer
* keep email drafts on pages not just forms
* email inbox add sent items
* email inbox allow not save list settings on query
* email inbox cleanup and remove communications recon
* add suspend sending button in email queue
* fix rebase error
* email inbox assorted fixes
* email inbox fixes and relink option only when linked otherwise link;
* email inbox fix sender fullname as administrator
* create user email to custom button
* email inbox sent no match and seen
* email inbox fix unicode issues with subject recipient and sender
