Commit graph

557 commits

Author SHA1 Message Date
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Ankush Menat
29c855b028
fix: db.get_value -> db.get_single_value (#17531)
db.get_value for singles returns string type always, this is confusing
behaviour, db.get_single_value should be used instead.

semgrep rule: https://github.com/frappe/semgrep-rules/pull/16
2022-07-18 15:10:49 +05:30
Suraj Shetty
d4166dbe20 refactor: Replace html2text with markdownify 2022-07-06 08:23:14 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Jannat Patel
fd4a7031b9
fix: added mailto to email displayed on contact us page (#17269) 2022-06-22 13:23:15 +05:30
Suraj Shetty
9f2dfbe980 chore: Fix merge error 2022-06-21 09:06:34 +05:30
Suraj Shetty
49bee3a912
Merge branch 'develop' into fix-login-ux 2022-06-21 09:02:14 +05:30
Suraj Shetty
245302dc7a refactor: Rename icon symbol filename from symbol-defs.svg to icons.svg 2022-06-21 08:07:51 +05:30
Suraj Shetty
64cc07227e refactor: Replace usage of deprecated attribute 2022-06-21 08:00:49 +05:30
Ankush Menat
d6f2d34bf4 perf: send boot string instead of JSON literal
changes:

- compact boot info in /app HTML
    /app size went from 451kb to 393kb - ~13% less
    Verified that regex applied on this JSON aren't affecting perf, infact
    found them to be faster with compact JSON.

- Send json string instead of placing JSON literal in code using Jinja.
  JS takes more time to pass object literal than parsing a plain JSON string.

Overall content transfer size remains roughly same (albeit slightly
lower) since double escaping ends up adding extra `\` around quotes.

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2022-06-21 07:53:48 +05:30
Suraj Shetty
d7fe7ae39c perf(UX): Load splash screen immediately after login 2022-06-21 07:02:58 +05:30
Gavin D'souza
3871fe6cd0 perf: App Page
Reduced time taken for get_context to execute from 0.035s to 0.02s (75%
reduction)
2022-06-13 18:39:56 +05:30
Gavin D'souza
ce38587a4e perf: About Us Settings
Use cached document for building /about page
2022-06-13 18:39:56 +05:30
Gavin D'souza
7e25cc4568 perf: Login Page
Improves performance 3x - from 0.047s to 0.017s

* Use frappe.get_*_settings to query table once
* Use cached LDAP Settings' document via get_ldap_client_settings
* Use single get_all to query all Social Login providers and related
  data
* Skip provider if client_secret doesn't exist
2022-06-13 18:39:56 +05:30
Suraj Shetty
a4f2912fdf fix: Handle case where document title can be NONE
(cherry picked from commit 9b67fc24bc290789158f37a8f2ce10b505878792)
2022-06-13 06:16:56 +00:00
Jannat Patel
70188934bc
fix: pick the last signup template from hook (#17118) 2022-06-10 15:00:32 +05:30
Gavin D'souza
b696fa6da5 perf: Pre-compile and re-use regexp pattern
Converted all possible usages of re.* that weren't compiling the regex
separately and re-using it. Separated out the compiled patterns as
global variables. Repetitive patterns could be made DRY-er.

Would be nicer to have all regexes in a single module so that we could
re-use better, keep track of outdated, and keep checks for possible
reDos' etc
2022-06-08 14:07:38 +05:30
Suraj Shetty
121fb49fb5 refactor: Remove unnecessary code 2022-06-01 18:10:30 +05:30
Suraj Shetty
0cd41fbf0c
Merge branch 'develop' into fix-document-signature-2 2022-06-01 18:01:12 +05:30
Suraj Shetty
8f7d8bf1ff refactor: Update exception names 2022-06-01 17:59:19 +05:30
Suraj Shetty
f7db085db5 perf: Simplify code to avoid unnecessary DB calls 2022-06-01 17:56:46 +05:30
Suraj Shetty
af287a04a9 refactor: Remove unnecessary exception handling 2022-06-01 17:50:07 +05:30
Suraj Shetty
1431cb26d3 fix: Catch any expection and show proper error page
- Also, show title & message if it is defined in the exception class
2022-06-01 08:08:52 +05:30
Suraj Shetty
7bd91f7bfe fix: Style of document web view 2022-05-30 13:23:33 +05:30
Suraj Shetty
0fab4de3b8 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-05-25 14:18:10 +05:30
chillaranand
25f82e966c refactor: Remove unused imports & code 2022-05-19 15:34:35 +05:30
Faris Ansari
eeab5edf5f test: test for metatag rendering 2022-05-11 13:29:03 +05:30
barredterra
de45cf9bbd feat: Use autocomplete attributes for login, signup and password reset 2022-05-05 13:13:40 +02:00
Suraj Shetty
0d10624ce5 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-05-05 14:20:29 +05:30
Shariq Ansari
57e379ac68
fix: Newsletter unsubscribe button not working (#16756) 2022-04-26 15:48:06 +05:30
Gavin D'souza
de0614aaaa Merge branch 'develop' of github.com:frappe/frappe into sitemap-publish-condition 2022-04-12 13:21:21 +05:30
Gavin D'souza
93ee8b2e38 refactor(minor): Sitemap 2022-04-12 13:19:33 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Shivam Mishra
e89fd7a2af
fix: sitemap condition 2022-04-10 16:22:56 +05:30
Rushabh Mehta
dffef1285d fix(styles): fix styles for my account and web forms 2022-03-24 09:21:34 +05:30
Suraj Shetty
0514133795 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-03-13 18:27:39 +05:30
Anand Chitipothu
f811927895 fix: show traceback as string instead of bytes
Issue: #16233
2022-03-10 10:15:27 +05:30
Suraj Shetty
8cd6b88a20 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-03-01 14:15:25 +05:30
ChillarAnand
b2fc959307 refactor: Clean up whitespace & add CI check 2022-02-25 20:01:29 +05:30
Suraj Shetty
af67849928 feat: Option to Print or download PDF in print view 2022-02-18 14:26:33 +05:30
Suraj Shetty
0388398133 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-02-17 10:49:55 +05:30
mergify[bot]
4d18546a9b
Merge pull request #15953 from resilient-tech/optimize-print
fix: pass `print_heading_template` directly in render args
2022-02-16 03:47:53 +00:00
Pruthvi Patel
97bab50a58 fix: pass print_heading_template as render args 2022-02-11 18:51:10 +05:30
Suraj Shetty
7b69497841 fix: Add setting "allow_older_web_view_links" in System Settings 2022-02-07 16:25:17 +05:30
Suraj Shetty
e0e12d43f1 Merge branch 'develop' of https://github.com/frappe/frappe into fix-document-signature 2022-02-07 13:26:57 +05:30
Suraj Shetty
b7f156f580 fix: Rename "Document Key" to "Document Share Key" 2022-02-07 13:25:39 +05:30
Suraj Shetty
68d934ae0f
Merge branch 'develop' into link_title_refactor 2022-02-04 14:53:26 +05:30
Gavin D'souza
51fa09c4ab Merge branch 'develop' of github.com:frappe/frappe into thumbnail-for-images 2022-01-27 18:56:58 +05:30
Gavin D'souza
4cab8ca30a fix(test): Add missing test image for test_make_thumbnail 2022-01-27 18:56:05 +05:30
Rushabh Mehta
8dcf4d6f1f
Merge pull request #15418 from Don-Leopardo/fix_html_custom_print_fotmat
fix: Module path for external print formats
2022-01-25 09:25:05 +05:30