vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
44721 commits 1 branch 0 tags 587 MiB
Commit graph

34907 commits

Author SHA1 Message Date
Saqib Ansari
05225e077e
fix: broken dynamic_link to link formatting in query report 2024-01-01 11:56:09 +05:30
avc
c00d5ac258
feat(UX): cancel new row with escape key (#23928) 
* feat: (UX) cancel new row with escape key

* fix: linters

* fix: more linters

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2024-01-01 11:49:24 +05:30
Xiaoguang Sun
1fe3b5d5bc
refactor(workspace): Optimize save call on workspace doc (#24052) 
Optimize Workspace.save_page to call doc.save() only once therefore
eliminate sending unnecessary queries to database.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
 2024-01-01 11:38:40 +05:30
Ankush Menat
64c221343e
perf: skip ifnull checks on modified field (#24042) 2023-12-30 06:39:32 +00:00
barredterra
cd37bf0337 fix(Blog Post): correct indicator filter 2023-12-30 01:37:53 +01:00
Hussain Nagaria
b9fef7eb8d test: base class update on has web view update 2023-12-29 22:02:38 +05:30
Hussain Nagaria
ce3e029769 fix: incorrect class tags generation 2023-12-29 21:12:21 +05:30
Ankush Menat
19e0fe65f5 fix: allow guests to view published Newsletters 2023-12-29 18:04:29 +05:30
Ankush Menat
8c515a9a5d fix: correct perm check for guests 
Allow viewing document page if doctype allows guest to view
 2023-12-29 17:59:39 +05:30
Ankush Menat
38314aec59
fix: Check permissions before rendering web view (#24032) 2023-12-29 17:07:17 +05:30
Ankush Menat
585200988b feat: simple procline for scheduler 
Makes it easy to tell if scheduler is for some reason "stuck".
 2023-12-29 14:39:40 +05:30
Ankush Menat
31d72c33b4
chore: use site as "user" (#24026) 
For us, a user is single site. This is because logic like "issue affects
more than 1 user" only makes sense for site. Same client/server script
can affect multiple user on same site but it's not a useful error for
us.


[skip ci]
 2023-12-29 11:55:26 +05:30
Jannat Patel
bdc495f5d1
fix: show right permission for user cannot create doctypes (#24027) 2023-12-29 11:54:03 +05:30
Ankush Menat
d423d2ace5
fix(DX): filter version logs with changes to field (#24023) 
Diff view shows all versions. E.g. if you enable/disable a script it
shows up in possible diff targets. This PR filters versiont to only show
the ones that have the field changed somehow.
 2023-12-29 06:03:14 +00:00
Suraj Shetty
d8e97f2dc0 fix: Do not change global search label to lower case 2023-12-29 10:26:16 +05:30
Suraj Shetty
529d0aa5a7
Merge pull request #24018 from surajshetty3416/hook-to-add-custom-route-resolver 2023-12-29 06:53:18 +05:30
Suraj Shetty
a51a150376 feat: Hook to add custom route resolver 2023-12-29 06:33:59 +05:30
Ankush Menat
00f20f43c6
build: add setproctitle as dependency (#24007) 
* build: add setproctitle as dependency

RQ and other tools use it to automatically set a useful proc title

* ci: print all bench logs after running tests

This can help reveal failures from background jobs etc
 2023-12-28 20:50:27 +05:30
Ankush Menat
40b2f5115a
Merge pull request #24009 from ankush/sentry_misc_errors 
fix: misc errors from sentry
 2023-12-28 19:29:18 +05:30
Ankush Menat
4a8fb6c43c style: format 2023-12-28 19:16:11 +05:30
Ankush Menat
1ae79badf7 fix: only set change listener if available 2023-12-28 19:11:12 +05:30
Ankush Menat
0f099b1f1f fix: unconditionally pop ignore_user_type filter 
This isn't a real column.

SENTRY: FRAPPE-13Z
 2023-12-28 19:11:10 +05:30
Ankush Menat
bcd5d78dab fix: skip undefined path 2023-12-28 17:58:25 +05:30
Ankush Menat
9b458ad354
Merge pull request #23835 from akhilnarang/sentry-sync-fc 
refactor(sentry): sync up with FC implementation
 2023-12-28 17:38:06 +05:30
Rushabh Mehta
1501c5e1d3 fix(minor): spacing for sidebar item with child items 2023-12-28 15:58:44 +05:30
Ankush Menat
3a918fb18c
Merge pull request #24001 from ankush/fix_filter_check 
fix: incorrect duplicate filter check
 2023-12-28 14:56:37 +05:30
Ankush Menat
acf032f607 refactor: simplify duplicate filter checking code 
keeping track of `exists` variable is weird to read and prone to bugs...
what if next field makes exist = false, even if one filter already
exists?
 2023-12-28 14:53:45 +05:30
mergify[bot]
a9bb994f15
fix!: deterministic fixture import order (#22210) 
* feat: #20753 fixture export prefix and fixture import order

(cherry picked from commit 6a9c56a568e4ccf181fe9cb4153d0b9e4f02ac3d)

* refactor: clarify prefix logic, see c4866921df (r1196249038)

(cherry picked from commit cd2519e71e5545bd4c706369df3ea05843a0bfd9)

* style: format

* refactor: conditionally sort documents when importing

* refactor: simplify code

* feat: Unittest as requested in https://github.com/frappe/frappe/pull/22210#discussion_r1331587501

---------

Co-authored-by: To Finke <tom.finke@webterra.de>
Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-12-28 14:24:45 +05:30
Ankush Menat
ad8ad088c5
fix: force [] as default for child tables (#24000) 2023-12-28 13:48:35 +05:30
Ankush Menat
5d51ec2ba1
Revert "fix(text_editor): Fix bubble's link tooltip clipping (#23911)" (#23999) 
This reverts commit 91405493e5.
 2023-12-28 12:21:09 +05:30
mergify[bot]
3c015a1fd7
fix: sudan country info (#23709) (#23998) 
* Update country_info.json

Update Sudan Currency

* chore: fix currency symbol

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

[skip ci]

(cherry picked from commit 6b24b9aa13df00a257adfcd40892e4acce688fd4)

Co-authored-by: Ayman Mustafa <84941140+MEClouds@users.noreply.github.com>
 2023-12-28 11:40:03 +05:30
Ankush Menat
ac338b07da
Merge pull request #23975 from niraj2477/fix/import-log 
fix(Data Import): show failed import logs
 2023-12-28 11:09:31 +05:30
Raffael Meyer
3527489a04
feat: sort multicheck by label (#23985) 
* feat: sort multicheck by label

* fix: avoid double translation

* fix: always cast to string before comparing

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
 2023-12-28 11:07:49 +05:30
Anas AlGhanem
8583c01cad
fix(Geo): Add timezone for palestinian territory country (#23986) 
* Add timezone for palestinian territory country. It's blocking the first start wizard from completion.

* add currency and additional timezone for Palestine


[skip ci]
 2023-12-28 11:03:48 +05:30
Revant Nandgaonkar
37803a00d4
fix: strip exc from json response if traceback not allowed (#23989) 
* fix: strip exc from json response if traceback not allowed

* fix: use pop instead of del to avoid key error

* fix: Avoid showing exc when traceback is disabled

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-12-28 10:45:06 +05:30
Ankush Menat
e814af0aeb fix!: Init child tables as empty array on client side 2023-12-27 19:35:55 +05:30
Ankush Menat
c7e5afee6a refactor: Use arr.includes(item) instead of in_list(arr, item) 2023-12-27 19:33:13 +05:30
Akhil Narang
70bb2f45bb
Merge pull request #23590 from GursheenK/treeview-filters 2023-12-27 19:03:05 +05:30
Akhil Narang
d5d35704d8
feat(sentry): skip validation errors 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-27 18:43:33 +05:30
Gursheen Kaur Anand
0fadb6d9fc
fix: use sbool for better typecasting 
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-27 18:40:44 +05:30
Akhil Narang
34f03a2de2
fix(data_import): respect the value of show_failed_logs checkbox 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-27 16:58:04 +05:30
Jannat Patel
32469b5a81
fix: roles editor (#23976) 2023-12-27 16:17:31 +05:30
Ankush Menat
4996b8ac7b refactor: postgres version check 2023-12-27 16:12:40 +05:30
hhharsha36
445da4319b
fix: error - permission denied for schema public from Postgres >= 15 during initial DB setup (#23799) 
Error from Postgres:
ERROR:  permission denied for schema public at character 14

Error from Frappe:
psql:/home/frappe/frappe-bench/apps/frappe/frappe/database/postgres/framework_postgres.sql:72: ERROR:  permission denied for schema public

Error Causer:
Starting Postgres version >= 15, all users will have the `CREATE` permission revoked by default.

Fix:
Grant relevant privileges to the database in question for the user. In this case, DB owner privilege.

Note: the below two permission attempts were unsuccessful and still caused the same public schema permission error

GRANT USAGE, CREATE ON SCHEMA public TO {frappe.conf.db_name};
GRANT ALL ON SCHEMA public TO {frappe.conf.db_name}

References:
https://stackoverflow.com/questions/74110708/postgres-15-permission-denied-for-schema-public
https://stackoverflow.com/questions/67276391/why-am-i-getting-a-permission-denied-error-for-schema-public-on-pgadmin-4
 2023-12-27 16:04:21 +05:30
Corentin Flr
91405493e5
fix(text_editor): Fix bubble's link tooltip clipping (#23911) 
* fix(text_editor): Use body as bounds to avoid bubble's tooltip clipping

* fix(text_editor): Allow overflow for link tooltip
 2023-12-27 16:03:18 +05:30
14987
2e730d7056
fix(Data Import): show failed import logs 2023-12-27 15:06:24 +05:30
Ankush Menat
6367194620
perf: skip network call if no doc (#23967) 
If link field has no value then its title will always be undefined.
 2023-12-27 14:15:20 +05:30
Maharshi Patel
53ab3c6491 Merge branch 'develop' into numbercard_fix 2023-12-27 13:39:00 +05:30
Maharshi Patel
39136b01b6 fix: shortcut-widget-box should have flex-start 
As we changed align-items to space-between for widget head,
we need to override .shortcut-widget-box to flex-start
 2023-12-27 13:32:04 +05:30
Maharshi Patel
547523c7b4
fix(minor): mobile menu class (#23970) 
removed `.collapse.show` class as it is removed during opening animation of menu.
 2023-12-27 13:16:02 +05:30