Hussain Nagaria
ce3e029769
fix: incorrect class tags generation
2023-12-29 21:12:21 +05:30
Jannat Patel
bdc495f5d1
fix: show right permission for user cannot create doctypes ( #24027 )
2023-12-29 11:54:03 +05:30
Ankush Menat
0f099b1f1f
fix: unconditionally pop ignore_user_type filter
...
This isn't a real column.
SENTRY: FRAPPE-13Z
2023-12-28 19:11:10 +05:30
mergify[bot]
a9bb994f15
fix!: deterministic fixture import order ( #22210 )
...
* feat: #20753 fixture export prefix and fixture import order
(cherry picked from commit 6a9c56a568e4ccf181fe9cb4153d0b9e4f02ac3d)
* refactor: clarify prefix logic, see c4866921df (r1196249038)https://github.com/frappe/frappe/pull/22210#discussion_r1331587501
---------
Co-authored-by: To Finke <tom.finke@webterra.de>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-28 14:24:45 +05:30
Ankush Menat
ac338b07da
Merge pull request #23975 from niraj2477/fix/import-log
...
fix(Data Import): show failed import logs
2023-12-28 11:09:31 +05:30
Ankush Menat
c7e5afee6a
refactor: Use arr.includes(item) instead of in_list(arr, item)
2023-12-27 19:33:13 +05:30
Akhil Narang
34f03a2de2
fix(data_import): respect the value of show_failed_logs checkbox
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 16:58:04 +05:30
14987
2e730d7056
fix(Data Import): show failed import logs
2023-12-27 15:06:24 +05:30
barredterra
62d634eab4
Revert "fix: check the correct email account"
...
This reverts commit 2507c6af97
2023-12-22 11:28:05 +01:00
Ankush Menat
4d68a46b10
fix: Set default child table fields on save ( #23913 )
...
We set defaults on creation of new doc but when you append a new child
doc on existing document it doesn't seem to set the defaults.
This seems like a bug and not a deliberate choice.
2023-12-22 08:02:36 +00:00
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
...
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Kunhi
b4d3132bf4
fix: optimize clear_permissions_cache method ( #23858 )
...
* fix:optimize clear_permissions_cache method
* fix: faster clear user cache on perm change
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-20 16:26:17 +05:30
Daizy Modi
5213915d66
fix: render new doctype dialog box if doctype is not copied ( #23854 )
2023-12-20 14:11:01 +05:30
Hussain Nagaria
ecdd7b3e37
docs: consistency
2023-12-20 14:02:32 +05:30
Ankush Menat
1cbcf537d9
fix: Allow periodically clearing deleted documents
2023-12-20 12:09:15 +05:30
Hussain Nagaria
8d2137c265
docs: consistent doc strings
2023-12-18 18:27:39 +05:30
Akhil Narang
f110b6eea3
refactor(data_import): handle RQ timeouts better ( #23811 )
...
* refactor(data_import): handle RQ timeouts better
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor(data_import): display count of documents even for timed out jobs
Also handle "0" cases better - should be plural there
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-18 10:56:51 +05:30
Hussain Nagaria
49a4663228
docs: html2text
2023-12-16 16:49:35 +05:30
Ankush Menat
3adc83e7c6
perf(migrate): update only affected users via role profile ( #23821 )
...
This is same as https://github.com/frappe/frappe/pull/23820 but for role
profile
2023-12-16 08:29:26 +00:00
Ankush Menat
c38e842646
perf(migrate): Only re-evaluate users which are potentially changed ( #23820 )
...
When roles are added in fixture `desk_access` always appears to be
"changed" because of how fixtures work.
This causes all users with the said role to be re-evaluated. This is
unnecessary computation because desk_access rarely changes in most apps.
Fix: See if role's desk access is same as user's desk access and don't
re-evalute them.
E.g. If role fixture without desk access is being migrated then it will
skip all users who are already website users. Likewise role with desk
access will skip all users who are already system users.
2023-12-16 08:18:46 +00:00
Ankush Menat
d39ecd3932
fix: Consider user and sender both for "system user" ( #23806 )
...
Email is "sender" which might not be linked with any user.
2023-12-15 12:51:29 +05:30
Akhil Narang
cd7be151f7
fix(rq_job): resolve deprecation warning ( #23784 )
...
env/lib/python3.11/site-packages/rq/job.py:796: DeprecationWarning: job.exc_info is deprecated, use job.latest_result() instead.
warnings.warn("job.exc_info is deprecated, use job.latest_result() instead.", DeprecationWarning)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-12-14 15:22:26 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified ( #23697 )
...
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
Ankush Menat
57699a54b1
fix: Show server script name in traceback ( #23676 )
...
* fix: Show server script name in traceback
* chore: typo
Co-authored-by: Sagar Vora <sagar@resilient.tech>
---------
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-12-08 15:01:13 +05:30
barredterra
c35476256f
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Bernd Oliver Sünderhauf
b45df8d726
fix: Reload whenever the effective language or timezone has changed. ( #22952 )
...
* fix: Reload whenever the effective language or timezone has changed.
* fix: Reload as well when rounding method is changed.
2023-12-04 22:42:17 +05:30
Maharshi Patel
c1a3e64350
feat: disable assigned thread notification ( #23535 )
...
* feat: disable assigned thread notification
- currently, email notification is sent to the assigned users of any doc
when a new email is received.
- This is not desirable in some cases, so this commit adds a new
configuration option to disable this notification from notification settings.
* style: whitespace
2023-12-04 21:32:19 +05:30
mergify[bot]
ff08975de8
Merge pull request #23554 from barredterra/email-sender-name
...
feat: set sender name in documents created from email
2023-12-04 14:33:07 +00:00
hyaray
04a1e46ca4
fix: auto fetch module on report
...
* Update report.json
* fix: fetch only if empty
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-03 12:02:20 +05:30
Bernd Oliver Sünderhauf
8fea592f00
chore: Fix codestyle issue from #23557 . ( #23567 )
2023-12-03 09:25:31 +05:30
Corin Wenger
db315385d3
fix: Move SMS Log module from ERPNext to Frappe ( #23557 )
...
SMS Log module moved to Frappe Core from ERPNext Utilities so that Frappe send_sms() works sans-ERPNext.
2023-12-02 20:20:12 +05:30
barredterra
35d6e70382
feat: add sender_name_field
2023-12-01 18:39:39 +01:00
Ankush Menat
1e20820846
refactor: Indicate that weak hash functions are not usedforsecurity ( #23540 )
...
[skip ci]
2023-12-01 16:04:37 +05:30
Ankush Menat
c23771475c
refactor: Use hooks to specify default log clearing ( #23507 )
2023-11-30 13:06:29 +05:30
Ankush Menat
d61022536f
fix(UX): Indicate that email is scheduled
2023-11-27 20:50:40 +05:30
Ankush Menat
ded94bf050
Merge branch 'develop' into comm-send-after
2023-11-27 20:27:59 +05:30
Rushabh Mehta
2c34c71b43
refactor: Cleanup Login Settings in System Settings
2023-11-27 14:08:45 +05:30
Rushabh Mehta
4a25451f44
refactor: Add tabs to "System Settings"
2023-11-27 13:56:54 +05:30
Nabin Hait
ddac8af434
fix: ignore duplicate contact creation ( #23423 )
2023-11-24 18:16:02 +05:30
14987
0361fd8b8d
doc: Update doc string
2023-11-24 17:01:58 +05:30
14987
1bdc5997e5
feat(communication): Add send_after in communication
2023-11-24 16:57:19 +05:30
mergify[bot]
514ea6e259
Merge pull request #23309 from akhilnarang/drop-redundant-bool
...
refactor(treewide): code cleanup
2023-11-23 11:20:55 +00:00
Akhil Narang
f8c5a61bbd
refactor(report): simplify check further
...
NoneType will evaluate to False here so we don't need this complexity
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 15:54:13 +05:30
Akhil Narang
f007f16ce9
fix: handle invalid passwords better ( #23377 )
...
* chore(login): show a message for response code 500 as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor: reject passwords > 512 characters
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 15:35:37 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow ( #23369 )
2023-11-23 13:21:27 +05:30
Ankush Menat
a4cbe36cbe
Merge pull request #23132 from frappe/jitter-scheduling
...
perf(Scheduling): add jitter to job scheduling
2023-11-22 10:59:38 +05:30
David Arnold
f9141d04bf
fix(naming_rule): polish list view
2023-11-21 18:02:22 +01:00
18alantom
aeec01c7f9
perf(Scheduling): add jitter to job scheduling
...
Addresses #19007
2023-11-21 12:21:53 +05:30
Ankush Menat
cd189b3f7f
fix: remove link - modifying while iterating
2023-11-21 12:01:55 +05:30
