Xiaoguang Sun
1fe3b5d5bc
refactor(workspace): Optimize save call on workspace doc ( #24052 )
...
Optimize Workspace.save_page to call doc.save() only once therefore
eliminate sending unnecessary queries to database.
Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
2024-01-01 11:38:40 +05:30
Ankush Menat
1ae79badf7
fix: only set change listener if available
2023-12-28 19:11:12 +05:30
Akhil Narang
70bb2f45bb
Merge pull request #23590 from GursheenK/treeview-filters
2023-12-27 19:03:05 +05:30
Gursheen Kaur Anand
0fadb6d9fc
fix: use sbool for better typecasting
...
Co-authored-by: Akhil Narang <me@akhilnarang.dev>
2023-12-27 18:40:44 +05:30
Ankush Menat
a16db1be32
fix: show relative path in loaded JS ( #23964 )
...
[skip ci]
2023-12-27 10:46:30 +05:30
Shariq Ansari
77f04c9fc4
Merge pull request #23921 from shariquerik/minor-fix-1
...
chore: minor fix
2023-12-23 11:54:13 +05:30
Shariq Ansari
fc13ff5f29
chore: minor fix
2023-12-23 11:39:39 +05:30
Ankush Menat
5e2ace4c08
perf: Use set for tracking whitelisted methods ( #23905 )
...
List look ups are O(N). This is still a microoptimization at best
considering other overhead.
2023-12-21 23:19:06 +05:30
Gursheen Anand
a15b1dee95
fix: correctly typecast disabled flag
2023-12-21 18:30:16 +05:30
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
...
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Hussain Nagaria
8d2137c265
docs: consistent doc strings
2023-12-18 18:27:39 +05:30
Suraj Shetty
2564d0e939
Merge pull request #23512 from GursheenK/include-filter-values-in-exported-report-excel
2023-12-18 12:40:37 +05:30
Gursheen Anand
806708650c
chore: linter issue
2023-12-18 12:15:51 +05:30
Gursheen Anand
4a7c60fb5a
refactor: use simple condition for filter values
2023-12-15 17:02:09 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified ( #23697 )
...
Global search and replace operation, including single doctypes where it does not really matter.
2023-12-13 09:52:14 +05:30
barredterra
2f7b9f8a5a
fix: get users for leaderboard
2023-12-11 18:07:30 +01:00
Ankush Menat
57699a54b1
fix: Show server script name in traceback ( #23676 )
...
* fix: Show server script name in traceback
* chore: typo
Co-authored-by: Sagar Vora <sagar@resilient.tech>
---------
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2023-12-08 15:01:13 +05:30
Trusted Computer
61425cf858
fix: remove redundant breadcrumbs
...
Remove redundant frappe.breadcrumbs.add from notifications_settings
2023-12-07 10:22:13 +05:30
Raffael Meyer
76afbaaa40
Merge pull request #23609 from barredterra/de-morgan
2023-12-06 22:21:01 +01:00
barredterra
9ada76df6c
chore: deprecate old show_progress
2023-12-05 19:30:43 +01:00
barredterra
09395420b8
feat: task_id for submit_cancel_or_update_docs
2023-12-05 19:30:13 +01:00
barredterra
105c4a20fb
refactor: better variable names
2023-12-05 19:19:56 +01:00
barredterra
c35476256f
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
Maharshi Patel
c1a3e64350
feat: disable assigned thread notification ( #23535 )
...
* feat: disable assigned thread notification
- currently, email notification is sent to the assigned users of any doc
when a new email is received.
- This is not desirable in some cases, so this commit adds a new
configuration option to disable this notification from notification settings.
* style: whitespace
2023-12-04 21:32:19 +05:30
Gursheen Anand
76a200028e
fix: make internal parameter optional
2023-12-04 19:00:24 +05:30
mahsem
551aaafefc
fix: update setup_wizard.py translation ( #23583 )
...
* Update setup_wizard.py translation
Import frappe _ and translate some untranslated strings
* style: format
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-12-04 18:23:09 +05:30
Gursheen Anand
f8d4014a00
feat: add disabled filter in get_children
2023-12-04 13:08:33 +05:30
Bernd Oliver Sünderhauf
f2b27b9a4f
fix: Turn Route History read-only.
2023-12-04 04:49:15 +01:00
Gursheen Anand
54d3679b9d
fix: format filters with multiple values
2023-12-01 13:07:39 +05:30
Gursheen Anand
8a4d85a5ad
fix: parse applied filter json before building data
2023-11-30 15:07:30 +05:30
Ankush Menat
b2dafe5acd
refactor: Avoid alias for dashboard chart
2023-11-29 13:12:53 +05:30
Shariq Ansari
c19f426bd5
Merge pull request #23447 from shariquerik/allow-internal-routing-using-url-option
2023-11-27 15:15:46 +05:30
Shariq Ansari
597a53e4c1
fix: allow internal routing using workspace shortcut url option
2023-11-27 14:20:27 +05:30
Ankush Menat
1d5d06e924
Merge pull request #23418 from akhilnarang/return-traceback-for-setupwizard-failure
...
fix(setup_wizard): don't suppress original exception
2023-11-27 11:51:40 +05:30
Ankush Menat
e8fe3b2166
Merge pull request #23414 from ankush/bulk_actions_bg
...
perf: run bulk actions using background jobs
2023-11-24 18:33:38 +05:30
Akhil Narang
db3ffaf658
refactor: check for last response error
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:31 +05:30
Akhil Narang
d48c3f5f60
refactor: return message in response as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 18:25:07 +05:30
Akhil Narang
461f479b45
feat(setup_wizard): store error in error log as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:43:44 +05:30
Akhil Narang
9aec553b89
fix(setup_wizard): sync password character limit with other places ( #23419 )
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:26:34 +05:30
Akhil Narang
838a49ebc2
fix(setup_wizard): don't suppress original exception
...
Raise it so that the user can know what went wrong
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-24 17:13:34 +05:30
Ankush Menat
6cf168a56f
fix: bulk workflow action in background
2023-11-24 17:04:09 +05:30
Ankush Menat
866a0295e3
fix: bulk submit/cancel/update in background jobs
2023-11-24 16:38:04 +05:30
Ankush Menat
077218156b
fix: always publish progress for bulk action
2023-11-24 16:38:04 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Indrajith.vs
a5b102dcd2
fix: button "Add Chart to Dashboard" visible before saving ( #23256 )
...
* fix: dashboard chart - add chart to dashboard btn fix
* style: format
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-22 16:00:09 +05:30
Akhil Narang
da1fb2ff4e
fix(event/sync_communication): add distinct while querying communication links
...
There's cases where these are duplicated
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-21 13:01:19 +05:30
TechnicalShree
90cf6bb829
feat: Enabling Redirection to a Custom URL on Notification Click ( #22956 )
...
* feat: notification custom routing
* Update frappe/public/js/frappe/ui/notifications/notifications.js
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* code refactoring
* field name correction
* fix: json
* fix: auto generation
* lint fix
* fix: lint
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-21 01:23:41 +05:30
Akhil Narang
eb45da3913
feat: Allow usage of print() within safe_exec() ( #23084 )
...
* feat(safe_exec): allow usage of `print()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor(system_console): update description to mention `print()` instead of `log()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: unconditionally add debug logs to response if present
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore(safe_exec): add in a test for running `print()` within safe_exec
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix(safe_exec): ignore warning
RestrictedPython warns us if we call `print()` don't use their `printed` variable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: store debug logs from scheduled jobs
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix: avoid ignoring warnings, disabled in prod anyway
* chore: remove unnecessary logging
This can be moved to level 2 when required
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-20 12:45:41 +05:30
sibi kumar k
c3b0da60d1
feat: Add image view in Workspace shortcut block ( #23041 )
...
* Feat:Add image view in Workspace creation
* image view condition
2023-11-20 11:56:05 +05:30
Shariq Ansari
c0d47d8ddd
chore: linter fix
2023-11-20 11:46:09 +05:30