Ankush Menat
19e0fe65f5
fix: allow guests to view published Newsletters
2023-12-29 18:04:29 +05:30
Ankush Menat
c7e5afee6a
refactor: Use arr.includes(item) instead of in_list(arr, item)
2023-12-27 19:33:13 +05:30
Akhil Narang
25ba2822be
Merge pull request #23431 from barredterra/newsletter-welcome-url
...
feat(Newsletter): redirect to welcome URL
2023-12-21 17:10:06 +05:30
Ankush Menat
0fd6f5eed7
Merge pull request #23827 from frappe/api-docs
...
docs: add Python API missing docstrings / type hints
2023-12-21 12:13:05 +05:30
Hussain Nagaria
8d2137c265
docs: consistent doc strings
2023-12-18 18:27:39 +05:30
barredterra
70c7315ed8
Merge branch 'develop' into jinja-syntax
2023-12-17 19:54:16 +01:00
Ritwik Puri
0aea1de0f4
chore: remove testing internet connection for emails ( #23581 )
2023-12-13 09:55:29 +05:30
barredterra
a586b5a1c6
feat(Email Template): switch from pure HTML to Jinja highlighting
2023-12-12 20:05:58 +01:00
barredterra
c35476256f
refactor: simplify conditional logic
...
Command: `sourcery review --fix --enable de-morgan .`
2023-12-05 11:14:41 +01:00
mergify[bot]
ff08975de8
Merge pull request #23554 from barredterra/email-sender-name
...
feat: set sender name in documents created from email
2023-12-04 14:33:07 +00:00
Raffael Meyer
3198b4f490
feat(DX): button "Pull Emails" ( #23553 )
2023-12-02 13:04:01 +05:30
barredterra
1dca311856
feat: set sender_name_field in reference doc
2023-12-01 19:48:47 +01:00
barredterra
1d2e2da374
refactor: email _create_reference_document
...
- Return only docname instead of entire doc
- Remove unused property is_first
- Fix fallback on duplicate entry error
2023-12-01 19:48:20 +01:00
barredterra
9a1429d9c2
refactor: typo in variable name
2023-12-01 18:41:10 +01:00
Ankush Menat
f01937c788
fix(DX): return email queue doc ( #23495 )
2023-11-29 17:34:42 +00:00
barredterra
66ac92aab6
fix: skip invalid email addresses
...
... while adding members to Email Group
2023-11-25 17:07:15 +01:00
barredterra
563f9b00b5
refactor: validate Newsletter recipients at source
2023-11-25 17:05:12 +01:00
barredterra
e5f428ab8b
feat(Newsletter): redirect to welcome URL
2023-11-24 19:36:24 +01:00
barredterra
06fbe6df20
fix: default Email Group in system language
2023-11-23 16:51:23 +01:00
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Maharshi Patel
c2309969d5
fix: typo in strip folder name quotes ( #23368 )
...
fixed incorrect negative index.
2023-11-23 06:16:54 +00:00
Suraj Shetty
250dbf6a1c
fix(email): Allow users to pull all (read & unread) emails during initial sync
2023-11-22 13:09:34 +05:30
Shariq Ansari
a14966c980
Merge pull request #22595 from blaggacao/fix/non-html-notifications-rendered-from-files
2023-11-18 21:06:12 +05:30
David Arnold
90b076a75a
feat(notification): specify message type (html, md, txt)
2023-11-17 15:00:12 +01:00
mergify[bot]
443d508669
Merge pull request #22884 from zeel-codder/fix-email-message-email-group
...
fix: use the use_html check in the Email Group
2023-11-17 06:17:17 +00:00
Akhil Narang
50129d3220
refactor(email_group): simplify logic to figure out which response to use
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-16 18:01:33 +05:30
Maharshi Patel
0b4f06c325
fix: remove quotes from IMAP Folder Name ( #23242 )
...
Quotes were added around folder name as spaces would cause issue with IMAP.
This extra quotes are also passed to query which sets the
uidnext and uidvalidity. where condition is never met
This values are used on subsequent pulls and without this values,
it is considered first pull and all UNSEEN mails are synced.
So even If user selected All in sync option it will always work as UNSEEN
option.
When UNSEEN is used it will mark all emails as seen on IMAP server when pulled.
2023-11-16 17:36:39 +05:30
David Arnold
77b1d58428
Merge remote-tracking branch 'upstream/develop' into fix/non-html-notifications-rendered-from-files
2023-11-13 10:00:49 +01:00
David Arnold
fe8cc7a5c2
fix: non-html notifications from files
2023-11-09 09:51:39 +01:00
Ankush Menat
e14349d656
fix: newsletter indicator filters
...
strings are all truthy.
closes https://github.com/frappe/frappe/issues/23107
2023-11-07 20:10:48 +05:30
Ankush Menat
3905e8970a
test: smtp integration test using smtp4dev
2023-11-04 15:26:40 +05:30
Ankush Menat
3211a77dc8
fix: handle emails sent from console
2023-11-04 14:30:37 +05:30
Ankush Menat
089985e53b
feat: frappe.job local for reading job info
2023-11-04 14:06:31 +05:30
Ankush Menat
ecca32853e
test: ensure that same smtpserver is being reused
2023-11-04 13:53:08 +05:30
Ankush Menat
0362de82bb
fix: Mark fake site config emali account with internal attribute
2023-11-04 13:41:18 +05:30
Ankush Menat
a4382fda5a
fix: Automatically close SMTP connections on exit
2023-11-04 11:51:42 +05:30
Ankush Menat
d5d0dfb58b
perf: Reuse SMTP connection when flushing email queue
...
This depends on https://github.com/frappe/frappe/pull/23070
2023-11-04 11:32:48 +05:30
Ankush Menat
4e318a0280
fix: Abort flushing email queue if >50% fail.
...
When email queue batch failes >33% with >10 count, frappe will now abort
sending emails.
We already notify users via system notification so this
assumes that user will notice it and fix it in sometime.
With previous commits we also prioritize fresh emails over retries.
2023-11-04 11:25:09 +05:30
Ankush Menat
050c0b26f8
fix: flush emails from single background jobs
2023-11-04 11:23:44 +05:30
Ankush Menat
be2beeed9e
fix: improve email queue reliability ( #23070 )
...
* feat: control email queue batch size with config
* fix: Give emails who failed once less priority while sending
2023-11-03 15:10:37 +05:30
Ankush Menat
60e6fb005e
fix: Show excat OSError when creating SMTP session ( #23067 )
2023-11-02 17:23:19 +05:30
Kevin Shenk
ca3ecc2da7
fix: Strip HTML tags from SMS Notifications ( #22880 )
2023-10-30 18:34:35 +05:30
zeel-codder
79b67a4b83
fix: Update email_message in the send_welcome_email function to use the use_html check for Email Template
2023-10-24 13:51:12 +05:30
Ankush Menat
a930872fd6
fix: pass default SSL context for imap/poplib ( #22873 )
2023-10-23 16:51:15 +05:30
Ankush Menat
135fb6a486
chore: remove py2 compatibilty code
2023-10-21 13:40:04 +05:30
Ankush Menat
bdc5aba7ad
refactor: Use client.set_value instead of db.set_value ( #22814 )
2023-10-19 13:07:37 +05:30
Ankush Menat
018ed845bd
refactor: defer unnecessary json-dumping of messages
...
Also avoid accessing locals where interface is present like for popping last message.
2023-10-16 18:13:50 +05:30
Sayed Ayman
94263bf4f2
feat (notificaion): email from 'Table Multiselect' field ( #22733 )
...
* feat (notificaion): table multiselect field
* refactor: use model.table_fields instead of duplicating
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-10-16 12:02:19 +05:30
Akhil Narang
41d524c9a0
chore: add in a test for failed email notification
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-13 18:16:32 +05:30
Ankush Menat
e72b03adaf
refactor: handle notification failure
2023-10-13 14:59:00 +05:30